Skip to content

USB: serial: fix TIOCMBIS and TIOCMBIC

Johan Hovold linux-usb lkml stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8USB: serial: belkin_sa: fix TIOCMBIS and TIOCMBICdrivers/usb/serial/belkin_sa.c+17 -110 replies
2/8USB: serial: kobil_sct: fix TIOCMBIS and TIOCMBICdrivers/usb/serial/kobil_sct.c+9 -90 replies
3/8USB: serial: belkin_sa: clean up tiocmset()drivers/usb/serial/belkin_sa.c+6 -160 replies
4/8USB: serial: kobil_sct: clean up tiocmset()drivers/usb/serial/kobil_sct.c+26 -350 replies
5/8USB: serial: kobil_sct: clean up device type checksdrivers/usb/serial/kobil_sct.c+10 -90 replies
6/8USB: serial: kobil_sct: add control request helpersdrivers/usb/serial/kobil_sct.c+27 -810 replies
7/8USB: serial: kobil_sct: clean up set_termios()drivers/usb/serial/kobil_sct.c+16 -100 replies
8/8USB: serial: kobil_sct: drop unnecessary initialisationsdrivers/usb/serial/kobil_sct.c+2 -40 replies

Reviews trailers per patch

None of the 8 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchGreg Kroah-Hartman
SeriesR-b
1/8
2/8
3/8
4/8
5/8
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/8] USB: serial: fix TIOCMBIS and TIOCMBIC

Asserting or deasserting a modem control line using TIOCMBIS or TIOCMBIC should not deassert any lines that are not in the mask, but two drivers got this wrong.

Included are also some related cleanups.

Johan

Johan Hovold (8):
USB: serial: belkin_sa: fix TIOCMBIS and TIOCMBIC
USB: serial: kobil_sct: fix TIOCMBIS and TIOCMBIC
USB: serial: belkin_sa: clean up tiocmset()
USB: serial: kobil_sct: clean up tiocmset()
USB: serial: kobil_sct: clean up device type checks
USB: serial: kobil_sct: add control request helpers
USB: serial: kobil_sct: clean up set_termios()
USB: serial: kobil_sct: drop unnecessary initialisations

 drivers/usb/serial/belkin_sa.c |  42 +++----
 drivers/usb/serial/kobil_sct.c | 210 ++++++++++++---------------------
 2 files changed, 95 insertions(+), 157 deletions(-)
Signature · 1 line
2.49.1