Skip to content

Add Bananapi R4 Pro support

Frank Wunderlich linux-arm-kernel linux-devicetree linux-gpio linux-mediatek lkml 2 versions – Applied

Status from this message: Applied to v6.18-next/dts64, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 7 repliesApplied
  2. v16 patches 11 repliesApplied

Changes in v2 from the cover letter

- dropped "dt-bindings: arm: mediatek: add BPI-R4 Pro board" which was applied from v1
- added new patch "disable 2.5G phy and enable at board layer"
- squashed "mt7988a: Add label for ssusb0" to r4pro dts commit
- some updates after angelos review to the r4pro dts commit
- fixed buck4 and ldo displayed voltage (cannot be controlled by software) to match schematic
- reorder fan after eth node (alphanumeric)
- reorder spi-tx after spi-rx (alphanumeric)
- follow reg first, then others also for spi-nand partitions
- drop 2pg5 phy disabling node (due to new patch disabling by default)
- change order of pinctrl (first number than names)
- fix commit prefix (mediatek was missing)

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/5dt-bindings: pinctrl: mt7988: allow gpio-hogsDocumentation/devicetree/bindings/pinctrl/mediatek,mt7988-pinctrl.yaml+5 -06 replies
2/5arm64: dts: mediatek: mt7988: Disable 2.5G phy and enable at board layerarch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-2g5.dts arch/arm64/boot/dts/mediatek/mt7988a.dtsi+2 -00 replies
3/5arm64: dts: mediatek: mt7988: Add devicetree for BananaPi R4 Proarch/arm64/boot/dts/mediatek/Makefile arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro-4e.dts arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro-8x.dts +2 more+571 -10 replies
4/5arm64: dts: mediatek: mt7988a-bpi-r4-pro: Add PCIe overlaysarch/arm64/boot/dts/mediatek/Makefile arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro-cn15.dtso arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro-cn18.dtso+42 -00 replies
5/5arm64: dts: mediatek: mt7988a-bpi-r4pro: Add mmc overlaysarch/arm64/boot/dts/mediatek/Makefile arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro-emmc.dtso arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro-sd.dtso+66 -00 replies

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchKrzysztof KozlowskiAngeloGioacchino Del Regno
1/5R-b R-b R-b
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/5] Add Bananapi R4 Pro support

From: Frank Wunderlich <[email protected]>

BananaPi R4 Pro is a MT7988A based board which exists in 2 different hardware versions:

- 4E: 4 GB RAM and using internal 2.5G Phy for WAN-Combo
- 8X: 8 GB RAM and 2x Aeonsemi AS21010P 10G phys

common parts:

- MediaTek MT7988A Quad-core Arm Corex-A73,1.8GHz processor
- 8GB eMMC flash
- 256MB SPI-NAND Flash
- Micro SD card slot
- 1x 10G SFP+ WAN
- 1x 10G SFP+ LAN
- 4x 2.5G RJ45 LAN (MxL86252C)
- 1x 1G RJ45 LAN (MT7988 internal switch)
- 2x miniPCIe slots with PCIe3.0 2lane interface for Wi-Fi NIC
- 2x M.2 M-KEY slots with PCIe3.0 1lane interface for NVME SSD
- 3x M.2 B-KEY slots with USB3.2 for 5G Module (PCIe shared with key-m)
- 1x USB3.2 slot
- 1x USB2.0 slot
- 1x USB TypeC Debug Console
- 2x13 PIN Header for expanding application

official product information:
https://docs.banana-pi.org/en/BPI-R4_Pro/BananaPi_BPI-R4_Pro

The PCIe is per default in key-m state and can be changed to key-b with the pcie-overlays.

changes:
v2:
- dropped "dt-bindings: arm: mediatek: add BPI-R4 Pro board" which was applied from v1
- added new patch "disable 2.5G phy and enable at board layer"
- squashed "mt7988a: Add label for ssusb0" to r4pro dts commit
- some updates after angelos review to the r4pro dts commit
- fixed buck4 and ldo displayed voltage (cannot be controlled by software) to match schematic
- reorder fan after eth node (alphanumeric)
- reorder spi-tx after spi-rx (alphanumeric)
- follow reg first, then others also for spi-nand partitions
- drop 2pg5 phy disabling node (due to new patch disabling by default)
- change order of pinctrl (first number than names)
- fix commit prefix (mediatek was missing)

Frank Wunderlich (5):
dt-bindings: pinctrl: mt7988: allow gpio-hogs
arm64: dts: mediatek: mt7988: disable 2.5G phy and enable at board
layer
arm64: dts: mediatek: mt7988: Add devicetree for BananaPi R4 Pro
arm64: dts: mediatek: mt7988a-bpi-r4-pro: add PCIe overlays
arm64: dts: mediatek: mt7988a-bpi-r4pro: Add mmc overlays

 .../pinctrl/mediatek,mt7988-pinctrl.yaml      |   5 +
 arch/arm64/boot/dts/mediatek/Makefile         |   8 +
 .../mediatek/mt7988a-bananapi-bpi-r4-2g5.dts  |   1 +
 .../mt7988a-bananapi-bpi-r4-pro-4e.dts        |  16 +
 .../mt7988a-bananapi-bpi-r4-pro-8x.dts        |  16 +
 .../mt7988a-bananapi-bpi-r4-pro-cn15.dtso     |  20 +
 .../mt7988a-bananapi-bpi-r4-pro-cn18.dtso     |  20 +
 .../mt7988a-bananapi-bpi-r4-pro-emmc.dtso     |  33 ++
 .../mt7988a-bananapi-bpi-r4-pro-sd.dtso       |  31 +
 .../mediatek/mt7988a-bananapi-bpi-r4-pro.dtsi | 534 ++++++++++++++++++
 arch/arm64/boot/dts/mediatek/mt7988a.dtsi     |   3 +-
 11 files changed, 686 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro-4e.dts
 create mode 100644 arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro-8x.dts
 create mode 100644 arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro-cn15.dtso
 create mode 100644 arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro-cn18.dtso
 create mode 100644 arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro-emmc.dtso
 create mode 100644 arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro-sd.dtso
 create mode 100644 arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro.dtsi
Signature · 1 line
2.43.0