Skip to content

iio: mpl3115: support for events

Antoni Pokusinski linux-iio lkml 4 versions – Applied

Status from this message: Applied to the togreg branch of iio.git but initially pushed out as

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 1 replyApplied
  2. v33 patches 14 repliesSuperseded
  3. v22 patches 3 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches6 repliesSuperseded

Changes in v4 from the cover letter

(patch 1/3 "use get_unaligned_be24() to retrieve pressure data")
* commit msg: "get_unaligned_be24" -> "get_unaligned_be24()"
* read_info_raw: renamed "tmp[3]" -> "press_be24[3]"
* read_info_raw: added comment at pressure val computation (patch 2/3 "add threshold support")
* interrupt_handler: added sizeof() in a i2c_read_i2c_block call
* read_thresh: renamed "tmp" -> "press_tgt"
* write_thresh: renamed "tmp" -> "press_tgt"

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/3iio: mpl3115: use get_unaligned_be24() to retrieve pressure datadrivers/iio/pressure/mpl3115.c+10 -30 replies
2/3iio: mpl3115: add threshold events supportdrivers/iio/pressure/mpl3115.c+211 -100 replies
3/3iio: ABI: document pressure event attributesDocumentation/ABI/testing/sysfs-bus-iio+2 -00 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchMarcelo Schmitt
1/3R-b
2/3
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/3] iio: mpl3115: support for events

Hello,
The mpl3115 device can raise interrupts when a pressure or temperature threshold is crossed, this patchset adds support for them using IIO's events interface.

In v4 mostly some minor variable rename changes and a comment in read_info_raw according to the review in v3.

Kind regards,
Antoni Pokusinski

---
Changes since v3:
(patch 1/3 "use get_unaligned_be24() to retrieve pressure data")
* commit msg: "get_unaligned_be24" -> "get_unaligned_be24()"
* read_info_raw: renamed "tmp[3]" -> "press_be24[3]"
* read_info_raw: added comment at pressure val computation (patch 2/3 "add threshold support")
* interrupt_handler: added sizeof() in a i2c_read_i2c_block call
* read_thresh: renamed "tmp" -> "press_tgt"
* write_thresh: renamed "tmp" -> "press_tgt"

Changes since v2:
(general)
* added the patch tidying up the pressure data retrieval (u8[3] used) (patch 2/3 "add threshold support")
* includes: removed unused linux/units.h
* read_thresh: fixed comment formatting
* interrupt_handler: val_press is now u8[3] instead of __be32

Changes since v1:
(general)
* squashed the cleanup patch
* added the patch with the documentation update
(patch 1/2 "add threshold event support")
* patch description: explained changes in locking
* read_event_config: replaced switch with ifs
* read_event_config: return as early as possible, got rid of int_en_mask
* read/write_thresh: pressure: calculation changes to comply with raw ABI
* interrupt_handler: reordered the INT_SRC_* bits in if condition
* read/write_thresh: used sizeof() and values from limits.h
* write_thresh: replaced u8 tmp[2] with __be16 tmp
* dropped the space between casting (u8 *) &tmp

Antoni Pokusinski (3):
iio: mpl3115: use get_unaligned_be24() to retrieve pressure data
iio: mpl3115: add threshold events support
iio: ABI: document pressure event attributes

 Documentation/ABI/testing/sysfs-bus-iio |   2 +
 drivers/iio/pressure/mpl3115.c          | 234 ++++++++++++++++++++++--
 2 files changed, 223 insertions(+), 13 deletions(-)

base-commit: 1d09cf18cc91d29f650ad9811ed4868d9304d6c7

Signature · 1 line
2.25.1