Add device tree support for NVIDIA Tegra CMDQV
Status from this message: Applied, thanks.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v8 Latest4 patches 6 repliesApplied
- v74 patches 17 repliesSuperseded
- v64 patches 4 repliesSuperseded
Earlier versions · 4
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v4 | 3 patches | 4 replies | Superseded | |
| v3 | 3 patches | 7 replies | Superseded | |
| v2 | 3 patches | 7 replies | Superseded | |
| v1 | 3 patches | 9 replies | Superseded |
Changes in v8 from the cover letter
- Changed CMDQV device print from info to debug.
- Removed the CMDQV example for Nvidia from arm-smmu-v3 bindings yaml.
Patches in v8 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | iommu/tegra241-cmdqv: Decouple driver from ACPIdrivers/ drivers/ drivers/ | +14 | 0 replies | |
| 2/4 | iommu/arm-smmu-v3: Add device-tree support for CMDQV driverdrivers/ | +32 | 1 reply | |
| 3/4 | dt-bindings: iommu: Add NVIDIA Tegra CMDQV supportDocumentation/ Documentation/ | +68 | 2 replies | |
| 4/4 | arm64: dts: nvidia: Add nodes for CMDQVarch/ arch/ | +53 | 2 replies |
Reviews trailers per patch
3 of 4 patches have a Reviewed-by or Acked-by.
| Patch | Nicolin Chen | Rob Herring (Arm) | Jon Hunter |
|---|---|---|---|
| 1/4 | |||
| 2/4 | R-b | R-b | |
| 3/4 | A-b | R-b | R-b |
| 4/4 | A-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH V8 0/4] Add device tree support for NVIDIA Tegra CMDQV
This series adds device tree support for the CMDQ-Virtualization (CMDQV) hardware on NVIDIA Tegra264 SoCs.
CMDQV is a hardware block that works alongside the ARM SMMUv3 to assist in virtualizing the command queue. It was previously only supported through ACPI on Tegra241. This series extends the existing driver to support device tree based initialization, which is required for Tegra264 platforms.
The series is structured as follows:
Patch 1: Decouple tegra241-cmdqv driver from ACPI by replacing all the
ACPI functions with standard platform functions.
Patch 2: Extends the tegra241-cmdqv driver to support device tree probing
alongside the existing ACPI support. The SMMU driver now parses the nvidia,cmdqv phandle to associate each SMMU with its corresponding CMDQV instance.
Patch 3: Adds device tree binding documentation for nvidia,tegra264-cmdqv
and extends the arm,smmu-v3 binding with an optional nvidia,cmdqv property.
Patch 4: Adds CMDQV device nodes to the Tegra264 device tree and enables
them on the tegra264-p3834 platform.
The implementation follows the existing ACPI probe path to minimize code divergence and maintain consistency with Tegra241 support.
Changes in V8:
- Changed CMDQV device print from info to debug.
- Removed the CMDQV example for Nvidia from arm-smmu-v3 bindings yaml.
Changes in V7:
- Hold reference on platform device (impl_dev) and drop ref on ACPI device (adev).
Changes in V6:
- Added Nicolin's patch for decoupling tegra241-cmdqv from ACPI and rebased other patches on top of it.
- Removed put_device() from DT path as tegra241-cmdqv driver takes care of dropping reference in remove callback.
Changes in V5:
- Guard ACPI functions with CONFIG_ACPI to fix build without ACPI.
Changes in V4:
- Removed platform driver registration from tegra241-cmdqv.c to avoid duplicate module init/cleanup symbols
- Fixed the ordering of properties in CMDQV device tree nodes
- Added "Reviewed-by: Rob Herring" for binding documentation patch(2/3) carry-forwarding from V3.
Changes in V3:
- Remove the Kconfig dependency for CONFIG_TEGRA241_CMDQV
- Drop the reference on the platform device after getting it from of_find_device_by_node()
- Remove the unnecessary "nvidia,tegra264-smmu" compatible string from arm-smmu-v3 match table
- Order CMDQV nodes in device tree files according to its address
Changes in V2:
- Updated dependency for CONFIG_TEGRA241_CMDQV on OF || ACPI
- Changed maintainer to Nicolin Chen
- Removed interrupt-names property
Ashish Mhetre (3):
iommu/arm-smmu-v3: Add device-tree support for CMDQV driver
dt-bindings: iommu: Add NVIDIA Tegra CMDQV support
arm64: dts: nvidia: Add nodes for CMDQV
Nicolin Chen (1):
iommu/tegra241-cmdqv: Decouple driver from ACPI
.../bindings/iommu/arm,smmu-v3.yaml | 27 +++++- .../bindings/iommu/nvidia,tegra264-cmdqv.yaml | 42 ++++++++++ .../arm64/boot/dts/nvidia/tegra264-p3834.dtsi | 8 ++ arch/arm64/boot/dts/nvidia/tegra264.dtsi | 50 +++++++++-- drivers/iommu/arm/Kconfig | 1 - drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 35 +++++++- .../iommu/arm/arm-smmu-v3/tegra241-cmdqv.c | 84 +++---------------- 7 files changed, 167 insertions(+), 80 deletions(-) create mode 100644 Documentation/devicetree/bindings/iommu/nvidia,tegra264-cmdqv.yaml
Signature · 1 line
2.25.1