Skip to content

NFS: Client Side Directory Delegations

Anna Schumaker linux-nfs linux-tegra 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5NFS: Add support for sending GDD_GETATTRfs/nfs/nfs4xdr.c include/linux/nfs_xdr.h+113 -00 replies
2/5NFS: Request a directory delegation on ACCESS, CREATE, and UNLINKfs/nfs/delegation.c fs/nfs/delegation.h fs/nfs/nfs4proc.c +2 more+60 -45 replies
3/5NFS: Request a directory delegation during RENAMEfs/nfs/nfs3proc.c fs/nfs/nfs4proc.c fs/nfs/proc.c +2 more+12 -50 replies
4/5NFS: Shortcut lookup revalidations if we have a directory delegationfs/nfs/delegation.h fs/nfs/dir.c fs/nfs/inode.c+27 -00 replies
5/5NFS: Add a module option to disable directory delegationsfs/nfs/delegation.c fs/nfs/delegation.h fs/nfs/nfs4proc.c+11 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] NFS: Client Side Directory Delegations

From: Anna Schumaker <[email protected]>

This patchset adds support for recallable directory delegations in the NFS client, letting us shortcut some directory revalidation steps since we know the directory hasn't changed from underneath us.

I tried to limit requesting a dir delegation to when we think the user is doing work within a directory, so I look for ACCESS, CREATE, UNLINK, and (same directory) RENAME calls. I'm open to suggestions for other times I should be requesting a dir delegation too.

Finally, I add a new "directory_delegations" module parameter for controlling the usage of directory delegations since they are still a new feature. I (optimistically) have them enabled by default, and setting this option to false will disable requesting delegations and cause the client to return any existing delegations on the next use.

I'm happy to hear any suggestions for improvements! Anna

Anna Schumaker (5):
NFS: Add support for sending GDD_GETATTR
NFS: Request a directory delegation on ACCESS, CREATE, and UNLINK
NFS: Request a directory delegation during RENAME
NFS: Shortcut lookup revalidations if we have a directory delegation
NFS: Add a module option to disable directory delegations

 fs/nfs/delegation.c       |   8 +++
 fs/nfs/delegation.h       |  13 +++++
 fs/nfs/dir.c              |  19 +++++++
 fs/nfs/inode.c            |   3 ++
 fs/nfs/nfs3proc.c         |   3 +-
 fs/nfs/nfs4proc.c         |  62 ++++++++++++++++++++--
 fs/nfs/nfs4xdr.c          | 106 ++++++++++++++++++++++++++++++++++++++
 fs/nfs/proc.c             |   3 +-
 fs/nfs/unlink.c           |   3 +-
 include/linux/nfs_fs.h    |   1 +
 include/linux/nfs_fs_sb.h |   1 +
 include/linux/nfs_xdr.h   |  10 +++-
 12 files changed, 223 insertions(+), 9 deletions(-)
Signature · 1 line
2.51.2