perf stat fixes and improvements
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest10 patches 15 repliesIn review
- v39 patches 1 replySuperseded
v1 from the cover letter
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | libperf cpumap: Reduce allocations and sorting in intersecttools/ | +19 | 0 replies | |
| 2/10 | perf pmu: perf_cpu_map__new_int to avoid parsing a stringtools/ tools/ | +2 | 0 replies | |
| 3/10 | perf tool_pmu: Use old_count when computing count values for time eventstools/ tools/ | +46 | 0 replies | |
| 4/10 | perf stat-shadow: Read tool events directlytools/ | +66 | 3 replies | |
| 5/10 | perf stat: Reduce scope of ru_statstools/ tools/ tools/ +1 more | +18 | 1 reply | |
| 6/10 | perf stat: Reduce scope of walltime_nsecs_statstools/ tools/ tools/ +3 more | +10 | 0 replies | |
| 7/10 | perf tool_pmu: More accurately set the cpus for tool eventstools/ tools/ tools/ | +27 | 4 replies | |
| 8/10 | perf evlist: Reduce affinity use and move into iterator, fix no affinitytools/ tools/ tools/ +2 more | +189 | 0 replies | |
| 9/10 | perf stat: Read tool events lasttools/ tools/ | +28 | 3 replies | |
| 10/10 | perf stat: Add no-affinity flagtools/ tools/ tools/ +1 more | +12 | 3 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.
Cover letter [PATCH v4 00/10] perf stat fixes and improvements
A collection of fixes aiming to stabilize and make more reasonable measurements/metrics such as memory bandwidth.
Tool events are changed from getting a PMU cpu map of all online CPUs to either CPU 0 or all online CPUs. This avoids iterating over useless CPUs for events in particular duration_time. Fix a bug where duration_time didn't correctly use the previous raw counts and would skip values in interval mode.
Change how json metrics handle tool events. Use the counter value rather than using shared state with perf stat. A later patch changes it so that tool events are read last, so that if reading say memory bandwidth counters you don't divide by an earlier read time and exceed the theoretical maximum memory bandwidth.
Do some clean up around the shared state in stat-shadow that's no longer used.
Change how affinities work with evlist__for_each_cpu. Move the affinity code into the iterator to simplify setting it up. Detect when affinities will and won't be profitable, for example a tool event and a regular perf event (or read group) may face less delay from a single IPI for the event read than from a call to sched_setaffinity. Add a
--no-affinity flag to perf stat to allow affinities to be disabled.
v4: Rebase. Add patch to reduce scope of walltime_nsec_stats now that
the legacy metric code is no more. Minor tweak to the ru_stats clean up.
v3: Add affinity clean ups and read tool events last.
https://lore.kernel.org/lkml/[email protected]/
v2: Fixed an aggregation index issue:
https://lore.kernel.org/lkml/[email protected]/
v1:
https://lore.kernel.org/lkml/[email protected]/
Ian Rogers (10):
libperf cpumap: Reduce allocations and sorting in intersect perf pmu: perf_cpu_map__new_int to avoid parsing a string perf tool_pmu: Use old_count when computing count values for time
events
perf stat-shadow: Read tool events directly
perf stat: Reduce scope of ru_stats
perf stat: Reduce scope of walltime_nsecs_stats
perf tool_pmu: More accurately set the cpus for tool events perf evlist: Reduce affinity use and move into iterator, fix no
affinity
perf stat: Read tool events last
perf stat: Add no-affinity flag
tools/lib/perf/cpumap.c | 29 ++-- tools/perf/Documentation/perf-stat.txt | 4 + tools/perf/builtin-stat.c | 210 +++++++++++++++---------- tools/perf/tests/parse-metric.c | 2 - tools/perf/tests/pmu-events.c | 2 - tools/perf/util/config.c | 3 +- tools/perf/util/drm_pmu.c | 2 +- tools/perf/util/evlist.c | 156 +++++++++++------- tools/perf/util/evlist.h | 27 +++- tools/perf/util/hwmon_pmu.c | 2 +- tools/perf/util/parse-events.c | 9 +- tools/perf/util/pmu.c | 12 ++ tools/perf/util/pmu.h | 1 + tools/perf/util/stat-shadow.c | 152 ++++++++---------- tools/perf/util/stat.h | 23 --- tools/perf/util/tool_pmu.c | 78 ++++++--- tools/perf/util/tool_pmu.h | 1 + 17 files changed, 407 insertions(+), 306 deletions(-)
Signature · 1 line
2.51.2.1041.gc1ab5b90ca-goog