media: camss: Add support for C-PHY configuration on Qualcomm platforms
Get series with b4
b4 am [email protected] change-id 20251109-qcom-cphy-bb8cbda1c644Versions newest first
- v9 Latest posting 2/29 patches 11 repliesIn review
- v1 posting 2/26 patches 7 repliesSuperseded
- v9 posting 1/29 patches 0 repliesSuperseded
Earlier versions · 8
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v8 | 9 patches | 1 reply | Superseded | |
| v7 | 8 patches | 10 replies | Superseded | |
| v6 | 8 patches | 16 replies | Superseded | |
| v5 | 9 patches | 10 replies | Superseded | |
| v4 | 9 patches | 23 replies | Superseded | |
| v3 | 8 patches | 16 replies | Superseded | |
| v2 | 8 patches | 14 replies | Superseded | |
| v1 RFC posting 1/2 | 8 patches | 15 replies | Superseded |
Changes in v9 from the cover letter
- Dropped Cc and Fixes tag for "csiphy-3ph: Fix lane mask calculation" and reordered the commit.
(Vladimir)
- Link to v8: https://lore.kernel.org/r/[email protected]
Patches in v9 posting 2/2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | media: qcom: camss: csiphy-3ph: Fix lane mask calculationdrivers/ | +1 | 1 reply | |
| 2/9 | media: qcom: camss: csiphy: Introduce PHY configurationdrivers/ drivers/ | +8 | 0 replies | |
| 3/9 | media: qcom: camss: csiphy-3ph: Use odd bits for configuring C-PHY lanesdrivers/ | +16 | 1 reply | |
| 4/9 | media: qcom: camss: Prepare CSID for C-PHY supportdrivers/ drivers/ drivers/ | +12 | 0 replies | |
| 5/9 | media: qcom: camss: Initialize lanes after lane configuration is availabledrivers/ | +93 | 0 replies | |
| 6/9 | media: qcom: camss: csiphy-3ph: Add Gen2 v1.1 MIPI CSI-2 C-PHY initdrivers/ | +76 | 4 replies | |
| 7/9 | media: qcom: camss: csiphy-3ph: Update Gen2 v1.1 MIPI CSI-2 C-PHY initdrivers/ | +9 | 3 replies | |
| 8/9 | media: qcom: camss: Account for C-PHY when calculating link frequencydrivers/ drivers/ drivers/ +1 more | +22 | 2 replies | |
| 9/9 | media: qcom: camss: Enable C-PHY where availabledrivers/ | +5 | 0 replies |
Reviews trailers per patch
8 of 9 patches have a Reviewed-by or Acked-by.
| Patch | Vladimir Zapolskiy | Cory Keitz | Bryan O'Donoghue | Frank Li |
|---|---|---|---|---|
| 1/9 | R-b | R-b | ||
| 2/9 | A-b | R-b | R-b | |
| 3/9 | A-b | R-b | R-b | |
| 4/9 | A-b | R-b | R-b | |
| 5/9 | A-b | R-b | R-b | |
| 6/9 | A-b | |||
| 7/9 | A-b | |||
| 8/9 | ||||
| 9/9 | A-b | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH RESEND v9 0/9] media: camss: Add support for C-PHY configuration on Qualcomm platforms
Note: WIP tag added, as not everything from the previous review round has been addressed.
This patch series extends the Qualcomm CAMSS (Camera Subsystem), including CSID and CSIPHY components, to support C-PHY mode configuration.
Modern smartphone cameras increasingly rely on MIPI C-PHY rather than D-PHY, thanks to its higher data throughput and signal efficiency. As a result, many OEMs adopt C-PHY interfaces for main (rear) cameras on Qualcomm-based devices.
Until now, mainline Linux lacked C-PHY configuration support for Qualcomm chipsets, preventing bring-up of primary camera sensors on several Snapdragon platforms. This series closes that gap.
- Introduces C-PHY configuration support for the CAMSS driver stack, covering both CSID and CSIPHY blocks.
- Successfully enables C-PHY operation on the Snapdragon 845 platform.
- Tested on OnePlus 6 and 6T phones running mainline Linux, using the Sony IMX519 main camera sensor.
- The new configuration allows other chipsets versionsto enable C-PHY by simply adding corresponding sensor driver support and csiphy initialization data, following the example set for sdm845.
With this patch series, mainline Linux gains working C-PHY support for Snapdragon 845, paving the way for improved main camera functionality across many Qualcomm-based devices. The groundwork also simplifies future enablement efforts for additional SoCs and sensors.
Until merged, the series will be also available at:
https://codeberg.org/sdm845/linux/commits/branch/b4/qcom-cphy
---
Changes in v9:
- Dropped Cc and Fixes tag for "csiphy-3ph: Fix lane mask calculation" and reordered the commit.
(Vladimir)
- Link to v8: https://lore.kernel.org/r/[email protected]
Changes in v8:
- Refactor the for cycle in csiphy_is_gen2 same way as csiphy_get_lane_mask(). (Frank)
- Dropped T-b/R-b/A-b from
"media: qcom: camss: Account for C-PHY when calculating link frequency" as I did refactored the commit to not rely on csiphy_id. (Wenmeng)
- csiphy_get_lane_mask calculation fix. (Wenmeng)
- csiphy_lanes_enable now uses csiphy_get_lane_mask. (Wenmeng)
- Link to v7: https://lore.kernel.org/r/[email protected]
Changes in v7:
- Move logic out of switch. (Frank)
- Change csid cphy knob to phy_sel using enum. (Bryan, Frank)
- Link to v6: https://lore.kernel.org/r/[email protected]
Changes in v6:
- lanes_enable now uses WARN_ONCE instead of return values. (Sakari)
- Dropped Kodiak patch until it gets better documented.
- Document the 3ph C-PHY sdm845 registers a bit.
- Link to v5: https://lore.kernel.org/r/[email protected]
Changes in v5:
- Split first patch enabling C-PHY part into last patch. (Bryan)
- Fix the camss_get_link_freq crash. (Cory)
- Dropped patch whitelisting C-PHY, instead use nullptr check. (Bryan)
- Dropped A-b/R-b from
"media: qcom: camss: Initialize lanes after lane configuration is available" and changed Petr to Co-developed by and owned the patch.
- Link to v4: https://lore.kernel.org/r/[email protected]
Changes in v4:
- Documented cphy parametr to camss_get_link_freq.
- Use BIT() macro for lane_mask. (Bryan)
- Correct lane_mask calculation. (Kieran + me)
- Removed comment for the D/C-PHY sequences init. (Bryan)
- Pass &csid->phy for calculate freq. (Bryan)
- Added missing cphy description to camss_get_link_freq. (kernel test robot)
- Gen2 v1.1 MIPI CSI-2 CPHY init hex to lowercase.
- Added back missed commit with improved electrical for sdm845 3ph.
- NOT addressed yet:
- Proliferating special cases in switch statements on a per-SoC basis is verboten.
- is it possible to set clock_lane to say 0xff in DT ?
- Link to v3: https://lore.kernel.org/r/[email protected]
Changes in v3:
- Make lanes_enable return sucess or error, since I couldn't move the configuration to the _init.
- Dropped R-b tags on
"media: qcom: camss: Initialize lanes after lane configuration is available" as I changed formatting.
- Link to v2: https://lore.kernel.org/r/[email protected]
Changes in v2:
- This is still WIP patch series, thus I wanted to publish already changed parts to get feedback regarding to the direction of patchset.
- When switch to using odd bits, zeroed val which was left unitialized in v1.
- Accidentally missed archs added back in the commit moving lane regs to new location.
- Remove commit with reverting check for only D-PHY is supported and adjusted the check to also account for C-PHY.
- Documented link frequency calculation with defines. (Casey)
- Changed the cphy boolean to phy_cfg enum in the camss/camss-csiphy. (Brian)
- Added patch for csiphy-3ph enablement for sm7280 from Luca as I'm meanwhile trying to bring up the C-PHY sensor on FairPhone 5.
- Merged these two commits together
csiphy-3ph: Enable sdm845 C-PHY sequence
csiphy-3ph: Add Gen2 v1.1 MIPI CSI-2 CPHY init
merged R-b.
- Link to v1: https://lore.kernel.org/r/[email protected]
---
David Heidelberg (9):
media: qcom: camss: csiphy-3ph: Fix lane mask calculation
media: qcom: camss: csiphy: Introduce PHY configuration
media: qcom: camss: csiphy-3ph: Use odd bits for configuring C-PHY lanes
media: qcom: camss: Prepare CSID for C-PHY support
media: qcom: camss: Initialize lanes after lane configuration is available
media: qcom: camss: csiphy-3ph: Add Gen2 v1.1 MIPI CSI-2 C-PHY init
media: qcom: camss: csiphy-3ph: Update Gen2 v1.1 MIPI CSI-2 C-PHY init
media: qcom: camss: Account for C-PHY when calculating link frequency
media: qcom: camss: Enable C-PHY where available
.../media/platform/qcom/camss/camss-csid-gen2.c | 1 + drivers/media/platform/qcom/camss/camss-csid.c | 11 +- drivers/media/platform/qcom/camss/camss-csid.h | 6 + .../platform/qcom/camss/camss-csiphy-3ph-1-0.c | 229 ++++++++++++++++----- drivers/media/platform/qcom/camss/camss-csiphy.c | 6 +- drivers/media/platform/qcom/camss/camss-csiphy.h | 2 + drivers/media/platform/qcom/camss/camss.c | 33 ++- drivers/media/platform/qcom/camss/camss.h | 2 +- 8 files changed, 229 insertions(+), 61 deletions(-)
---
base-commit: abe651837cb394f76d738a7a747322fca3bf17ba
change-id: 20251109-qcom-cphy-bb8cbda1c644
Best regards,
Signature · 1 line
David Heidelberg <[email protected]>