Skip to content

PCI: Remove unsupported or incomplete PCIe Capabilities

Qiang Yu linux-arm-msm linux-pci lkml 1 version Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected] change-id 20251109-remove_cap-4b7c0600f766

Versions newest first

  1. v1 Latest5 patches 22 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/5PCI: Add preceding capability position support and update driversdrivers/pci/controller/cadence/pcie-cadence.c drivers/pci/controller/dwc/pcie-designware-ep.c drivers/pci/controller/dwc/pcie-designware.c +2 more+29 -140 replies
2/5PCI: dwc: Add new APIs to remove standard and extended Capabilitydrivers/pci/controller/dwc/pcie-designware.c drivers/pci/controller/dwc/pcie-designware.h+55 -06 replies
3/5PCI: dwc: Remove MSI/MSIX capability if iMSI-RX is used as MSI controllerdrivers/pci/controller/dwc/pcie-designware-host.c+10 -015 replies
4/5PCI: qcom: Remove MSI-X Capability for Root Portsdrivers/pci/controller/dwc/pcie-qcom.c+2 -00 replies
5/5PCI: qcom: Remove DPC Extended Capabilitydrivers/pci/controller/dwc/pcie-qcom.c+1 -00 replies

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchBrian Norris
1/5
2/5
3/5T-b R-b
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] PCI: Remove unsupported or incomplete PCIe Capabilities

This patch series addresses issues where certain PCIe Standard or Extended Capabilities are advertised by the controller, but not fully or at all implemented in hardware. Exposing such capabilities to the PCI framework can lead to unexpected or undefined behavior.

The series consists of two main parts:

1. Infrastructure patches (1-2): Add generic capability removal support
2. Platform-specific patches(3-5): Apply fixes for DWC based PCIe Root Ports and Qualcomm PCIe Root Ports

Patch 1 extends the existing PCI capability finding macros to optionally return the position of the preceding capability. This information is essential for capability removal operations, as it allows updating the "next" pointer of the predecessor to skip over the capability being removed.

Patch 2 introduces two new APIs in the DesignWare PCIe controller driver:
- dw_pcie_remove_capability() - Remove standard PCI capabilities
- dw_pcie_remove_ext_capability() - Remove extended PCI capabilities

Patch 3 implements automatic MSI/MSI-X capability removal for Root Ports when using the iMSI-RX module as MSI controller. This addresses the issue where iMSI-RX cannot generate MSI interrupts for Root Ports, forcing a fallback to INTx interrupts for Root Ports.

Patch 4 removes MSI-X capability from Qualcomm Root Ports unconditionally. On platforms like Glymur, MSI-X capability is exposed but lacks the required Table and PBA structures, leading to SMMU faults when the capability is used.

Patch 5 removes DPC (Downstream Port Containment) Extended Capability from Qualcomm platforms. While the capability registers are present, DPC is not fully supported, and exposing it can cause undefined behavior.

---
Qiang Yu (5):
PCI: Add preceding capability position support and update drivers
PCI: dwc: Add new APIs to remove standard and extended Capability
PCI: dwc: Remove MSI/MSIX capability if iMSI-RX is used as MSI controller
PCI: qcom: Remove MSI-X Capability for Root Ports
PCI: qcom: Remove DPC Extended Capability

 drivers/pci/controller/cadence/pcie-cadence.c     |  4 +-
 drivers/pci/controller/dwc/pcie-designware-ep.c   |  2 +-
 drivers/pci/controller/dwc/pcie-designware-host.c | 10 ++++
 drivers/pci/controller/dwc/pcie-designware.c      | 59 +++++++++++++++++++++--
 drivers/pci/controller/dwc/pcie-designware.h      |  2 +
 drivers/pci/controller/dwc/pcie-qcom.c            |  3 ++
 drivers/pci/pci.c                                 |  8 +--
 drivers/pci/pci.h                                 | 23 +++++++--
 8 files changed, 97 insertions(+), 14 deletions(-)

---
base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
change-id: 20251109-remove_cap-4b7c0600f766

Best regards,

Signature · 1 line
Qiang Yu <[email protected]>