Skip to content

memcg: cleanup the memcg stats interfaces

Shakeel Butt cgroups linux-mm linux-rt-devel lkml 1 version Applied

Status from this message: [merged mm-stable] memcg-remove-__lruvec_stat_mod_folio.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 44 repliesApplied 4/4

Patches in v1 All 4 applied

#Subject and filesSizeRepliesApplied
1/4memcg: use mod_node_page_state to update statsinclude/linux/memcontrol.h include/linux/vmstat.h mm/memcontrol.c+6 -620 repliesApplied
2/4memcg: remove __mod_lruvec_kmem_stateinclude/linux/memcontrol.h mm/memcontrol.c mm/workingset.c+7 -253 repliesApplied
3/4memcg: remove __mod_lruvec_stateinclude/linux/mm_inline.h include/linux/vmstat.h mm/memcontrol.c +2 more+18 -342 repliesApplied
4/4memcg: remove __lruvec_stat_mod_folioinclude/linux/vmstat.h mm/filemap.c mm/huge_memory.c +5 more+25 -532 repliesApplied

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchHarry YooQi ZhengVlastimil BabkaRoman Gushchin
SeriesA-b
1/4R-b A-b
2/4R-b R-b A-b
3/4R-b A-b
4/4R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 0/4] memcg: cleanup the memcg stats interfaces

The memcg stats are safe against irq (and nmi) context and thus does not require disabling irqs. However for some stats which are also maintained at node level, it is using irq unsafe interface and thus requiring the users to still disables irqs or use interfaces which explicitly disables irqs. Let's move memcg code to use irq safe node level stats function which is already optimized for architectures with HAVE_CMPXCHG_LOCAL (all major ones), so there will not be any performance penalty for its usage.

Shakeel Butt (4):
memcg: use mod_node_page_state to update stats
memcg: remove __mod_lruvec_kmem_state
memcg: remove __mod_lruvec_state
memcg: remove __lruvec_stat_mod_folio

 include/linux/memcontrol.h | 28 ++++------------------
 include/linux/mm_inline.h  |  2 +-
 include/linux/vmstat.h     | 48 ++------------------------------------
 mm/filemap.c               | 20 ++++++++--------
 mm/huge_memory.c           |  4 ++--
 mm/khugepaged.c            |  8 +++----
 mm/memcontrol.c            | 20 ++++++++--------
 mm/migrate.c               | 20 ++++++++--------
 mm/page-writeback.c        |  2 +-
 mm/rmap.c                  |  4 ++--
 mm/shmem.c                 |  6 ++---
 mm/vmscan.c                |  4 ++--
 mm/workingset.c            |  2 +-
 13 files changed, 53 insertions(+), 115 deletions(-)
Signature · 1 line
2.47.3