Skip to content

mm/damon/tests: add more tests for online parameters commit

SeongJae Park damon linux-kselftest linux-mm lkml 1 version Applied

Status from this message: [merged mm-stable] mm-damon-tests-core-kunit-add-damon_commit_target_regions-test.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 0 repliesApplied 11/11

Patches in v1 All 11 applied

#Subject and filesSizeRepliesApplied
1/11mm/damon/tests/core-kunit: remove dynamic allocs on damos_test_commit_filter()mm/damon/tests/core-kunit.h+13 -160 repliesApplied
2/11mm/damon/tests/core-kunit: split out damos_test_commit_filter() core logicmm/damon/tests/core-kunit.h+10 -40 repliesApplied
3/11mm/damon/tests/core-kunit: extend damos_test_commit_filter_for() for union fieldsmm/damon/tests/core-kunit.h+20 -00 repliesApplied
4/11mm/damon/tests/core-kunit: add test cases to damos_test_commit_filter()mm/damon/tests/core-kunit.h+47 -60 repliesApplied
5/11mm/damon/tests/core-kunit: add damos_commit_quota_goal() testmm/damon/tests/core-kunit.h+84 -00 repliesApplied
6/11mm/damon/tests/core-kunit: add damos_commit_quota_goals() testmm/damon/tests/core-kunit.h+81 -00 repliesApplied
7/11mm/damon/tests/core-kunit: add damos_commit_quota() testmm/damon/tests/core-kunit.h+33 -00 repliesApplied
8/11mm/damon/core: pass migrate_dests to damos_commit_dests()mm/damon/core.c+17 -210 repliesApplied
9/11mm/damon/tests/core-kunit: add damos_commit_dests() testmm/damon/tests/core-kunit.h+97 -00 repliesApplied
10/11mm/damon/tests/core-kunit: add damos_commit() testmm/damon/tests/core-kunit.h+92 -00 repliesApplied
11/11mm/damon/tests/core-kunit: add damon_commit_target_regions() testmm/damon/tests/core-kunit.h+65 -00 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/11] mm/damon/tests: add more tests for online parameters commit

A DAMON feature called parameters "commit" allows DAMON API callers and ABI users to update nearly every DAMON parameter while DAMON is running. This is being used for flexible DAMON use cases such as taking a snapshot of the monitoring results with minimum overhead, or adjusting access-aware system operations (DAMOS) for user-space driven auto-tuning or investigations.

Compared to the usefulness of the feature and size of the implementation, the test coverage is pretty small. Only the filter commit part has a single test case, namely damos_test_commit_filter(). Actually, we found and fixed a few bugs of the feature in the past. The single existing test was also added to avoid reintroduction of a found bug.

Add more unit tests for the feature.

First four patches (1-4) refactor and extend the existing test for DAMOS filter commit for multiple test cases.

Next three patches (5-7) add tests for DAMOS quota commit.

Next two patches (8 and 9) refactor damos_commit_dests() for ease of code reading and test writing, and implement a new unit test of the function that is being refactored in a test-friendly way.

Final two patches (10 and 11) further add new unit tests for damos_commit() and damon_commit_target_regions().

SeongJae Park (11):
mm/damon/tests/core-kunit: remove dynamic allocs on
damos_test_commit_filter()
mm/damon/tests/core-kunit: split out damos_test_commit_filter() core
logic
mm/damon/tests/core-kunit: extend damos_test_commit_filter_for() for
union fields
mm/damon/tests/core-kunit: add test cases to
damos_test_commit_filter()
mm/damon/tests/core-kunit: add damos_commit_quota_goal() test mm/damon/tests/core-kunit: add damos_commit_quota_goals() test mm/damon/tests/core-kunit: add damos_commit_quota() test mm/damon/core: pass migrate_dests to damos_commit_dests() mm/damon/tests/core-kunit: add damos_commit_dests() test mm/damon/tests/core-kunit: add damos_commit() test mm/damon/tests/core-kunit: add damon_commit_target_regions() test

 mm/damon/core.c             |  38 ++-
 mm/damon/tests/core-kunit.h | 544 +++++++++++++++++++++++++++++++++++-
 2 files changed, 547 insertions(+), 35 deletions(-)

base-commit: 620a4c1c5116eb811807ea7e63d61846015f69c8

Signature · 1 line
2.47.3