drm/sun4i: update DE33 support
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest5 patches 0 repliesNew
- v38 patches 9 repliesApplied
- v28 patches 12 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 7 patches | 21 replies | Superseded |
Changes in v4 from the cover letter
- dropped already applied patches 1-4
- new patch 1: reject fractional source coordinates on channels without scaler (suggested by Chen-Yu)
- patch 3: mention in commit message that driver is hooked up only in last patch, update copyright year, drop unused of_graph.h include, use dev_err_probe() and MAX_DISP bound, collected Chen-Yu's R-b
- patch 4: collected Chen-Yu's and Rob's R-b
- patch 5: fix include order, use device_is_bound() under device lock, guard put_device() in error path, drop stale @map kernel-doc, rename planes platform device variable, mention missing scaling in commit message, collected Chen-Yu's R-b
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | drm/sun4i: Reject fractional source coordinates without scalerdrivers/ drivers/ | +40 | 0 replies | |
| 2/5 | dt-bindings: display: allwinner: Add DE33 planesDocumentation/ | +46 | 0 replies | |
| 3/5 | drm/sun4i: Add DE33 shared plane driverdrivers/ drivers/ drivers/ | +254 | 0 replies | |
| 4/5 | dt-bindings: display: allwinner: Split H616 DE33 layer reg spaceDocumentation/ | +10 | 0 replies | |
| 5/5 | drm/sun4i: Switch DE33 to split plane bindingsdrivers/ drivers/ | +136 | 0 replies |
Reviews trailers per patch
4 of 5 patches have a Reviewed-by or Acked-by.
| Patch | Krzysztof Kozlowski | Chen-Yu Tsai | Rob Herring (Arm) |
|---|---|---|---|
| 1/5 | |||
| 2/5 | R-b | ||
| 3/5 | R-b | ||
| 4/5 | R-b | R-b | |
| 5/5 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v4 0/5] drm/sun4i: update DE33 support
This is second series out of three which aims at properly introducing support for H616 Display Engine 3.3. Previous series [1] reorganized driver so proper DE33 support can be easily implemented.
H616 DE33 support was actually introduced a while back, but it was done without fully understanding hardware design. Issue with existing binding is that it considers planes as resource which is hardwired to each mixer as it was done on older Display Engine generations (DE3 and lower). That is not the case anymore. This series introduces new driver for planes management, which allows doing proper plane assignments.
Note that this series intentionally breaks existing H616 DE33 mixer binding, which was released in v6.17. Old binding can't describe shared planes, so second mixer can't be supported with it, and it never had any user - there is no H616 Display Engine node in upstream DT, rest of H616 display pipeline is not upstream yet and no other known DT consumer implements it. Reasons are documented in patch 4 and driver prints error asking to update DT if old binding is detected (patch 5).
Patches 1-4 from v3 were already applied (clk patches to sunxi clk-for-7.5, CSC and VI format patches to drm-misc-next). Plane driver depends at runtime on commit 63a29fbb4ecd ("clk: sunxi-ng: de2: Export register regmap for DE33") from sunxi tree, otherwise it defers probe.
Remaining patches, which introduce all the missing bits to fully support display pipeline on H616 SoC, will be sent once this series is merged. WIP patches, which can be used for testing purposes, can be found at [2].
Please take a look.
Best regards,
Jernej
Changes since v3:
- dropped already applied patches 1-4
- new patch 1: reject fractional source coordinates on channels without scaler (suggested by Chen-Yu)
- patch 3: mention in commit message that driver is hooked up only in last patch, update copyright year, drop unused of_graph.h include, use dev_err_probe() and MAX_DISP bound, collected Chen-Yu's R-b
- patch 4: collected Chen-Yu's and Rob's R-b
- patch 5: fix include order, use device_is_bound() under device lock, guard put_device() in error path, drop stale @map kernel-doc, rename planes platform device variable, mention missing scaling in commit message, collected Chen-Yu's R-b
Link to v3: https://lore.kernel.org/linux-sunxi/[email protected]/
Link to v2: https://lore.kernel.org/linux-sunxi/[email protected]/
Link to v1: https://lore.kernel.org/linux-sunxi/[email protected]/
[1] https://lore.kernel.org/linux-sunxi/[email protected]/T/#t
[2] https://github.com/jernejsk/linux-1/commits/sun4i-drm-refactor/
Jernej Skrabec (5):
drm/sun4i: Reject fractional source coordinates without scaler
dt-bindings: display: allwinner: Add DE33 planes drm/sun4i: Add DE33 shared plane driver
dt-bindings: display: allwinner: Split H616 DE33 layer reg space drm/sun4i: Switch DE33 to split plane bindings
.../allwinner,sun50i-h616-de33-planes.yaml | 46 ++++ .../allwinner,sun8i-a83t-de2-mixer.yaml | 16 +- drivers/gpu/drm/sun4i/Makefile | 3 +- drivers/gpu/drm/sun4i/sun50i_planes.c | 209 ++++++++++++++++++ drivers/gpu/drm/sun4i/sun50i_planes.h | 43 ++++ drivers/gpu/drm/sun4i/sun8i_mixer.c | 191 +++++++++++----- drivers/gpu/drm/sun4i/sun8i_mixer.h | 11 +- drivers/gpu/drm/sun4i/sun8i_ui_layer.c | 24 +- drivers/gpu/drm/sun4i/sun8i_vi_layer.c | 24 +- 9 files changed, 486 insertions(+), 81 deletions(-) create mode 100644 Documentation/devicetree/bindings/display/allwinner,sun50i-h616-de33-planes.yaml create mode 100644 drivers/gpu/drm/sun4i/sun50i_planes.c create mode 100644 drivers/gpu/drm/sun4i/sun50i_planes.h
base-commit: 8e2afcd2b57990465f132367fd8fdc2e55c1adad
Signature · 1 line
2.43.0