Skip to content

test: fix format-truncation warnings

Stephen Hemminger dpdk-dev 11 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v12 Latest8 patches 1 replyIn review
  2. v116 patches 0 repliesSuperseded
  3. v109 patches 8 repliesSuperseded
Earlier versions · 8
VersionPostedPatchesRepliesStatus
v99 patches0 repliesSuperseded
v810 patches0 repliesSuperseded
v710 patches0 repliesSuperseded
v69 patches2 repliesSuperseded
v58 patches0 repliesSuperseded
v48 patches5 repliesSuperseded
v36 patches3 repliesSuperseded
v25 patches0 repliesSuperseded

Patches in v12 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8test: increase size of memzone nameapp/test/test_memzone.c+1 -10 replies
2/8test: add new function to get current file-prefix argapp/test/process.h app/test/test_eal_flags.c+71 -1060 replies
3/8test: avoid overflowing huge directory pathapp/test/test_eal_flags.c+61 -850 replies
4/8test: fix format overflow warning in ACL testapp/test/test_table_acl.c+14 -160 replies
5/8test: fix impossible format-truncation in cfgfilesapp/test/test_cfgfile.c+2 -60 replies
6/8test: fix format overflow in cryptodev testapp/test/test_cryptodev.c+18 -40 replies
7/8test: fix overflow warnings in common codeapp/test/test_mp_secondary.c app/test/test_pdump.c app/test/test_timer_secondary.c+12 -270 replies
8/8test: re-enable format-truncation warningsapp/test/meson.build+0 -10 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchBruce RichardsonMarat KhaliliAnatoly Burakov
1/8A-b
2/8A-b
3/8A-b
4/8A-b
5/8A-b A-b
6/8A-b
7/8A-b
8/8A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v12 thread

Cover letter [PATCH v12 0/8] test: fix format-truncation warnings

This patchset addresses the -Wformat-truncation warnings throughout the DPDK test suite, allowing the warning to be re-enabled.

The changes include:
- Properly sizing buffers using named constants (RTE_MEMZONE_NAMESIZE, NAME_MAX)
- Adding a common file_prefix_arg() helper to reduce code duplication
- Using standard library functions (getmntent) for mount parsing
- Checking snprintf() return values for potential truncation
- Converting problematic 2D arrays to pointer arrays

After these fixes, the final patch removes -Wno-format-truncation from the test build flags, ensuring these issues are caught in the future.

Several patches are marked for stable backport where they fix real potential bugs rather than just theoretical compiler warnings.

v12 - rebase to handle new eal_flags printf's

Stephen Hemminger (8):
test: increase size of memzone name
test: add new function to get current file-prefix arg
test: avoid overflowing huge directory path
test: fix format overflow warning in ACL test
test: fix impossible format-truncation in cfgfiles
test: fix format overflow in cryptodev test
test: fix overflow warnings in common code
test: re-enable format-truncation warnings

 app/test/meson.build            |   1 -
 app/test/process.h              |  44 ++++--
 app/test/test_cfgfile.c         |   8 +-
 app/test/test_cryptodev.c       |  22 ++-
 app/test/test_eal_flags.c       | 269 +++++++++++---------------------
 app/test/test_memzone.c         |   2 +-
 app/test/test_mp_secondary.c    |  14 +-
 app/test/test_pdump.c           |  13 +-
 app/test/test_table_acl.c       |  30 ++--
 app/test/test_timer_secondary.c |  12 +-
 10 files changed, 174 insertions(+), 241 deletions(-)
Signature · 1 line
2.51.0