Skip to content

mtd: maps: vmu-flash: Fix build and runtime errors

Florian Fuchs linux-mtd linux-sh lkml 3 versions – Applied

Status from this message: Applied to mtd/next, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 2 repliesApplied
  2. v23 patches 2 repliesSuperseded
  3. v13 patches 6 repliesSuperseded

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/3maple: fix build error due to missing include of linux/device.hinclude/linux/maple.h+1 -20 replies
2/3mtd: maps: vmu-flash: fix fault in unaligned fixupdrivers/mtd/maps/vmu-flash.c+3 -30 replies
3/3mtd: maps: vmu-flash: fix NULL pointer dereference in initializationdrivers/mtd/maps/vmu-flash.c+1 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/3] mtd: maps: vmu-flash: Fix build and runtime errors

Hi all,

This small series fixes build and runtime errors in the vmu-flash driver (enabled by CONFIG_MTD_VMU) and the related maple.h. These changes were verified on real Dreamcast hardware with a physical VMU. The VMU can now be successfully probed, read and written with MTD tools like mtdinfo and mtd_debug. Previously, the driver failed to build or crashed during probing.

bash-5.3# mtdinfo /dev/mtd0
mtd0
Name: vmu2.1.0
Type: mlc-nand
Eraseblock size: 512 bytes
Amount of eraseblocks: 256 (131072 bytes, 128.0 KiB)
Minimum input/output unit size: 512 bytes
Sub-page size: 512 bytes
Character device major/minor: 90:0
Bad blocks are allowed: true
Device is writable: true

Thanks,
Florian
---
v2->v3: Add Fixes tag to respective patches, fix subject to previous
commits
v1->v2: Rebased patches and fixed the hotplug issues in other sh
patches.

v2: https://lore.kernel.org/lkml/[email protected]/
v1: https://lore.kernel.org/lkml/[email protected]/

The original v1 was postponed until the hotplug issue and other runtime panics were fixed by the following patch:
"[PATCH v3] sh: maple: fix empty port handling":
https://lore.kernel.org/linux-sh/[email protected]/

Using VMUs while some ports are empty requires the above patch.

Florian Fuchs (3):
maple: fix build error due to missing include of linux/device.h
mtd: maps: vmu-flash: fix fault in unaligned fixup
mtd: maps: vmu-flash: fix NULL pointer dereference in initialization

 drivers/mtd/maps/vmu-flash.c | 7 ++++---
 include/linux/maple.h        | 3 +--
 2 files changed, 5 insertions(+), 5 deletions(-)

base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731

Signature · 1 line
2.43.0