Skip to content

LoongArch: Add 128-bit atomic cmpxchg support

George Guo lkml loongarch 11 versions – In review

Get series with b4
b4 am [email protected] change-id 20251120-2-d03862b2cf6d

Versions newest first

  1. v10 Latest3 patches 4 repliesIn review inferred link
  2. v94 patches 3 repliesSuperseded inferred link
  3. v83 patches 4 repliesSuperseded inferred link
Earlier versions · 8
VersionPostedPatchesRepliesStatus
v74 patches5 repliesSuperseded inferred link
v6 posting 2/24 patches0 repliesSuperseded
v6 posting 1/24 patches2 repliesSuperseded
v54 patches2 repliesSuperseded
v44 patches2 repliesSuperseded
v32 patches6 repliesSuperseded
v22 patches5 repliesSuperseded
v12 patches5 repliesSuperseded

Changes in v10 from the cover letter

- move "scq" to be placed after "lam"
- squash last patch
- move patch: "LoongArch: Replace seq_printf with seq_puts for simple strings" to the end
- Link to v9: https://lore.kernel.org/all/[email protected]/

Patches in v10 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3LoongArch: Add SCQ support detectionarch/loongarch/include/asm/cpu-features.h arch/loongarch/include/asm/cpu.h arch/loongarch/include/uapi/asm/hwcap.h +2 more+9 -00 replies
2/3LoongArch: Add 128-bit atomic cmpxchg supportarch/loongarch/Kconfig arch/loongarch/include/asm/cmpxchg.h+50 -02 replies
3/3LoongArch: Replace seq_printf with seq_puts for simple stringsarch/loongarch/kernel/proc.c+40 -242 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchHengqi Chen
1/3R-b T-b
2/3A-b T-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v10 thread

Cover letter [PATCH v10 loongarch-next 0/3] LoongArch: Add 128-bit atomic cmpxchg support

This patch series adds 128-bit atomic compare-and-exchange support for LoongArch architecture, which fixes BPF scheduler test failures caused by missing 128-bit atomics support.

---
Changes in v10:
- move "scq" to be placed after "lam"
- squash last patch
- move patch: "LoongArch: Replace seq_printf with seq_puts for simple strings" to the end
- Link to v9: https://lore.kernel.org/all/[email protected]/

---
Changes in v9:
- Add patch: "LoongArch: Replace seq_printf with seq_puts for simple strings"
- #define system_has_cmpxchg128() (cpu_has_scq)
- Delete __cmpxchg128_locked
- #define HWCAP_LOONGARCH_CPU_SCQ (1 << 15) in hwcap.h
- Link to v8: https://lore.kernel.org/all/[email protected]/

---
Changes in v8:
- Merge patch 2 and patch 3 into one patch
- Put HAVE_CMPXCHG_DOUBLE in order
- Link to v7: https://lore.kernel.org/all/[email protected]/

---
Changes in v7:
- Create patches based on loongarch-next branch(previously used master)
- Link to v6: https://lore.kernel.org/r/[email protected]

Changes in v6:
- Put SCQ information in hwcap
- Link to v5: https://lore.kernel.org/r/[email protected]

Changes in v5:
- Reordered the patches
- Link to v4: https://lore.kernel.org/r/[email protected]

Changes in v4:
- Add SCQ support detection
- Add spinlock to emulate 128-bit cmpxchg
- Link to v3: https://lore.kernel.org/r/[email protected]

Changes in v3:
- dbar 0 -> __WEAK_LLSC_MB
- =ZB" (__ptr[0]) -> "r" (__ptr)
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- Use a normal ld.d for the high word instead of ll.d to avoid race condition
- Insert a dbar between ll.d and ld.d to prevent reordering
- Simply __cmpxchg128_asm("ll.d", "sc.q", ptr, o, n) to __cmpxchg128_asm(ptr, o, n)
- Fix address operand constraints after testing different approaches:
* ld.d with "m"
* ll.d with "ZC",
* sc.q with "ZB"(alternative constraints caused issues:
- "r" caused system hang
- "ZC" caused compiler error:
{standard input}: Assembler messages:
{standard input}:10037: Fatal error: Immediate overflow.
format: u0:0 )
- Link to v1: https://lore.kernel.org/r/[email protected]

George Guo (3):
LoongArch: Add SCQ support detection
LoongArch: Add 128-bit atomic cmpxchg support
LoongArch: Replace seq_printf with seq_puts for simple strings

 arch/loongarch/Kconfig                    |  2 +
 arch/loongarch/include/asm/cmpxchg.h      | 48 +++++++++++++++++
 arch/loongarch/include/asm/cpu-features.h |  1 +
 arch/loongarch/include/asm/cpu.h          |  2 +
 arch/loongarch/include/uapi/asm/hwcap.h   |  1 +
 arch/loongarch/kernel/cpu-probe.c         |  4 ++
 arch/loongarch/kernel/proc.c              | 63 ++++++++++++++---------
 7 files changed, 98 insertions(+), 23 deletions(-)
Signature · 1 line
2.49.0