debugfs: Remove broken no-mount mode
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 4 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | debugfs: Remove redundant access mode checksfs/ | +0 | 0 replies | |
| 2/2 | debugfs: Remove broken no-mount modeDocumentation/ fs/ fs/ +1 more | +13 | 4 replies |
Reviews trailers per patch
None of the 2 patches has a Reviewed-by or Acked-by.
| Patch | Chen-Yu Tsai |
|---|---|
| 1/2 | |
| 2/2 | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/2] debugfs: Remove broken no-mount mode
Hi all,
This patch removes the debugfs no-mount mode because it hasn't worked as intended for several years. When I noticed that it wasn't working, I first started coding a fix, which is straightforward. But after looking into the history, it seems pretty clear that this mode isn't being used, so I think it makes more sense to remove it.
The code could be made a tiny bit simpler and more consistent if we change the off mode error code from -EPERM to -ENOENT. That would make the off case and the uninitialized case always the same. The documentation for the off mode specifically says that the error code is -EPERM however, so I stuck with that for now.
Thanks!
Aaron Thompson (2):
debugfs: Remove redundant access mode checks
debugfs: Remove broken no-mount mode
.../admin-guide/kernel-parameters.txt | 6 +--- fs/debugfs/inode.c | 36 ++++++------------- fs/debugfs/internal.h | 13 ------- lib/Kconfig.debug | 9 +---- 4 files changed, 13 insertions(+), 51 deletions(-)
base-commit: 6a23ae0a96a600d1d12557add110e0bb6e32730c
Signature · 1 line
2.47.3