ASoC: Intel: catpt: Round of fixes and PM changes
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest6 patches 3 repliesIn review
- v26 patches 6 repliesSuperseded
- v16 patches 12 repliesSuperseded
Changes in v3 from the cover letter
- reordered the patches so that all 3 fixes are at the start of the patchset and added missing 'Fixes:' tag
- small spacing adjustments in patch 2/6
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | ASoC: Intel: catpt: Fix error path in hw_params()sound/ | +3 | 0 replies | |
| 2/6 | ASoC: Intel: catpt: Fix probing order of driver componentssound/ | +9 | 0 replies | |
| 3/6 | ASoC: Intel: catpt: Fix offset checkssound/ | +4 | 0 replies | |
| 4/6 | ASoC: Intel: catpt: Switch to resource_xxx() APIsound/ | +10 | 0 replies | |
| 5/6 | ASoC: Intel: catpt: Do not ignore errors on runtime resumesound/ sound/ | +7 | 0 replies | |
| 6/6 | ASoC: Intel: catpt: Do not block the system from suspendingsound/ | +9 | 0 replies |
Reviews trailers per patch
5 of 6 patches have a Reviewed-by or Acked-by.
| Patch | Andy Shevchenko |
|---|---|
| 1/6 | R-b |
| 2/6 | A-b |
| 3/6 | R-b |
| 4/6 | R-b |
| 5/6 | |
| 6/6 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/6] ASoC: Intel: catpt: Round of fixes and PM changes
Set of changes addressing gaps in DRAM offset checks, error paths and PM.
Three fixes lead the way, all straight-forward. Followed up by a small refactor to replace manual arithmetic with resource_xxx() API. The last two relate to the power management.
The standing out PM change is removal of the catpt-driver as a system-suspend (S3) blocker. This is a suggestion from Andy as indeed, audio is not a critical component that should prevent the system from going into S3. Whatever happens, the driver can recover on a follow up resume (S3 -> S0).
All points below suggested by Andy.
Changes in v3:
- reordered the patches so that all 3 fixes are at the start of the patchset and added missing 'Fixes:' tag
- small spacing adjustments in patch 2/6
Changes in v2:
- removed the last patch from v1 "ASoC: Intel: catpt: Drop catpt_runtime_resume()"
- added new patch "ASoC: Intel: catpt: Switch to resource_xxx() API" which refactors existing code that manupulates .start, .end and size of resources to publicly available interface
- patches 1/6 and 3/6 have had their message justified to improve readability
Cezary Rojewski (6):
ASoC: Intel: catpt: Fix error path in hw_params()
ASoC: Intel: catpt: Fix probing order of driver components
ASoC: Intel: catpt: Fix offset checks
ASoC: Intel: catpt: Switch to resource_xxx() API
ASoC: Intel: catpt: Do not ignore errors on runtime resume
ASoC: Intel: catpt: Do not block the system from suspending
sound/soc/intel/catpt/device.c | 26 ++++++++++++++++++-------- sound/soc/intel/catpt/loader.c | 19 ++++++++++--------- sound/soc/intel/catpt/pcm.c | 16 +++++++++------- sound/soc/intel/catpt/sysfs.c | 2 +- 4 files changed, 38 insertions(+), 25 deletions(-)
Signature · 1 line
2.25.1