Skip to content

ASoC: Intel: catpt: Round of fixes and PM changes

Cezary Rojewski linux-sound 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 3 repliesIn review
  2. v26 patches 6 repliesSuperseded
  3. v16 patches 12 repliesSuperseded

Changes in v3 from the cover letter

- reordered the patches so that all 3 fixes are at the start of the patchset and added missing 'Fixes:' tag
- small spacing adjustments in patch 2/6

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6ASoC: Intel: catpt: Fix error path in hw_params()sound/soc/intel/catpt/pcm.c+3 -10 replies
2/6ASoC: Intel: catpt: Fix probing order of driver componentssound/soc/intel/catpt/device.c+9 -60 replies
3/6ASoC: Intel: catpt: Fix offset checkssound/soc/intel/catpt/loader.c+4 -40 replies
4/6ASoC: Intel: catpt: Switch to resource_xxx() APIsound/soc/intel/catpt/loader.c+10 -90 replies
5/6ASoC: Intel: catpt: Do not ignore errors on runtime resumesound/soc/intel/catpt/pcm.c sound/soc/intel/catpt/sysfs.c+7 -70 replies
6/6ASoC: Intel: catpt: Do not block the system from suspendingsound/soc/intel/catpt/device.c+9 -20 replies

Reviews trailers per patch

5 of 6 patches have a Reviewed-by or Acked-by.

PatchAndy Shevchenko
1/6R-b
2/6A-b
3/6R-b
4/6R-b
5/6
6/6A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/6] ASoC: Intel: catpt: Round of fixes and PM changes

Set of changes addressing gaps in DRAM offset checks, error paths and PM.

Three fixes lead the way, all straight-forward. Followed up by a small refactor to replace manual arithmetic with resource_xxx() API. The last two relate to the power management.

The standing out PM change is removal of the catpt-driver as a system-suspend (S3) blocker. This is a suggestion from Andy as indeed, audio is not a critical component that should prevent the system from going into S3. Whatever happens, the driver can recover on a follow up resume (S3 -> S0).

All points below suggested by Andy.

Changes in v3:
- reordered the patches so that all 3 fixes are at the start of the patchset and added missing 'Fixes:' tag
- small spacing adjustments in patch 2/6

Changes in v2:
- removed the last patch from v1 "ASoC: Intel: catpt: Drop catpt_runtime_resume()"
- added new patch "ASoC: Intel: catpt: Switch to resource_xxx() API" which refactors existing code that manupulates .start, .end and size of resources to publicly available interface
- patches 1/6 and 3/6 have had their message justified to improve readability

Cezary Rojewski (6):
ASoC: Intel: catpt: Fix error path in hw_params()
ASoC: Intel: catpt: Fix probing order of driver components
ASoC: Intel: catpt: Fix offset checks
ASoC: Intel: catpt: Switch to resource_xxx() API
ASoC: Intel: catpt: Do not ignore errors on runtime resume
ASoC: Intel: catpt: Do not block the system from suspending

 sound/soc/intel/catpt/device.c | 26 ++++++++++++++++++--------
 sound/soc/intel/catpt/loader.c | 19 ++++++++++---------
 sound/soc/intel/catpt/pcm.c    | 16 +++++++++-------
 sound/soc/intel/catpt/sysfs.c  |  2 +-
 4 files changed, 38 insertions(+), 25 deletions(-)
Signature · 1 line
2.25.1