Skip to content

staging: rtl8723bs: remove custom FIELD_OFFSET macro and dead code

Navaneeth K linux-staging lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5staging: rtl8723bs: remove custom FIELD_OFFSET macrodrivers/staging/rtl8723bs/include/basic_types.h+1 -20 replies
2/5staging: rtl8723bs: replace FIELD_OFFSET usage with offsetofdrivers/staging/rtl8723bs/include/drv_types.h+2 -25 replies
3/5staging: rtl8723bs: use standard offsetof in cfg80211 operationsdrivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c+2 -10 replies
4/5staging: rtl8723bs: remove dead code from odm.cdrivers/staging/rtl8723bs/hal/odm.c+0 -41 reply
5/5staging: rtl8723bs: use offsetof in rtw_mlme_ext.cdrivers/staging/rtl8723bs/core/rtw_mlme_ext.c+2 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] staging: rtl8723bs: remove custom FIELD_OFFSET macro and dead code

This series performs cleanup on the rtl8723bs staging driver to align with kernel coding standards.

The driver defined a custom macro FIELD_OFFSET which duplicated the functionality of the standard offsetof() macro. This series replaces all usages of the custom macro with the standard one and removes the redundant definition.

Additionally, this series removes dead commented-out code in odm.c that referenced unsupported chips (RTL8723A/RTL8188E).

All patches checkpatch clean.

Navaneeth K (5):
staging: rtl8723bs: remove custom FIELD_OFFSET macro
staging: rtl8723bs: replace FIELD_OFFSET usage with offsetof
staging: rtl8723bs: use standard offsetof in cfg80211 operations
staging: rtl8723bs: remove dead code from odm.c
staging: rtl8723bs: use offsetof in rtw_mlme_ext.c

 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c     | 4 ++--
 drivers/staging/rtl8723bs/hal/odm.c               | 4 ----
 drivers/staging/rtl8723bs/include/basic_types.h   | 3 +--
 drivers/staging/rtl8723bs/include/drv_types.h     | 4 ++--
 drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 3 ++-
 5 files changed, 7 insertions(+), 11 deletions(-)
Signature · 1 line
2.43.0