Skip to content

xsk: introduce atomic for cq in generic path

Jason Xing bpf netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 6 repliesIn review
  2. v23 patches 6 repliesSuperseded
  3. v13 patches 2 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3xsk: add atomic cached_prod for copy modenet/xdp/xsk_queue.h+5 -10 replies
2/3xsk: use atomic operations around cached_prod for copy modenet/xdp/xsk.c net/xdp/xsk_queue.h+14 -76 replies
3/3xsk: remove spin lock protection of cached_prodinclude/net/xsk_buff_pool.h net/xdp/xsk.c net/xdp/xsk_buff_pool.c+4 -230 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH net-next v3 0/3] xsk: introduce atomic for cq in generic path

From: Jason Xing <[email protected]>

This series tries to replace cq_cached_prod_lock spin lock with atomic operations to get better performance.

---
v3

1. fix one race issue that cannot be resolved by simple seperated atomic operations. So this revision only updates patch [2/3] and tries to use try_cmpxchg method to avoid that problem. (paolo)
2. update commit log accordingly.

V2

1. use separate functions rather than branches within shared routines. (Maciej)
2. make each patch as simple as possible for easier review

Jason Xing (3):
xsk: add atomic cached_prod for copy mode
xsk: use atomic operations around cached_prod for copy mode
xsk: remove spin lock protection of cached_prod

 include/net/xsk_buff_pool.h |  5 -----
 net/xdp/xsk.c               | 23 +++++------------------
 net/xdp/xsk_buff_pool.c     |  1 -
 net/xdp/xsk_queue.h         | 23 +++++++++++++++++------
 4 files changed, 22 insertions(+), 30 deletions(-)
Signature · 1 line
2.41.3