Skip to content

resolve_btfids: Support for BTF modifications

Ihor Solodrai bpf dwarves linux-kbuild lkml sched-ext 7 versions – Applied

Status from this message: This series was applied to bpf/bpf-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest8 patches 0 repliesApplied 8/8
  2. v68 patches 3 repliesSuperseded
  3. v58 patches 1 replySuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v48 patches11 repliesSuperseded
v36 patches19 repliesSuperseded
v24 patches25 repliesSuperseded
v14 patches10 repliesSuperseded

Changes in v7 from the cover letter

- documentation edits in patches #5 and #6 (Nicolas)

Patches in v7 All 8 applied

#Subject and filesSizeRepliesApplied
1/8resolve_btfids: Rename object btf field to btf_pathtools/bpf/resolve_btfids/main.c+5 -50 repliesApplied
2/8resolve_btfids: Factor out load_btf()tools/bpf/resolve_btfids/main.c+34 -130 repliesApplied
3/8resolve_btfids: Introduce enum btf_id_kindtools/bpf/resolve_btfids/main.c+60 -230 repliesApplied
4/8resolve_btfids: Always build with -Wall -Werrortools/bpf/resolve_btfids/Makefile+2 -10 repliesApplied
5/8kbuild: Sync kconfig when PAHOLE_VERSION changesMakefile init/Kconfig+12 -50 repliesApplied
6/8lib/Kconfig.debug: Set the minimum required pahole version to v1.22Documentation/process/changes.rst Documentation/scheduler/sched-ext.rst lib/Kconfig.debug +2 more+7 -210 repliesApplied
7/8selftests/bpf: Run resolve_btfids only for relevant .test.o objectstools/testing/selftests/bpf/Makefile+6 -20 repliesApplied
8/8resolve_btfids: Change in-place update with raw binary outputMAINTAINERS scripts/Makefile.btf scripts/Makefile.modfinal +7 more+328 -1310 repliesApplied

Reviews trailers per patch

7 of 8 patches have a Reviewed-by or Acked-by.

PatchEduard ZingermanAlan MaguireNicolas Schier
1/8A-b T-b
2/8A-b T-b
3/8A-b T-b
4/8T-b
5/8T-b R-b T-b
6/8A-b T-b A-b
7/8A-b T-b
8/8A-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v7 thread

Cover letter [PATCH bpf-next v7 0/8] resolve_btfids: Support for BTF modifications

This series changes resolve_btfids and kernel build scripts to enable BTF transformations in resolve_btfids. Main motivation for enhancing resolve_btfids is to reduce dependency of the kernel build on pahole capabilities [1] and enable BTF features and optimizations [2][3] particular to the kernel.

Patches #1-#4 in the series are non-functional changes in resolve_btfids.

Patch #5 makes kernel build notice pahole version changes between builds.

Patch #6 changes minimum version of pahole required for CONFIG_DEBUG_INFO_BTF to v1.22

Patch #7 makes a small prep change in selftests/bpf build.

The last patch (#8) makes significant changes in resolve_btfids and introduces scripts/gen-btf.sh. See implementation details in the patch description.

Successful BPF CI run: https://github.com/kernel-patches/bpf/actions/runs/20378061470

[1] https://lore.kernel.org/dwarves/[email protected]/
[2] https://lore.kernel.org/bpf/[email protected]/
[3] https://lore.kernel.org/bpf/[email protected]/

---

v6->v7:
- documentation edits in patches #5 and #6 (Nicolas)

v6: https://lore.kernel.org/bpf/[email protected]/

v5->v6:
- patch #8: fix double free when btf__distill_base fails (reported by AI)

    https://lore.kernel.org/bpf/e269870b8db409800045ee0061fc02d21721e0efadd99ca83960b48f8db7b3f3@mail.kernel.org/

v5: https://lore.kernel.org/bpf/[email protected]/

v4->v5:
- patch #3: fix an off-by-one bug (reported by AI)

    https://lore.kernel.org/bpf/106b6e71bce75b8f12a85f2f99e75129e67af7287f6d81fa912589ece14044f9@mail.kernel.org/

- patch #8: cleanup GEN_BTF in Makefile.btf

v4: https://lore.kernel.org/bpf/[email protected]/

v3->v4:
- add patch #4: "resolve_btfids: Always build with -Wall -Werror"
- add patch #5: "kbuild: Sync kconfig when PAHOLE_VERSION changes" (Alan)
- fix clang cross-compilation (LKP)

    https://lore.kernel.org/bpf/[email protected]/

- remove GEN_BTF env variable (Andrii)
- nits and cleanup in resolve_btfids/main.c (Andrii, Eduard)
- nits in a patch bumping minimum pahole version (Andrii, AI)

v3: https://lore.kernel.org/bpf/[email protected]/

v2->v3:
- add patch #4 bumping minimum pahole version (Andrii, Alan)
- add patch #5 pre-fixing resolve_btfids test (Donglin)
- add GEN_BTF var and assemble RESOLVE_BTFIDS_FLAGS in Makefile.btf (Alan)
- implement --distill_base flag in resolve_btfids, set it depending on KBUILD_EXTMOD in Makefile.btf (Eduard)
- various implementation nits, see the v2 thread for details (Andrii, Eduard)

v2: https://lore.kernel.org/bpf/[email protected]/

v1->v2:
- gen-btf.sh and other shell script fixes (Donglin)
- update selftests build (Donglin)
- generate .BTF.base only when KBUILD_EXTMOD is set (Alan)
- proper endianness handling for cross-compilation
- change elf_begin mode from ELF_C_RDWR_MMAP to ELF_C_READ_MMAP_PRIVATE
- remove compressed_section_fix()
- nit NULL check in patch #3 (suggested by AI)

v1: https://lore.kernel.org/bpf/[email protected]/

Ihor Solodrai (8):
resolve_btfids: Rename object btf field to btf_path
resolve_btfids: Factor out load_btf()
resolve_btfids: Introduce enum btf_id_kind
resolve_btfids: Always build with -Wall -Werror
kbuild: Sync kconfig when PAHOLE_VERSION changes lib/Kconfig.debug: Set the minimum required pahole version to v1.22 selftests/bpf: Run resolve_btfids only for relevant .test.o objects
resolve_btfids: Change in-place update with raw binary output

 Documentation/process/changes.rst             |   4 +-
 Documentation/scheduler/sched-ext.rst         |   1 -
 MAINTAINERS                                   |   1 +
 Makefile                                      |  15 +-
 init/Kconfig                                  |   2 +-
 lib/Kconfig.debug                             |  13 +-
 scripts/Makefile.btf                          |  21 +-
 scripts/Makefile.modfinal                     |   5 +-
 scripts/Makefile.vmlinux                      |   2 +-
 scripts/gen-btf.sh                            | 157 ++++++++
 scripts/link-vmlinux.sh                       |  42 +-
 tools/bpf/resolve_btfids/Makefile             |   3 +-
 tools/bpf/resolve_btfids/main.c               | 358 ++++++++++++------
 tools/sched_ext/README.md                     |   1 -
 tools/testing/selftests/bpf/.gitignore        |   3 +
 tools/testing/selftests/bpf/Makefile          |  11 +-
 .../selftests/bpf/prog_tests/resolve_btfids.c |   4 +-
 17 files changed, 448 insertions(+), 195 deletions(-)
 create mode 100755 scripts/gen-btf.sh
Signature · 1 line
2.52.0