Skip to content

ata: libata: Improve max sectors quirk handling

Niklas Cassel linux-ide 1 version Applied

Status from this message: Applied to for-6.20.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v4 Latest6 patches 2 repliesApplied

Changes in v4 from the cover letter

-Pick up tags from Damien.
-Fix minor review comments from Damien.

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/6ata: libata: Add ATA_QUIRK_MAX_SEC and convert all device quirksdrivers/ata/libata-core.c include/linux/ata.h include/linux/libata.h+61 -121 reply
2/6ata: libata: Add ata_force_get_fe_for_dev() helperdrivers/ata/libata-core.c+34 -220 replies
3/6ata: libata: Change libata.force to use the generic ATA_QUIRK_MAX_SEC quirkdrivers/ata/libata-core.c include/linux/ata.h include/linux/libata.h+16 -180 replies
4/6ata: libata: Add support to parse equal sign in libata.forcedrivers/ata/libata-core.c+36 -20 replies
5/6ata: libata: Add libata.force parameter max_secDocumentation/admin-guide/kernel-parameters.txt drivers/ata/libata-core.c+6 -00 replies
6/6ata: libata: Allow more quirksdrivers/ata/libata-core.c include/linux/libata.h+41 -410 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchDamien Le MoalMartin K. Petersen
1/6R-b R-b
2/6R-b R-b
3/6R-b R-b
4/6R-b R-b
5/6R-b R-b
6/6R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/6] ata: libata: Improve max sectors quirk handling

Hello there,

a recent change:
commit 9b8b84879d4a ("block: Increase BLK_DEF_MAX_SECTORS_CAP")

bumped the default max_sectors_kb from 1280 to 4096.

It seems like a lot for SATA controllers are buggy and don't really like this, see:
https://bugzilla.kernel.org/show_bug.cgi?id=220693

Therefore, improve the max sectors quirk handling, to only have one max sectors quirk, which also takes an additional value.

This reduces the number of ATA_QUIRK_MAX_SEC_XXX quirks from 3 to 1, while also making it easier to quirk additional devices with different max sector limits.

The series is based on libata for-next branch, and the intention is to queue this series up for v7.0.

Changes since v3:
-Pick up tags from Damien.
-Fix minor review comments from Damien.

Niklas Cassel (6):
ata: libata: Add ATA_QUIRK_MAX_SEC and convert all device quirks
ata: libata: Add ata_force_get_fe_for_dev() helper
ata: libata: Change libata.force to use the generic ATA_QUIRK_MAX_SEC
quirk
ata: libata: Add support to parse equal sign in libata.force
ata: libata: Add libata.force parameter max_sec
ata: libata: Allow more quirks

 .../admin-guide/kernel-parameters.txt         |   5 +
 drivers/ata/libata-core.c                     | 205 +++++++++++++-----
 include/linux/ata.h                           |   3 -
 include/linux/libata.h                        |  70 +++---
 4 files changed, 191 insertions(+), 92 deletions(-)

base-commit: 2e983271363108b3813b38754eb96d9b1cb252bb

Signature · 1 line
2.52.0