Skip to content

gpu: nova-core: miscellaneous improvements

Alexandre Courbot dri-devel lkml nouveau rust-for-linux 3 versions – In review

Get series with b4
b4 am [email protected] change-id 20251208-nova-misc-1d797b5d64f2

Versions newest first

  1. v3 Latest8 patches 6 repliesIn review
  2. v210 patches 12 repliesSuperseded
  3. v19 patches 14 repliesSuperseded

Changes in v3 from the cover letter

- Use inspect() to warn about remaining data in the GSP command queue.
- Drop "firmware: fwsec: do not require bound device when unneeded".
- Drop "simplify str_from_null_terminated" as str_from_null_terminated has been removed.
- Derive Zeroable on the original GspStaticConfigInfo tuple struct.
- Link to v2: https://patch.msgid.link/[email protected]

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8gpu: nova-core: gsp: warn if data remains after processing a messagedrivers/gpu/nova-core/gsp/cmdq.rs+11 -10 replies
2/8gpu: nova-core: gsp: remove unnecessary Display implsdrivers/gpu/nova-core/gsp/cmdq.rs drivers/gpu/nova-core/gsp/fw.rs+1 -550 replies
3/8gpu: nova-core: gsp: simplify sequencer opcode parsingdrivers/gpu/nova-core/gsp/fw.rs+5 -350 replies
4/8gpu: nova-core: gsp: remove unneeded sequencer traitdrivers/gpu/nova-core/gsp/sequencer.rs+6 -110 replies
5/8gpu: nova-core: gsp: derive `Debug` on more sequencer typesdrivers/gpu/nova-core/gsp/fw.rs drivers/gpu/nova-core/gsp/sequencer.rs+6 -50 replies
6/8gpu: nova-core: gsp: derive Zeroable for GspStaticConfigInfodrivers/gpu/nova-core/gsp/fw/commands.rs+1 -40 replies
7/8gpu: nova-core: use core library's CStr instead of kernel onedrivers/gpu/nova-core/firmware.rs drivers/gpu/nova-core/firmware/gsp.rs drivers/gpu/nova-core/nova_core.rs+7 -32 replies
8/8gpu: nova-core: gsp: use available device referencedrivers/gpu/nova-core/gsp/boot.rs+8 -261 reply

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchLyude PaulAlistair PoppleGary GuoDanilo Krummrich
SeriesR-b
1/8R-b
2/8R-b R-b R-b
3/8R-b R-b
4/8R-b R-b
5/8R-b R-b
6/8R-b
7/8R-b R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/8] gpu: nova-core: miscellaneous improvements

A few simple, loosely-related small improvements for nova-core, including reporting unprocessed data in GSP messages, removal of unnecessary code in GSP and the sequencer, and leveraging the Zeroable derive macro and core library's CStr. Probably nothing too controversial, so I plan on applying it soon after -rc1 gets released.

This revision is based on master.

---
Changes in v3:
- Use inspect() to warn about remaining data in the GSP command queue.
- Drop "firmware: fwsec: do not require bound device when unneeded".
- Drop "simplify str_from_null_terminated" as str_from_null_terminated has been removed.
- Derive Zeroable on the original GspStaticConfigInfo tuple struct.
- Link to v2: https://patch.msgid.link/[email protected]

Changes in v2:
- Rebase on drm-rust-next.
- Add a patch to reuse previously acquired reference to define in GSP boot sequence.
- Link to v1: https://patch.msgid.link/[email protected]

---
Alexandre Courbot (8):
gpu: nova-core: gsp: warn if data remains after processing a message
gpu: nova-core: gsp: remove unnecessary Display impls
gpu: nova-core: gsp: simplify sequencer opcode parsing
gpu: nova-core: gsp: remove unneeded sequencer trait
gpu: nova-core: gsp: derive Debug on more sequencer types
gpu: nova-core: gsp: derive Zeroable for GspStaticConfigInfo
gpu: nova-core: use core library's CStr instead of kernel one
gpu: nova-core: gsp: use available device reference

 drivers/gpu/nova-core/firmware.rs        |   2 +-
 drivers/gpu/nova-core/firmware/gsp.rs    |   6 +-
 drivers/gpu/nova-core/gsp/boot.rs        |  34 +++-------
 drivers/gpu/nova-core/gsp/cmdq.rs        |  14 ++++-
 drivers/gpu/nova-core/gsp/fw.rs          | 104 +++----------------------------
 drivers/gpu/nova-core/gsp/fw/commands.rs |   5 +-
 drivers/gpu/nova-core/gsp/sequencer.rs   |  18 +++---
 drivers/gpu/nova-core/nova_core.rs       |   2 +-
 8 files changed, 45 insertions(+), 140 deletions(-)

---
base-commit: 9702969978695d9a699a1f34771580cdbb153b33
change-id: 20251208-nova-misc-1d797b5d64f2

Best regards,

Signature · 1 line
Alexandre Courbot <[email protected]>