s390: Exception based WARN() / WARN_ONCE()
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest9 patches 4 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | kbuild: Require gcc-9 for s390scripts/ | +2 | 0 replies | |
| 2/9 | s390/bug: Convert to inline assembly with input operandsarch/ | +30 | 0 replies | |
| 3/9 | s390/bug: Use BUG_FORMAT for DEBUG_BUGVERBOSE_DETAILEDarch/ | +13 | 0 replies | |
| 4/9 | s390/bug: Introduce and use monitor code macroarch/ arch/ | +11 | 0 replies | |
| 5/9 | s390/traps: Copy monitor code to pt_regsarch/ arch/ | +5 | 0 replies | |
| 6/9 | s390/bug: Implement __WARN_printf()arch/ arch/ arch/ | +96 | 2 replies | |
| 7/9 | s390/bug: Implement WARN_ONCE()arch/ | +11 | 0 replies | |
| 8/9 | s390/bug: Skip __WARN_trap() in call tracesarch/ | +4 | 0 replies | |
| 9/9 | s390/bug: Prevent tail-call optimizationarch/ | +2 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/9] s390: Exception based WARN() / WARN_ONCE()
Use the generic infrastructure introduced by Peter Zijlstra [1] to implement an exception based WARN() and WARN_ONCE() similar to x86.
Due to some compiler oddities on s390 this requires to raise the minimum gcc version to 9. Maybe there are ways to avoid this, but I failed to find a working solution. Details are in the patch descriptions.
Just posting this now to also get some compile bot testing, since I'm afraid there might be some compiler version / config option around where even this new approach breaks.
Peter, since you were wondering: your generic infrastructure pieces work very nice. Looking at the x86 and s390 implementation: it might be possible to make things even more generic since both __WARN_printf(), and WARN_ONCE() are identical; it looks like only __WARN_print_arg() needs to be provided.
Arnd, just adding you so you know that there may be an architecture which requires gcc-9 instead of gcc-8 in the near future.
Series is based ongit://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git features
...and not yet meant to be included anywhere.
Thanks,
Heiko
[1] https://lore.kernel.org/all/[email protected]/
Heiko Carstens (9):
kbuild: Require gcc-9 for s390
s390/bug: Convert to inline assembly with input operands s390/bug: Use BUG_FORMAT for DEBUG_BUGVERBOSE_DETAILED s390/bug: Introduce and use monitor code macro s390/traps: Copy monitor code to pt_regs s390/bug: Implement __WARN_printf()
s390/bug: Implement WARN_ONCE()
s390/bug: Skip __WARN_trap() in call traces s390/bug: Prevent tail-call optimization
arch/s390/include/asm/bug.h | 141 ++++++++++++++++++++++++--------- arch/s390/include/asm/ptrace.h | 5 +- arch/s390/kernel/entry.S | 7 ++ arch/s390/kernel/traps.c | 42 +++++++++- scripts/min-tool-version.sh | 2 + 5 files changed, 156 insertions(+), 41 deletions(-)
base-commit: 70075e3d0ca0b72cc983d03f7cd9796e43492980
Signature · 1 line
2.51.0