hw/arm/virt: Introduce Tegra241 CMDQV support for accelerated SMMUv3
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v7 Latest31 patches 11 repliesIn review
- v631 patches 23 repliesSuperseded
- v532 patches 51 repliesSuperseded
Earlier versions · 4
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v4 | 31 patches | 69 replies | Superseded | |
| v3 | 32 patches | 59 replies | Superseded | |
| v2 | 24 patches | 56 replies | Superseded | |
| v1 RFC | 16 patches | 51 replies | Superseded |
Changes in v7 from the cover letter
https://lore.kernel.org/qemu-devel/[email protected]/
- Addressed v6 feedback and picked up R-by/T-by tags. Thanks!
- mmap the host VINTF Page0 at IOMMU_VIOMMU_ALLOC instead of on VINTF enable (patch #14)
- Reset the per-VCMDQ Page0 cache when a queue is freed (patch #19)
- Distributed the reset teardown into the patches that introduce each resource (patches #18, #21)
- Added a VCMDQ readiness helper and renamed the Page0 backing-pointer helper to vintf_lvcmdq_ptr() (patches #18, #19)
- Trace the VCMDQ Page0 backing, hw vs cache (patch #19)
- Renamed patch #24 to reflect the changes accurately
- Updated the design and lifecycle documentation (patch #30)
- Based on top of Nathan's "Resolve AUTO properties" v6 series [0].
Patches in v7 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/31 | backends/iommufd: Update iommufd_backend_get_device_infobackends/ hw/ hw/ | +10 | 0 replies | |
| 2/31 | backends/iommufd: Update iommufd_backend_alloc_viommu to allow user ptrbackends/ backends/ hw/ +1 more | +8 | 0 replies | |
| 3/31 | backends/iommufd: Introduce iommufd_backend_alloc_hw_queuebackends/ backends/ include/ | +43 | 0 replies | |
| 4/31 | backends/iommufd: Introduce iommufd_backend_viommu_mmapbackends/ backends/ include/ | +27 | 0 replies | |
| 5/31 | system/iommufd: Remove unused viommu pointer from IOMMUFDVeventqhw/ include/ | +0 | 0 replies | |
| 6/31 | hw/arm/smmuv3-accel: Introduce CMDQV ops interfacehw/ | +34 | 0 replies | |
| 7/31 | hw/arm/tegra241-cmdqv: Add Tegra241 CMDQV ops backend stubhw/ hw/ hw/ +2 more | +94 | 0 replies | |
| 8/31 | hw/arm/smmuv3-accel: Wire CMDQV ops into accel lifecyclehw/ include/ | +89 | 0 replies | |
| 9/31 | hw/arm/virt: Use stored SMMUv3 device list for IORT buildhw/ hw/ include/ | +35 | 0 replies | |
| 10/31 | hw/arm/tegra241-cmdqv: Probe host Tegra241 CMDQV supporthw/ hw/ | +34 | 0 replies | |
| 11/31 | hw/arm/tegra241-cmdqv: Implement CMDQV inithw/ hw/ hw/ | +59 | 0 replies | |
| 12/31 | hw/arm/virt: Link SMMUv3 CMDQV resources to platform bushw/ | +22 | 0 replies | |
| 13/31 | hw/arm/tegra241-cmdqv: Implement CMDQV vIOMMU alloc/freehw/ hw/ | +48 | 0 replies | |
| 14/31 | hw/arm/tegra241-cmdqv: mmap host VINTF Page0 for CMDQVhw/ hw/ | +18 | 1 reply | |
| 15/31 | hw/arm/tegra241-cmdqv: Emulate CMDQ-V Config regionhw/ hw/ hw/ | +294 | 0 replies | |
| 16/31 | hw/arm/tegra241-cmdqv: Emulate VCMDQ register readshw/ hw/ hw/ | +321 | 0 replies | |
| 17/31 | hw/arm/tegra241-cmdqv: Emulate VCMDQ register writeshw/ hw/ | +159 | 0 replies | |
| 18/31 | hw/arm/tegra241-cmdqv: Allocate HW VCMDQs once configuredhw/ hw/ | +171 | 1 reply | |
| 19/31 | hw/arm/tegra241-cmdqv: Route allocated VCMDQ Page0 accesses to the mmap'd host VINTF page0hw/ hw/ | +91 | 2 replies | |
| 20/31 | memory: Allow RAM device regions to skip IOMMU mappinghw/ hw/ include/ +1 more | +38 | 0 replies | |
| 21/31 | hw/arm/tegra241-cmdqv: Use mmap'd host VINTF page0 for virtual VINTF page0hw/ hw/ | +38 | 1 reply | |
| 22/31 | hw/arm/smmuv3-accel: Introduce common helper for veventq readhw/ hw/ hw/ | +49 | 0 replies | |
| 23/31 | hw/arm/tegra241-cmdqv: Read and propagate Tegra241 CMDQV errorshw/ hw/ | +64 | 0 replies | |
| 24/31 | hw/arm/tegra241-cmdqv: Initialize register state on resethw/ hw/ hw/ | +42 | 0 replies | |
| 25/31 | hw/arm/tegra241-cmdqv: Limit queue size based on backend page sizehw/ | +20 | 0 replies | |
| 26/31 | hw/arm/smmuv3: Add per-device identifier propertyhw/ hw/ hw/ +1 more | +19 | 0 replies | |
| 27/31 | hw/arm/smmuv3-accel: Introduce helper to query CMDQV typehw/ hw/ hw/ +1 more | +33 | 0 replies | |
| 28/31 | hw/arm/virt-acpi: Advertise Tegra241 CMDQV nodes in DSDThw/ hw/ | +53 | 0 replies | |
| 29/31 | hw/arm/smmuv3-accel: Enforce viommu association when CMDQV is activehw/ hw/ | +19 | 0 replies | |
| 30/31 | hw/arm/tegra241-cmdqv: Document the CMDQV design and lifecyclehw/ | +100 | 2 replies | |
| 31/31 | hw/arm/smmuv3: Add cmdqv property for SMMUv3 devicehw/ qemu-options.hx | +16 | 0 replies |
Reviews trailers per patch
All 31 patches have a Reviewed-by or Acked-by.
| Patch | Eric Auger | Nicolin Chen |
|---|---|---|
| Series | T-b | |
| 1/31 | R-b | T-b |
| 2/31 | R-b | T-b |
| 3/31 | R-b | T-b |
| 4/31 | R-b | T-b |
| 5/31 | R-b | R-b T-b |
| 6/31 | R-b | R-b T-b |
| 7/31 | R-b | R-b T-b |
| 8/31 | R-b | R-b T-b |
| 9/31 | R-b | R-b T-b |
| 10/31 | R-b | R-b T-b |
| 11/31 | R-b | T-b |
| 12/31 | R-b | R-b T-b |
| 13/31 | R-b | T-b |
| 14/31 | R-b | T-b |
| 15/31 | R-b | T-b |
| 16/31 | R-b | T-b |
| 17/31 | R-b | T-b |
| 18/31 | R-b | T-b |
| 19/31 | R-b | T-b R-b |
| 20/31 | R-b T-b | T-b |
| 21/31 | R-b | T-b |
| 22/31 | R-b | R-b T-b |
| 23/31 | R-b | R-b T-b |
| 24/31 | R-b | T-b |
| 25/31 | R-b | T-b |
| 26/31 | R-b | R-b T-b |
| 27/31 | R-b | R-b T-b |
| 28/31 | R-b | T-b |
| 29/31 | R-b | R-b T-b |
| 30/31 | R-b | T-b R-b |
| 31/31 | R-b | R-b T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v7 00/31] hw/arm/virt: Introduce Tegra241 CMDQV support for accelerated SMMUv3
Hi,
Changes from v6:
https://lore.kernel.org/qemu-devel/[email protected]/
- Addressed v6 feedback and picked up R-by/T-by tags. Thanks!
- mmap the host VINTF Page0 at IOMMU_VIOMMU_ALLOC instead of on VINTF enable (patch #14)
- Reset the per-VCMDQ Page0 cache when a queue is freed (patch #19)
- Distributed the reset teardown into the patches that introduce each resource (patches #18, #21)
- Added a VCMDQ readiness helper and renamed the Page0 backing-pointer helper to vintf_lvcmdq_ptr() (patches #18, #19)
- Trace the VCMDQ Page0 backing, hw vs cache (patch #19)
- Renamed patch #24 to reflect the changes accurately
- Updated the design and lifecycle documentation (patch #30)
- Based on top of Nathan's "Resolve AUTO properties" v6 series [0].
Please find the complete branch here:
https://github.com/shamiali2008/qemu-master/tree/master-vcmdq-v7-ext
Sanity tested on NVIDIA Grace. Further testing in progress.
Feedback and testing are very welcome.
Thanks,
Shameer
[0] https://lore.kernel.org/qemu-devel/[email protected]/
---
Background(from RFCv1):
https://lore.kernel.org/qemu-devel/[email protected]/
Thanks to Nicolin for the initial patches and testing on which this is based.
Tegra241 CMDQV extends SMMUv3 by allocating per-VM "virtual interfaces" (VINTFs), each hosting up to 128 VCMDQs.
Each VINTF exposes two 64KB MMIO pages:
- Page0 – guest owned control and status registers (directly mapped into the VM)
- Page1 – queue configuration registers (trapped/emulated by QEMU)
Unlike the standard SMMU CMDQ, a guest owned Tegra241 VCMDQ does not support the full command set. Only a subset, primarily invalidation related commands, is accepted by the CMDQV hardware. For this reason, a distinct CMDQV device must be exposed to the guest, and the guest OS must include a Tegra241 CMDQV aware driver to take advantage of the hardware acceleration.
VCMDQ support is integrated via the IOMMU_HW_QUEUE_ALLOC mechanism, allowing QEMU to attach guest configured VCMDQ buffers to the underlying CMDQV hardware through IOMMUFD. The Linux kernel already supports the full CMDQV virtualisation model via IOMMUFD[0].
---
Nicolin Chen (15):
backends/iommufd: Update iommufd_backend_get_device_info backends/iommufd: Update iommufd_backend_alloc_viommu to allow user
ptr
backends/iommufd: Introduce iommufd_backend_alloc_hw_queue backends/iommufd: Introduce iommufd_backend_viommu_mmap hw/arm/tegra241-cmdqv: Implement CMDQV init hw/arm/tegra241-cmdqv: Implement CMDQV vIOMMU alloc/free hw/arm/tegra241-cmdqv: mmap host VINTF Page0 for CMDQV hw/arm/tegra241-cmdqv: Emulate CMDQ-V Config region hw/arm/tegra241-cmdqv: Emulate VCMDQ register reads hw/arm/tegra241-cmdqv: Emulate VCMDQ register writes hw/arm/tegra241-cmdqv: Allocate HW VCMDQs once configured hw/arm/tegra241-cmdqv: Use mmap'd host VINTF page0 for virtual VINTF
page0
hw/arm/tegra241-cmdqv: Initialize register state on reset hw/arm/tegra241-cmdqv: Limit queue size based on backend page size hw/arm/virt-acpi: Advertise Tegra241 CMDQV nodes in DSDT
Shameer Kolothum (16):
system/iommufd: Remove unused viommu pointer from IOMMUFDVeventq hw/arm/smmuv3-accel: Introduce CMDQV ops interface hw/arm/tegra241-cmdqv: Add Tegra241 CMDQV ops backend stub hw/arm/smmuv3-accel: Wire CMDQV ops into accel lifecycle hw/arm/virt: Use stored SMMUv3 device list for IORT build hw/arm/tegra241-cmdqv: Probe host Tegra241 CMDQV support hw/arm/virt: Link SMMUv3 CMDQV resources to platform bus hw/arm/tegra241-cmdqv: Route allocated VCMDQ Page0 accesses to the
mmap'd host VINTF page0
memory: Allow RAM device regions to skip IOMMU mapping hw/arm/smmuv3-accel: Introduce common helper for veventq read hw/arm/tegra241-cmdqv: Read and propagate Tegra241 CMDQV errors hw/arm/smmuv3: Add per-device identifier property hw/arm/smmuv3-accel: Introduce helper to query CMDQV type hw/arm/smmuv3-accel: Enforce viommu association when CMDQV is active hw/arm/tegra241-cmdqv: Document the CMDQV design and lifecycle hw/arm/smmuv3: Add cmdqv property for SMMUv3 device
hw/arm/smmuv3-accel.h | 48 ++ hw/arm/tegra241-cmdqv.h | 384 +++++++++++ include/hw/arm/smmuv3.h | 3 + include/hw/arm/virt.h | 1 + include/system/iommufd.h | 17 +- include/system/memory.h | 21 + backends/iommufd.c | 64 ++ hw/arm/smmuv3-accel-stubs.c | 12 + hw/arm/smmuv3-accel.c | 194 ++++-- hw/arm/smmuv3.c | 10 + hw/arm/tegra241-cmdqv-stubs.c | 16 + hw/arm/tegra241-cmdqv.c | 1119 +++++++++++++++++++++++++++++++++ hw/arm/virt-acpi-build.c | 127 ++-- hw/arm/virt.c | 37 ++ hw/vfio/iommufd.c | 4 +- hw/vfio/listener.c | 6 + system/memory.c | 10 + backends/trace-events | 4 +- hw/arm/Kconfig | 5 + hw/arm/meson.build | 2 + hw/arm/trace-events | 11 + hw/vfio/trace-events | 1 + qemu-options.hx | 8 + 23 files changed, 2024 insertions(+), 80 deletions(-) create mode 100644 hw/arm/tegra241-cmdqv.h create mode 100644 hw/arm/tegra241-cmdqv-stubs.c create mode 100644 hw/arm/tegra241-cmdqv.c
Signature · 1 line
2.43.0