Skip to content

ASoC: Intel: catpt: IPC log improvements and code simplification

Cezary Rojewski linux-sound 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5ASoC: Intel: catpt: Move IPC error messages one level downsound/soc/intel/catpt/core.h sound/soc/intel/catpt/ipc.c sound/soc/intel/catpt/messages.c+21 -840 replies
2/5ASoC: Intel: catpt: Update CATPT_IPC_ERROR macrosound/soc/intel/catpt/core.h sound/soc/intel/catpt/device.c sound/soc/intel/catpt/loader.c +2 more+15 -190 replies
3/5ASoC: Intel: catpt: Simplify catpt_stream_read_position()sound/soc/intel/catpt/pcm.c+4 -80 replies
4/5ASoC: Intel: catpt: Specify image names in the device descriptorsound/soc/intel/catpt/core.h sound/soc/intel/catpt/device.c sound/soc/intel/catpt/loader.c+4 -50 replies
5/5ASoC: Intel: catpt: Drop superfluous space in PCM codesound/soc/intel/catpt/pcm.c+5 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] ASoC: Intel: catpt: IPC log improvements and code simplification

Entire patchset provides no new features and does not alter the code from functional (user) perspective.

The first two improve IPC-error logging 'mechanism' and align the catpt-driver with what's done in another Intel's driver: the avs-driver. In essence, no need to log the error in every function, let the common handler do so instead.

The last three simplify the code, and fix some spacing issues. All in all, we get better readability with lower LOC.

Cezary Rojewski (5):
ASoC: Intel: catpt: Move IPC error messages one level down
ASoC: Intel: catpt: Update CATPT_IPC_ERROR macro
ASoC: Intel: catpt: Simplify catpt_stream_read_position()
ASoC: Intel: catpt: Specify image names in the device descriptor
ASoC: Intel: catpt: Drop superfluous space in PCM code

 sound/soc/intel/catpt/core.h     |  7 +--
 sound/soc/intel/catpt/device.c   |  6 ++-
 sound/soc/intel/catpt/ipc.c      | 12 +++--
 sound/soc/intel/catpt/loader.c   |  8 +--
 sound/soc/intel/catpt/messages.c | 89 +++++---------------------------
 sound/soc/intel/catpt/pcm.c      | 46 +++++++----------
 sound/soc/intel/catpt/sysfs.c    |  2 +-
 7 files changed, 49 insertions(+), 121 deletions(-)
Signature · 1 line
2.25.1