Skip to content

Fix Omen 16-wf1xxx thermal profile and add EC readback

Krishna Chomal lkml platform-driver-x86 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest2 patches 6 repliesIn review
  2. v42 patches 3 repliesSuperseded
  3. v32 patches 1 replySuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v21 patch3 repliesSuperseded
v11 patch3 repliesSuperseded

Changes in v5 from the cover letter

- Improved platform_profile_victus_s_get_ec() to support multiple EC layouts by iteratively probing offsets.

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2platform/x86: hp-wmi: fix platform profile values for Omen 16-wf1xxxdrivers/platform/x86/hp/hp-wmi.c+127 -520 replies
2/2platform/x86: hp-wmi: Add EC offsets to read Victus S thermal profiledrivers/platform/x86/hp/hp-wmi.c+89 -114 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [PATCH v5 0/2] Fix Omen 16-wf1xxx thermal profile and add EC readback

This series fixes incorrect thermal profile parameters sent for HP Omen 16-wf1xxx and implements hardware readback support for Victus S thermal profiles.

The first patch refactors the DMI handling for Victus S boards. By moving from simple string list to DMI system id table with driver_data, we can now map each board to its correct thermal parameters.

The second patch implements "get" callback for the platform profile API. It reads the hardware state from EC register 0x59. This ensures that the driver stays in sync with the hardware during driver init and power source change events.

Changes in v5:
- Improved platform_profile_victus_s_get_ec() to support multiple EC layouts by iteratively probing offsets.
Changes in v4:
- Fixed driver load failure caused in v3
- Handle err after calling victus_s_gpu_thermal_profile_get()
- Fixed wrong function call victus_s_powersource_event() Changes in v3:
- Moved DMI lookup to hp_wmi_init()
- Marked DMI table as __initconst
- Renamed eco to low_power
- Added second patch to implement "get" support for Victus S devices Changes in v2:
- Refactored victus_s_thermal_profile_boards to use DMI table
- Implemented driver_data to handle thermal profile parameters
- Moved enum definitions earlier in the file for thermal profile parameters
Changes in v1:
Initial fix for Omen 16-wf1xxx thermal profile values

Krishna Chomal (2):
platform/x86: hp-wmi: fix platform profile values for Omen 16-wf1xxx platform/x86: hp-wmi: Add EC offsets to read Victus S thermal profile

 drivers/platform/x86/hp/hp-wmi.c | 275 ++++++++++++++++++++++++-------
 1 file changed, 214 insertions(+), 61 deletions(-)
Signature · 1 line
2.52.0