Skip to content

fs/writeback: skip AS_NO_DATA_INTEGRITY mappings in wait_sb_inodes()

Joanne Koong linux-fsdevel linux-mm stable 2 versions – Applied

Status from this message: [merged mm-hotfixes-stable] fs-writeback-skip-as_no_data_integrity-mappings-in-wait_sb_inodes.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest1 patch 1 replyApplied 1/1
  2. v21 patch 22 repliesSuperseded

Changelog from the cover letter

v2: https://lore.kernel.org/linux-fsdevel/[email protected]/
* Add comments to commit message (David) and to wait_sb_inodes() (Andrew)
* Add Bernd's Reviewed-by and J's Tested-by

Patches in v3 All 1 applied

#Subject and filesSizeRepliesApplied
1/1fs/writeback: skip AS_NO_DATA_INTEGRITY mappings in wait_sb_inodes()fs/fs-writeback.c fs/fuse/file.c include/linux/pagemap.h+20 -21 replyApplied

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by.

PatchBernd SchubertJ. Neuschäfer
1/1R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/1] fs/writeback: skip AS_NO_DATA_INTEGRITY mappings in wait_sb_inodes()

This patch adds a new mapping flag AS_NO_DATA_INTEGRITY which signifies that a mapping does not have data integrity guarantees, and skips waiting on writeout for these mappings in wait_sb_inodes(), as these mappings cannot guarantee that data is persistently stored. This patch sets this flag on fuse mappings.

This fixes the userspace regression reported by Athul and J. upstream in [1][2] where if there is a bug in a fuse server that causes the server to never complete writeback, it will make wait_sb_inodes() wait forever.

Thanks,
Joanne

[1] https://lore.kernel.org/regressions/CAJnrk1ZjQ8W8NzojsvJPRXiv9TuYPNdj8Ye7=Cgkj=iV_i8EaA@mail.gmail.com/T/#t
[2] https://lore.kernel.org/linux-fsdevel/[email protected]/

Changelog:
v2: https://lore.kernel.org/linux-fsdevel/[email protected]/
* Add comments to commit message (David) and to wait_sb_inodes() (Andrew)
* Add Bernd's Reviewed-by and J's Tested-by

v1: https://lore.kernel.org/linux-mm/[email protected]/
* Change AS_WRITEBACK_MAY_HANG to AS_NO_DATA_INTEGRITY and keep AS_WRITEBACK_MAY_DEADLOCK_ON_RECLAIM as is.

Joanne Koong (1):
fs/writeback: skip AS_NO_DATA_INTEGRITY mappings in wait_sb_inodes()

 fs/fs-writeback.c       |  7 ++++++-
 fs/fuse/file.c          |  4 +++-
 include/linux/pagemap.h | 11 +++++++++++
 3 files changed, 20 insertions(+), 2 deletions(-)
Signature · 1 line
2.47.3