Skip to content

Enable/Disable DRM debug logging between tests in shard mode

Sobin Thomas igt-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1feat: Enable/Disable DRM debug logging between tests in shard moderunner/executor.c+147 -12 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH i-g-t 0/1] Enable/Disable DRM debug logging between tests in shard mode

In shard mode, when disk usage limit is exceeded during a test, DRM debug logging is disabled by writing "0" to /sys/module/drm/parameters/debug to prevent premature exit. However, this disabled state persisted across subsequent tests in the same shard, causing loss of debug information for tests that did not exceed the disk limit.

Add a global flag to track when DRM debug was disabled in a previous test. At the start of each new test in monitor_output(), check this flag and restore DRM debug logging to the original value (or default "14" if the original value could not be saved). Verify the write succeeded by reading back the value, retrying up to 10 times with 100ms delays if needed.

The original DRM debug value is saved once at startup in execute() before any tests run, ensuring we can restore to the correct state. The per-test logging_disabled flag remains local to monitor_output() to track state within the current test execution.

This ensures each test starts with a clean state and proper debug logging, while still allowing dynamic disabling when disk limits are exceeded.

Sobin Thomas (1):
feat: Enable/Disable DRM debug logging between tests in shard mode

 runner/executor.c | 148 +++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 147 insertions(+), 1 deletion(-)
Signature · 1 line
2.51.0