Skip to content

drm/i915/dp: Clean up link BW/DSC slice config computation (fixes)

Imre Deak dri-devel intel-gfx intel-xe 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest16 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16drm/dp: Parse all DSC slice count caps for eDP 1.5drivers/gpu/drm/display/drm_dp_helper.c+18 -230 replies
2/16drm/dp: Add drm_dp_dsc_sink_slice_count_mask()drivers/gpu/drm/display/drm_dp_helper.c include/drm/display/drm_dp_helper.h+61 -240 replies
3/16drm/i915/dp: Fix DSC sink's slice count capability checkdrivers/gpu/drm/i915/display/intel_dp.c+13 -50 replies
4/16drm/i915/dp: Return a fixed point BPP value from intel_dp_output_bpp()drivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_dp.h drivers/gpu/drm/i915/display/intel_dp_mst.c+26 -220 replies
5/16drm/i915/dp: Use a mode's crtc_clock vs. clock during state computationdrivers/gpu/drm/i915/display/intel_dp.c+3 -20 replies
6/16drm/i915/dp: Factor out intel_dp_link_bw_overhead()drivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_dp.h drivers/gpu/drm/i915/display/intel_dp_mst.c+34 -160 replies
7/16drm/i915/dp: Fix BW check in is_bw_sufficient_for_dsc_config()drivers/gpu/drm/i915/display/intel_dp.c+1 -10 replies
8/16drm/i915/dp: Use the effective data rate for DP BW calculationdrivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_dp.h drivers/gpu/drm/i915/display/intel_dp_link_training.c +1 more+33 -190 replies
9/16drm/i915/dp: Use the effective data rate for DP compressed BW calculationdrivers/gpu/drm/i915/display/intel_dp.c+16 -110 replies
10/16drm/i915/dp: Account with MST, SSC BW overhead for uncompressed DP-MST stream BWdrivers/gpu/drm/i915/display/intel_dp_mst.c+4 -10 replies
11/16drm/i915/dp: Account with DSC BW overhead for compressed DP-SST stream BWdrivers/gpu/drm/i915/display/intel_dp.c+5 -10 replies
12/16drm/i915/dp: Account with pipe joiner max compressed BPP limit for DP-MST and eDPdrivers/gpu/drm/i915/display/intel_dp.c+8 -80 replies
13/16drm/i915/dp: Fail state computation for invalid min/max link BPP valuesdrivers/gpu/drm/i915/display/intel_dp.c+6 -10 replies
14/16drm/i915/dp: Fail state computation for invalid max throughput BPP valuedrivers/gpu/drm/i915/display/intel_dp.c+0 -20 replies
15/16drm/i915/dp: Fail state computation for invalid max sink compressed BPP valuedrivers/gpu/drm/i915/display/intel_dp.c+1 -20 replies
16/16drm/i915/dp: Fail state computation for invalid DSC source input BPP valuesdrivers/gpu/drm/i915/display/intel_dp.c+21 -70 replies

Reviews trailers per patch

All 16 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchLuca CoelhoVinod GovindapillaiMaarten Lankhorst
SeriesA-b
1/16R-b
2/16R-b
3/16R-b
4/16R-b
5/16R-b
6/16R-b
7/16R-b
8/16R-b
9/16R-b R-b
10/16R-b
11/16R-b
12/16R-b
13/16R-b R-b
14/16R-b R-b
15/16R-b R-b
16/16R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 00/16] drm/i915/dp: Clean up link BW/DSC slice config computation (fixes)

This is the first part of patchset [1] containing only the fixes for the link BW and DSC slice computation. The remaining patches in [1] refactor the link BW and DSC slice computation simplifying these, to be sent as a follow-up to this patchset.

I moved patches 13-15 in [1] later in the patchset to be sent as part of the follow-up, as these patches are not a dependency for the fixes in this patchset.

[1] https://lore.kernel.org/all/[email protected]

Cc Ankit Nautiyal <[email protected]>
Cc Luca Coelho <[email protected]>
Cc Jouni Högander <[email protected]>
Cc Vinod Govindapillai <[email protected]>

Imre Deak (16):
drm/dp: Parse all DSC slice count caps for eDP 1.5
drm/dp: Add drm_dp_dsc_sink_slice_count_mask() drm/i915/dp: Fix DSC sink's slice count capability check drm/i915/dp: Return a fixed point BPP value from intel_dp_output_bpp() drm/i915/dp: Use a mode's crtc_clock vs. clock during state
computation
drm/i915/dp: Factor out intel_dp_link_bw_overhead() drm/i915/dp: Fix BW check in is_bw_sufficient_for_dsc_config() drm/i915/dp: Use the effective data rate for DP BW calculation drm/i915/dp: Use the effective data rate for DP compressed BW
calculation
drm/i915/dp: Account with MST, SSC BW overhead for uncompressed DP-MST
stream BW
drm/i915/dp: Account with DSC BW overhead for compressed DP-SST stream
BW
drm/i915/dp: Account with pipe joiner max compressed BPP limit for
DP-MST and eDP
drm/i915/dp: Fail state computation for invalid min/max link BPP
values
drm/i915/dp: Fail state computation for invalid max throughput BPP
value
drm/i915/dp: Fail state computation for invalid max sink compressed
BPP value
drm/i915/dp: Fail state computation for invalid DSC source input BPP
values

 drivers/gpu/drm/display/drm_dp_helper.c       | 103 ++++++---
 drivers/gpu/drm/i915/display/intel_dp.c       | 211 ++++++++++++------
 drivers/gpu/drm/i915/display/intel_dp.h       |   9 +-
 .../drm/i915/display/intel_dp_link_training.c |   4 +-
 drivers/gpu/drm/i915/display/intel_dp_mst.c   |  33 ++-
 include/drm/display/drm_dp_helper.h           |   3 +
 6 files changed, 234 insertions(+), 129 deletions(-)
Signature · 1 line
2.49.1