Add DWMAC glue driver for Motorcomm YT6801
Status from this message: This series was applied to netdev/net-next.git (main)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest3 patches 13 repliesApplied 3/3
- v5 RFC3 patches 4 repliesSuperseded
- v4 RFC3 patches 4 repliesSuperseded
Changes in v6 from the cover letter
- PATCH 1: Collect review tags
- PATCH 2: Remove struct device from dwmac_motorcomm_priv, since it's only used during probe.
- Link to v5: https://lore.kernel.org/netdev/[email protected]/
Patches in v6 All 3 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | net: phy: motorcomm: Support YT8531S PHY in YT6801 Ethernet controllerdrivers/ | +4 | 1 reply | Applied |
| 2/3 | net: stmmac: Add glue driver for Motorcomm YT6801 ethernet controllerdrivers/ drivers/ drivers/ | +394 | 3 replies | Applied |
| 3/3 | MAINTAINERS: Assign myself as maintainer of Motorcomm DWMAC glue driverMAINTAINERS | +6 | 0 replies | Applied |
Reviews trailers per patch
2 of 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Andrew Lunn | Mingcong Bai | Runhua He | Xi Ruoyao | Russell King (Oracle) | Sai Krishna | Yao Zi |
|---|---|---|---|---|---|---|---|
| Series | R-b | R-b | |||||
| 1/3 | R-b | R-b | |||||
| 2/3 | T-b | T-b | T-b | R-b | |||
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 7 reviewers.
Cover letter [PATCH RESEND net-next v6 0/3] Add DWMAC glue driver for Motorcomm YT6801
This series adds glue driver for Motorcomm YT6801 PCIe ethernet controller, which is considered mostly compatible with DWMAC-4 IP by inspecting the register layout[1]. It integrates a Motorcomm YT8531S PHY (confirmed by reading PHY ID) and GMII is used to connect the PHY to MAC[2].
The initialization logic of the MAC is mostly based on previous upstream effort for the controller[3] and the Deepin-maintained downstream Linux driver[4] licensed under GPL-2.0 according to its SPDX headers. However, this series is a completely re-write of the previous patch series, utilizing the existing DWMAC4 driver and introducing a glue driver only.
This series only aims to add basic networking functions for the controller, features like WoL, RSS and LED control are omitted for now. Testing is done on i3-4170, it reaches 939Mbps (TX)/933Mbps (RX) on average,
YT6801 TX
Connecting to host 192.168.114.51, port 5201
[ 5] local 192.168.114.50 port 52986 connected to 192.168.114.51 port 5201
[ ID] Interval Transfer Bitrate Retr Cwnd
[ 5] 0.00-1.00 sec 112 MBytes 938 Mbits/sec 0 950 KBytes [ 5] 1.00-2.00 sec 113 MBytes 949 Mbits/sec 0 1.08 MBytes [ 5] 2.00-3.00 sec 112 MBytes 938 Mbits/sec 0 1.08 MBytes [ 5] 3.00-4.00 sec 111 MBytes 932 Mbits/sec 0 1.13 MBytes [ 5] 4.00-5.00 sec 113 MBytes 945 Mbits/sec 0 1.13 MBytes [ 5] 5.00-6.00 sec 112 MBytes 936 Mbits/sec 0 1.13 MBytes [ 5] 6.00-7.00 sec 112 MBytes 942 Mbits/sec 0 1.19 MBytes [ 5] 7.00-8.00 sec 112 MBytes 935 Mbits/sec 0 1.19 MBytes [ 5] 8.00-9.00 sec 113 MBytes 948 Mbits/sec 0 1.19 MBytes [ 5] 9.00-10.00 sec 111 MBytes 931 Mbits/sec 0 1.19 MBytes
YT6801 RX
Connecting to host 192.168.114.50, port 5201
[ 5] local 192.168.114.51 port 41578 connected to 192.168.114.50 port 5201
[ ID] Interval Transfer Bitrate Retr Cwnd
[ 5] 0.00-1.00 sec 113 MBytes 944 Mbits/sec 0 542 KBytes [ 5] 1.00-2.00 sec 111 MBytes 934 Mbits/sec 0 850 KBytes [ 5] 2.00-3.00 sec 111 MBytes 933 Mbits/sec 0 1.01 MBytes [ 5] 3.00-4.00 sec 112 MBytes 943 Mbits/sec 0 1.01 MBytes [ 5] 4.00-5.00 sec 111 MBytes 932 Mbits/sec 0 1.01 MBytes [ 5] 5.00-6.00 sec 111 MBytes 929 Mbits/sec 0 1.01 MBytes [ 5] 6.00-7.00 sec 112 MBytes 937 Mbits/sec 0 1.01 MBytes [ 5] 7.00-8.00 sec 112 MBytes 941 Mbits/sec 0 1.01 MBytes [ 5] 8.00-9.00 sec 111 MBytes 929 Mbits/sec 0 1.01 MBytes [ 5] 9.00-10.00 sec 111 MBytes 932 Mbits/sec 0 1.01 MBytes
My mail provider failed to deliver the original v6 series to the list, sorry for the inconvenience. Thanks for your time and review.
[1]: https://lore.kernel.org/all/[email protected]/
[2]: https://lore.kernel.org/all/[email protected]/
[3]: https://lore.kernel.org/all/[email protected]/
[4]: https://github.com/deepin-community/kernel/tree/dc61248a0e21/drivers/net/ethernet/motorcomm/yt6801
Changed from v5
- PATCH 1: Collect review tags
- PATCH 2: Remove struct device from dwmac_motorcomm_priv, since it's only used during probe.
- Link to v5: https://lore.kernel.org/netdev/[email protected]/
Changed from v4
- PATCH 1: don't set RGMII delay register in GMII mode
- PATCH 2
- Disable ASPM L1 link state to work around problematic PCIe addon cards
- Don't use an extra buffer when reading eFuse patches
- Call eth_random_addr() directly when generating a random MAC is necessary
- Drop unused register field definitions
- Fix indentation for interrupt-moderation-related field definitions
- Link to v4: https://lore.kernel.org/all/[email protected]/
Changed from v3
- Manually register a devres action to call pci_free_irq_vectors(), instead of relying on the obsolete behavior of pci_alloc_irq_vectors().
- Remove redundant call to pci_free_irq_vectors() in remove callback.
- Use my new mail address [email protected] for Sign-off-by and commit author.
- Link to v3: https://lore.kernel.org/netdev/[email protected]/
Changed from v2
- Rebase on top of next-20251124
- Switch to stmmac_plat_dat_alloc() then drop now redundant parameters from motorcomm_default_plat_data()
- Set STMMAC_FLAG_EN_TX_LPI_CLK_PHY_CAP
- Add a comment indicating the possible source of CSR clock
- Link to v2: https://lore.kernel.org/netdev/[email protected]/
Changed from v1
- Drop (original) PATCH 1, add no vendor ID entry to linux/pci_ids.h
- Use PHY_INTERFACE_MODE_GMII instead of PHY_INTERFACE_MODE_INTERNAL
- Drop extra register read in motorcomm_efuse_read_byte()
- Rename EPHY_RESET to EPHY_MDIO_PHY_RESET, add a comment to reflect its function better
- Use the newly-introduced generic PCI suspend/resume routines
- Generate a random MAC address instead of failing to probe when no MAC address is programmed in eFuse (seen on some OEM EVBs).
- Collect Tested-by tags
- Link to v1: https://lore.kernel.org/netdev/[email protected]/
Yao Zi (3):
net: phy: motorcomm: Support YT8531S PHY in YT6801 Ethernet controller
net: stmmac: Add glue driver for Motorcomm YT6801 ethernet controller
MAINTAINERS: Assign myself as maintainer of Motorcomm DWMAC glue
driver
MAINTAINERS | 6 + drivers/net/ethernet/stmicro/stmmac/Kconfig | 9 + drivers/net/ethernet/stmicro/stmmac/Makefile | 1 + .../ethernet/stmicro/stmmac/dwmac-motorcomm.c | 384 ++++++++++++++++++ drivers/net/phy/motorcomm.c | 4 + 5 files changed, 404 insertions(+) create mode 100644 drivers/net/ethernet/stmicro/stmmac/dwmac-motorcomm.c
Signature · 1 line
2.52.0