Skip to content

lib/kms: Carve up igt_display_require()

Ville Syrjala igt-dev 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest11 patches 0 repliesNew
  2. v111 patches 12 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11lib/kms: Extract igt_crtc_init()lib/igt_kms.c+102 -970 replies
2/11lib/kms: Nuke 'n_planes' from igt_crtc_init()lib/igt_kms.c+10 -100 replies
3/11lib/kms: Nuke 'last_plane' from igt_crtc_init()lib/igt_kms.c+4 -60 replies
4/11lib/kms: Get rid of the 'p' plane index variablelib/igt_kms.c+25 -170 replies
5/11lib/kms: Extract igt_crtc_plane_init()lib/igt_kms.c+61 -520 replies
6/11lib/kms: Nuke pipe->plane_primarylib/igt_kms.c lib/igt_kms.h+9 -230 replies
7/11lib/kms: Nuke pipe->plane_cursorlib/igt_kms.c lib/igt_kms.h+2 -50 replies
8/11lib/kms: Use '{old, new}_primary' variable names in plane swappinglib/igt_kms.c+7 -70 replies
9/11lib/kms: Pimp the primary plane swappinglib/igt_kms.c+14 -60 replies
10/11lib/kms: Extract plane_type_index()lib/igt_kms.c+16 -100 replies
11/11lib/kms: Streamline plane index handling furtherlib/igt_kms.c+19 -240 replies

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by.

PatchJani Nikula
1/11R-b
2/11R-b
3/11R-b
4/11R-b
5/11R-b
6/11R-b
7/11R-b
8/11R-b
9/11R-b
10/11R-b
11/11R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH i-g-t v2 00/11] lib/kms: Carve up igt_display_require()

From: Ville Syrjälä <[email protected]>

Coccinelle really doesn't like igt_display_require(). Sometimes it takes approximately forever to do any changes to igt_kms.c because of this. Splitting the function up seems to help a bit, or at least then some modifications can be done in finite time.

While at it try to clean up the plane->index stuff a bit.

v2: Fix plane index asserts
Fix whitespace issues
Fix typos in commit messages

Ville Syrjälä (11):
lib/kms: Extract igt_crtc_init()
lib/kms: Nuke 'n_planes' from igt_crtc_init()
lib/kms: Nuke 'last_plane' from igt_crtc_init() lib/kms: Get rid of the 'p' plane index variable lib/kms: Extract igt_crtc_plane_init()
lib/kms: Nuke pipe->plane_primary
lib/kms: Nuke pipe->plane_cursor
lib/kms: Use '{old,new}_primary' variable names in plane swapping lib/kms: Pimp the primary plane swapping
lib/kms: Extract plane_type_index()
lib/kms: Streamline plane index handling further

 lib/igt_kms.c | 270 ++++++++++++++++++++++++++------------------------
 lib/igt_kms.h |   2 -
 2 files changed, 142 insertions(+), 130 deletions(-)
Signature · 1 line
2.51.2