Skip to content

SDCA System Suspend Support

Charles Keepax linux-sound 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 2 repliesIn review
  2. v24 patches 7 repliesSuperseded

Changes in v3 from the cover letter

- Update some error message capitalisation.
- Update some kernel doc.
- Add a runtime_get to ensure force resume runs the runtime resume.
- Correct detection of system suspend in FDL IRQ.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4ASoC: SDCA: Add SDCA IRQ enable/disable helpersinclude/sound/sdca_interrupts.h sound/soc/sdca/sdca_interrupts.c+83 -00 replies
2/4ASoC: SDCA: Add basic system suspend supportsound/soc/sdca/sdca_class.c sound/soc/sdca/sdca_class_function.c+84 -00 replies
3/4ASoC: SDCA: Device boot into the system suspend processsound/soc/sdca/sdca_class_function.c sound/soc/sdca/sdca_interrupts.c+62 -270 replies
4/4ASoC: SDCA: Add lock to serialise the Function initialisationsound/soc/sdca/sdca_class.c sound/soc/sdca/sdca_class.h sound/soc/sdca/sdca_class_function.c+8 -00 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPierre-Louis Bossart
SeriesR-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] SDCA System Suspend Support

Add support for system suspend into the class driver, now split out into a separate patch chain.

Where we got to on the previous discussion, was we don't currently have any parts requiring download on runtime resume, doing so will add noticeable delay to the runtime resume, and we are not blocking someone from adding support for firmware download on runtime resume in the future. Also as runtime resume is really a kernel concept and power rails are primarily controlled by ACPI it is quite unlikely anyone will actually power down the part on a runtime suspend anyway. So this version of the chain still only downloads firmware on probe and system resume.

Thanks,
Charles

Changes since v2:
- Update some error message capitalisation.
- Update some kernel doc.
- Add a runtime_get to ensure force resume runs the runtime resume.
- Correct detection of system suspend in FDL IRQ.

Changes since v1:
- Update SDCA IRQ enable/disable API to be more clear.

Charles Keepax (4):
ASoC: SDCA: Add SDCA IRQ enable/disable helpers
ASoC: SDCA: Add basic system suspend support
ASoC: SDCA: Device boot into the system suspend process
ASoC: SDCA: Add lock to serialise the Function initialisation

 include/sound/sdca_interrupts.h      |   7 ++
 sound/soc/sdca/sdca_class.c          |  34 ++++++++
 sound/soc/sdca/sdca_class.h          |   2 +
 sound/soc/sdca/sdca_class_function.c | 126 ++++++++++++++++++++++-----
 sound/soc/sdca/sdca_interrupts.c     |  93 ++++++++++++++++++--
 5 files changed, 236 insertions(+), 26 deletions(-)
Signature · 1 line
2.47.3