Skip to content

RFC Update lzma to current version of LZMA SDK

Tom Rini u-boot 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest9 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9lzma: Add Kconfig options to optimize for sizeconfigs/gardena-smart-gateway-mt7688_defconfig lib/Kconfig lib/lzma/Makefile+17 -00 replies
2/9lzma: Remove extra files and explain where our library comes fromlib/Kconfig lib/lzma/README.txt lib/lzma/history.txt +2 more+3 -9350 replies
3/9lzma: Update 9.20 -> 9.22lib/lzma/LzmaDec.c+8 -130 replies
4/9lzma: Update 9.22 -> 9.38include/lzma/LzmaTypes.h lib/lzma/7zC.txt lib/lzma/7zTypes.h +5 more+275 -210 replies
5/9lzma: Update 9.38 -> 18.06lib/lzma/7zTypes.h lib/lzma/Compiler.h lib/lzma/LzmaDec.c +2 more+605 -2850 replies
6/9lzma: Update 18.06 -> 21.07lib/lzma/7zTypes.h lib/lzma/Compiler.h lib/lzma/LzmaDec.c +1 more+482 -1380 replies
7/9lzma: Update 21.07 -> 25.01lib/lzma/7zTypes.h lib/lzma/Compiler.h lib/lzma/LzmaDec.c +3 more+626 -2290 replies
8/9lzma: Restore spacing fixeslib/lzma/7zTypes.h lib/lzma/Compiler.h lib/lzma/LzmaDec.c +2 more+3 -670 replies
9/9lzma: Add SPDX-License-Identifier lineslib/lzma/7zTypes.h lib/lzma/Compiler.h lib/lzma/LzmaDec.c +2 more+5 -00 replies

Reviews trailers per patch

None of the 9 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchStefan Roese
SeriesR-b
1/9
2/9
3/9
4/9
5/9
6/9
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC PATCH 0/9] Update lzma to current version of LZMA SDK

Hey all,

A long while ago, Darek reported that our copy of the LZMA SDK library is quite old and so vulnerable to at least one possible security issue he found that was fixed upstream.

This RFC series does a few things. First, we introduce a Kconfig option to enable LZMA's size reduction option, and enable it on gardena-smart-gateway-mt7688. This is not critical at the start, but is as we move forward. Next, we remove some files from our initial import of the library that do not make sense to keep in-tree. After that, the next 5 patches update us from the imported version to the current release of 25.01. This is split up such that few have the very few places where the update requires some slight changes to our code be more visible. This in turn is mainly that the file that says the license has changed, and that we need to guard around some unused upstream code that also conflicts with our own code. Finally, we restore the spacing changes that our copy of the code had, and then improve things by adding SPDX tags to the LZMA code so the license is more visible overall.

I've marked this as RFC in part because I plan to follow-up with v1 shortly where patches 2 through 8 are squashed together as they're mainly separate right now for ease of review, but the split doesn't make sense I believe to preserve in git as our changes are so isolated.

Signature · 1 line
Tom