Skip to content

Enable cached zone report

Damien Le Moal linux-xfs 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 8 repliesIn review
  2. v23 patches 6 repliesSuperseded
  3. v13 patches 1 replySuperseded

Changes in v3 from the cover letter

- Complete rework of the series to make the zone reporting code common in libfrog
- Added patch 1 and 2 as small cleanups/improvements.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6libxfs: add missing forward declaration in xfs_zones.hlibxfs/xfs_zones.h+1 -02 replies
2/6mkfs: remove unnecessary return value affectationmkfs/xfs_mkfs.c+1 -32 replies
3/6libfrog: introduce xfrog_report_zoneslibfrog/Makefile libfrog/zones.c libfrog/zones.h+59 -21 reply
4/6mkfs: use xfrog_report_zones()mkfs/xfs_mkfs.c+9 -261 reply
5/6repair: use xfrog_report_zones()repair/zoned.c+8 -210 replies
6/6libfrog: enable cached report zoneslibfrog/zones.c libfrog/zones.h libxfs/xfs_zones.c+21 -22 replies

Reviews trailers per patch

1 of 6 patches has a Reviewed-by or Acked-by.

PatchDarrick J. WongChristoph Hellwig
1/6
2/6R-b R-b
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/6] Enable cached zone report

Enable cached zone report to speed up mkfs and repair on a zoned block device (e.g. an SMR disk). Cached zone report support was introduced in the kernel with version 6.19-rc1.

Patch 1 and 2 are a couple of simple fixes/cleanups.
Patch 3 intorduces the new xfrog_report_zones() helper function, which is used in patch 4 and 5 for mkfs and repair respectively. Finally, patch 6 modifies xfrog_report_zones() to enable cached report zones.

Changes from v2:
- Complete rework of the series to make the zone reporting code common in libfrog
- Added patch 1 and 2 as small cleanups/improvements.

Changes from v1:
- Fix erroneous handling of ioctl(BLKREPORTZONEV2) error to correctly fallback to the regular ioctl(BLKREPORTZONE) if the kernel does not support BLKREPORTZONEV2.

Damien Le Moal (6):
libxfs: add missing forward declaration in xfs_zones.h
mkfs: remove unnecessary return value affectation
libfrog: introduce xfrog_report_zones
mkfs: use xfrog_report_zones()
repair: use xfrog_report_zones()
libfrog: enable cached report zones

 libfrog/Makefile   |  6 ++++--
 libfrog/zones.c    | 51 ++++++++++++++++++++++++++++++++++++++++++++++
 libfrog/zones.h    | 22 ++++++++++++++++++++
 libxfs/xfs_zones.c |  3 ++-
 libxfs/xfs_zones.h |  1 +
 mkfs/xfs_mkfs.c    | 39 +++++++++--------------------------
 repair/zoned.c     | 29 ++++++++------------------
 7 files changed, 98 insertions(+), 53 deletions(-)
 create mode 100644 libfrog/zones.c
 create mode 100644 libfrog/zones.h
Signature · 1 line
2.52.0