IPU6 driver cleanups and fixes
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest14 patches 13 repliesIn review
- v313 patches 11 repliesSuperseded
- v213 patches 0 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 13 patches | 7 replies | Superseded |
Changes in v4 from the cover letter
- Also drop redundant calls of ipu6_mmu_hw_cleanup() in MMU hardware init cleanup patch.
- Improved description of removing redundant streaming start mechanism.
- Always call close_streaming_firmware(), even if disabling streaming on upstream sub-device fails.
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/14 | media: ipu6: Ensure stream_mutex is acquired when dealing with node listdrivers/ | +5 | 0 replies | |
| 2/14 | media: ipu6: Drop MMU hardware initialisation in probe()drivers/ | +0 | 1 reply | |
| 3/14 | media: ipu6: Remove redundant driver data checksdrivers/ | +1 | 1 reply | |
| 4/14 | media: ipu6: Make symbols staticdrivers/ drivers/ | +2 | 1 reply | |
| 5/14 | media: ipu6: Remove redundant streaming start via buffer queueingdrivers/ | +0 | 0 replies | |
| 6/14 | media: ipu6: Don't check pipeline in stream_startdrivers/ | +2 | 1 reply | |
| 7/14 | media: ipu6: Close firmware streams on streaming enable failuredrivers/ | +1 | 1 reply | |
| 8/14 | media: ipu6: Always close firmware streamdrivers/ | +2 | 1 reply | |
| 9/14 | media: ipu6: Drop error argument from ipu6_isys_stream_start()drivers/ drivers/ | +3 | 1 reply | |
| 10/14 | media: ipu6: Obtain remote pad using media_pad_remote_pad_unique()drivers/ | +1 | 1 reply | |
| 11/14 | media: ipu6: Obtain unique source pad from remote sub-devicedrivers/ | +3 | 3 replies | |
| 12/14 | media: ipu6: Remove source_entity from struct ipu6_isys_streamdrivers/ drivers/ drivers/ | +31 | 0 replies | |
| 13/14 | media: ipu6: Drop custom functions to obtain sd state informationdrivers/ drivers/ drivers/ +1 more | +24 | 1 reply | |
| 14/14 | media: ipu6: Always call video_device_pipeline_alloc_start()drivers/ drivers/ | +1 | 0 replies |
Reviews trailers per patch
10 of 14 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Bingbu Cao | Mehdi Djait |
|---|---|---|
| Series | T-b R-b | |
| 1/14 | ||
| 2/14 | R-b | |
| 3/14 | R-b R-b | |
| 4/14 | R-b R-b | |
| 5/14 | ||
| 6/14 | R-b | |
| 7/14 | R-b | |
| 8/14 | R-b | |
| 9/14 | R-b | |
| 10/14 | R-b | |
| 11/14 | R-b | |
| 12/14 | ||
| 13/14 | R-b | |
| 14/14 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 00/14] IPU6 driver cleanups and fixes
Hello all,
This small set contains cleanups and fixes for the IPU6 driver. I'm preparing a larger set of improvements in the IPU6 driver on top of the metadata series (I'll post an update soonish) so consider this to be preparation for that.
since v3:
- Also drop redundant calls of ipu6_mmu_hw_cleanup() in MMU hardware init cleanup patch.
- Improved description of removing redundant streaming start mechanism.
- Always call close_streaming_firmware(), even if disabling streaming on upstream sub-device fails.
since v2:
- Factor in Mehdi's comments:
- Rework commit message of "media: ipu6: Remove redundant streaming start via buffer queueing" patch a little.
- Also remove IPU6_ISYS_BUFFER_LIST_FL_SET_STATE flag (patch "media:
ipu6: Drop error argument from ipu6_isys_stream_start()").
since v1:
- Fix some intra-set compilation breakage and remove a now-redundant variable.
- Fix missing assignment of ret in ipu6_isys_link_fmt_validate() (includes a cleanup, too).
Sakari Ailus (14):
media: ipu6: Ensure stream_mutex is acquired when dealing with node
list
media: ipu6: Drop MMU hardware initialisation in probe()
media: ipu6: Remove redundant driver data checks
media: ipu6: Make symbols static
media: ipu6: Remove redundant streaming start via buffer queueing
media: ipu6: Don't check pipeline in stream_start
media: ipu6: Close firmware streams on streaming enable failure
media: ipu6: Always close firmware stream
media: ipu6: Drop error argument from ipu6_isys_stream_start()
media: ipu6: Obtain remote pad using media_pad_remote_pad_unique()
media: ipu6: Obtain unique source pad from remote sub-device
media: ipu6: Remove source_entity from struct ipu6_isys_stream
media: ipu6: Drop custom functions to obtain sd state information
media: ipu6: Always call video_device_pipeline_alloc_start()
drivers/media/pci/intel/ipu6/ipu6-isys-csi2.c | 2 +- .../media/pci/intel/ipu6/ipu6-isys-queue.c | 73 ++++++++------- .../media/pci/intel/ipu6/ipu6-isys-queue.h | 1 - .../media/pci/intel/ipu6/ipu6-isys-subdev.c | 36 -------- .../media/pci/intel/ipu6/ipu6-isys-subdev.h | 4 - .../media/pci/intel/ipu6/ipu6-isys-video.c | 88 ++++++------------- .../media/pci/intel/ipu6/ipu6-isys-video.h | 6 +- drivers/media/pci/intel/ipu6/ipu6-isys.c | 21 +---- drivers/media/pci/intel/ipu6/ipu6-isys.h | 2 - 9 files changed, 73 insertions(+), 160 deletions(-)
Signature · 1 line
2.47.3