Skip to content

IPU6 driver cleanups and fixes

Sakari Ailus linux-media 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest14 patches 13 repliesIn review
  2. v313 patches 11 repliesSuperseded
  3. v213 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v113 patches7 repliesSuperseded

Changes in v4 from the cover letter

- Also drop redundant calls of ipu6_mmu_hw_cleanup() in MMU hardware init cleanup patch.

- Improved description of removing redundant streaming start mechanism.

- Always call close_streaming_firmware(), even if disabling streaming on upstream sub-device fails.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14media: ipu6: Ensure stream_mutex is acquired when dealing with node listdrivers/media/pci/intel/ipu6/ipu6-isys-queue.c+5 -30 replies
2/14media: ipu6: Drop MMU hardware initialisation in probe()drivers/media/pci/intel/ipu6/ipu6-isys.c+0 -81 reply
3/14media: ipu6: Remove redundant driver data checksdrivers/media/pci/intel/ipu6/ipu6-isys.c+1 -81 reply
4/14media: ipu6: Make symbols staticdrivers/media/pci/intel/ipu6/ipu6-isys.c drivers/media/pci/intel/ipu6/ipu6-isys.h+2 -41 reply
5/14media: ipu6: Remove redundant streaming start via buffer queueingdrivers/media/pci/intel/ipu6/ipu6-isys-queue.c+0 -70 replies
6/14media: ipu6: Don't check pipeline in stream_startdrivers/media/pci/intel/ipu6/ipu6-isys-queue.c+2 -41 reply
7/14media: ipu6: Close firmware streams on streaming enable failuredrivers/media/pci/intel/ipu6/ipu6-isys-video.c+1 -01 reply
8/14media: ipu6: Always close firmware streamdrivers/media/pci/intel/ipu6/ipu6-isys-video.c+2 -31 reply
9/14media: ipu6: Drop error argument from ipu6_isys_stream_start()drivers/media/pci/intel/ipu6/ipu6-isys-queue.c drivers/media/pci/intel/ipu6/ipu6-isys-queue.h+3 -101 reply
10/14media: ipu6: Obtain remote pad using media_pad_remote_pad_unique()drivers/media/pci/intel/ipu6/ipu6-isys-csi2.c+1 -11 reply
11/14media: ipu6: Obtain unique source pad from remote sub-devicedrivers/media/pci/intel/ipu6/ipu6-isys-video.c+3 -33 replies
12/14media: ipu6: Remove source_entity from struct ipu6_isys_streamdrivers/media/pci/intel/ipu6/ipu6-isys-queue.c drivers/media/pci/intel/ipu6/ipu6-isys-video.c drivers/media/pci/intel/ipu6/ipu6-isys-video.h+31 -390 replies
13/14media: ipu6: Drop custom functions to obtain sd state informationdrivers/media/pci/intel/ipu6/ipu6-isys-queue.c drivers/media/pci/intel/ipu6/ipu6-isys-subdev.c drivers/media/pci/intel/ipu6/ipu6-isys-subdev.h +1 more+24 -661 reply
14/14media: ipu6: Always call video_device_pipeline_alloc_start()drivers/media/pci/intel/ipu6/ipu6-isys-queue.c drivers/media/pci/intel/ipu6/ipu6-isys-video.c+1 -70 replies

Reviews trailers per patch

10 of 14 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchBingbu CaoMehdi Djait
SeriesT-b R-b
1/14
2/14R-b
3/14R-b R-b
4/14R-b R-b
5/14
6/14R-b
7/14R-b
8/14R-b
9/14R-b
10/14R-b
11/14R-b
12/14
13/14R-b
14/14

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 00/14] IPU6 driver cleanups and fixes

Hello all,

This small set contains cleanups and fixes for the IPU6 driver. I'm preparing a larger set of improvements in the IPU6 driver on top of the metadata series (I'll post an update soonish) so consider this to be preparation for that.

since v3:

- Also drop redundant calls of ipu6_mmu_hw_cleanup() in MMU hardware init cleanup patch.

- Improved description of removing redundant streaming start mechanism.

- Always call close_streaming_firmware(), even if disabling streaming on upstream sub-device fails.

since v2:

- Factor in Mehdi's comments:

- Rework commit message of "media: ipu6: Remove redundant streaming start via buffer queueing" patch a little.

- Also remove IPU6_ISYS_BUFFER_LIST_FL_SET_STATE flag (patch "media:
ipu6: Drop error argument from ipu6_isys_stream_start()").

since v1:

- Fix some intra-set compilation breakage and remove a now-redundant variable.

- Fix missing assignment of ret in ipu6_isys_link_fmt_validate() (includes a cleanup, too).

Sakari Ailus (14):
media: ipu6: Ensure stream_mutex is acquired when dealing with node
list
media: ipu6: Drop MMU hardware initialisation in probe()
media: ipu6: Remove redundant driver data checks
media: ipu6: Make symbols static
media: ipu6: Remove redundant streaming start via buffer queueing
media: ipu6: Don't check pipeline in stream_start
media: ipu6: Close firmware streams on streaming enable failure
media: ipu6: Always close firmware stream
media: ipu6: Drop error argument from ipu6_isys_stream_start()
media: ipu6: Obtain remote pad using media_pad_remote_pad_unique()
media: ipu6: Obtain unique source pad from remote sub-device
media: ipu6: Remove source_entity from struct ipu6_isys_stream
media: ipu6: Drop custom functions to obtain sd state information
media: ipu6: Always call video_device_pipeline_alloc_start()

 drivers/media/pci/intel/ipu6/ipu6-isys-csi2.c |  2 +-
 .../media/pci/intel/ipu6/ipu6-isys-queue.c    | 73 ++++++++-------
 .../media/pci/intel/ipu6/ipu6-isys-queue.h    |  1 -
 .../media/pci/intel/ipu6/ipu6-isys-subdev.c   | 36 --------
 .../media/pci/intel/ipu6/ipu6-isys-subdev.h   |  4 -
 .../media/pci/intel/ipu6/ipu6-isys-video.c    | 88 ++++++-------------
 .../media/pci/intel/ipu6/ipu6-isys-video.h    |  6 +-
 drivers/media/pci/intel/ipu6/ipu6-isys.c      | 21 +----
 drivers/media/pci/intel/ipu6/ipu6-isys.h      |  2 -
 9 files changed, 73 insertions(+), 160 deletions(-)
Signature · 1 line
2.47.3