mm/vmscan: fix demotion targets checks in reclaim/demotion
Status from this message: [merged mm-stable] mm-vmscan-select-the-closest-perferred-node-in-demote_folio_list.patch removed from -mm tree
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v9 Latest2 patches 6 repliesApplied 2/2
- v72 patches 0 repliesSuperseded
- v61 patch 3 repliesSuperseded
Earlier versions · 5
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v5 | 1 patch | 2 replies | Superseded | |
| v4 | 1 patch | 4 replies | Superseded | |
| v3 | 1 patch | 9 replies | Superseded | |
| v2 | 2 patches | 4 replies | Superseded | |
| v1 | 1 patch | 4 replies | Superseded |
Patches in v9 All 2 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | mm/vmscan: fix demotion targets checks in reclaim/demotioninclude/ include/ kernel/ +2 more | +78 | 1 reply | Applied |
| 2/2 | mm/vmscan: select the closest perferred node in demote_folio_list()include/ mm/ mm/ | +21 | 1 reply | Applied |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Shakeel Butt |
|---|---|
| 1/2 | A-b |
| 2/2 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v9 0/2] mm/vmscan: fix demotion targets checks in reclaim/demotion
This patch series addresses two issues in demote_folio_list(), can_demote(), and next_demotion_node() in reclaim/demotion.
1. demote_folio_list() and can_demote() do not correctly check demotion target against cpuset.mems_effective, which will cause (a) pages are demoted to not-allowed nodes and (b) pages are failed to demote even if the system still have allowed demotion nodes.
Patch 1 fixes this bug by update cpuset_node_allowed() and mem_cgroup_node_allowed() to return effective_mems, allowing directly logic-and operation against demotion targets.
2. next_demotion_node() returns a preferred demotion target, but it does check the node against allowed nodes.
Patch 2 ensures that next_demotion_node() filters against the allowed node mask and selects the closest demotion target to the source node.
===
Hi Andrew,
Sorry for the extra noise in your inbox.
I’m resubmitting the full refreshed patch series together this time. I just realized it is better to include the unmodified patches alongside the modified ones to ensure compatibility with upstream automated tools and to simplify your review process.
The refreshed patch series replaces some commits in mm-untable, including:
- Commit 809cc3db1831 ("mm/vmscan: fix demotion targets checks in reclaim/demotion")
- Commit fd8cb9a8cedc ("mm/vmscan: select the closest preferred node in demote_folio_list()")
- Commit 127714c76c46 ("mm/vmscan: fix uninitialized variable in
demote_folio_list()")
Thanks!
Best regards,
Bing
Bing Jiao (2):
mm/vmscan: fix demotion targets checks in reclaim/demotion mm/vmscan: select the closest perferred node in demote_folio_list()
include/linux/cpuset.h | 6 ++-- include/linux/memcontrol.h | 6 ++-- include/linux/memory-tiers.h | 6 ++-- kernel/cgroup/cpuset.c | 54 ++++++++++++++++++++++++------------ mm/memcontrol.c | 16 +++++++++-- mm/memory-tiers.c | 21 ++++++++++---- mm/vmscan.c | 31 +++++++++++++-------- 7 files changed, 95 insertions(+), 45 deletions(-)
--
2.52.0.457.g6b5491de43-goog