Skip to content

rm/i915/dp: Clean up link BW/DSC slice config computation (link BW)

Imre Deak intel-gfx intel-xe 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest19 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19drm/i915/dp: Drop unused timeslots param from dsc_compute_link_config()drivers/gpu/drm/i915/display/intel_dp.c+7 -110 replies
2/19drm/i915/dp: Factor out align_max_sink_dsc_input_bpp()drivers/gpu/drm/i915/display/intel_dp.c+18 -100 replies
3/19drm/i915/dp: Factor out align_max_vesa_compressed_bpp_x16()drivers/gpu/drm/i915/display/intel_dp.c+20 -150 replies
4/19drm/i915/dp: Align min/max DSC input BPPs to sink capsdrivers/gpu/drm/i915/display/intel_dp.c+23 -20 replies
5/19drm/i915/dp: Align min/max compressed BPPs when calculating BPP limitsdrivers/gpu/drm/i915/display/intel_dp.c+57 -00 replies
6/19drm/i915/dp: Drop intel_dp parameter from intel_dp_compute_config_link_bpp_limits()drivers/gpu/drm/i915/display/intel_dp.c+4 -50 replies
7/19drm/i915/dp: Pass intel_output_format to intel_dp_dsc_sink_{min_max}_compressed_bpp()drivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_dp.h+12 -160 replies
8/19drm/i915/dp: Pass mode clock to dsc_throughput_quirk_max_bpp_x16()drivers/gpu/drm/i915/display/intel_dp.c+4 -60 replies
9/19drm/i915/dp: Factor out compute_min_compressed_bpp_x16()drivers/gpu/drm/i915/display/intel_dp.c+18 -80 replies
10/19drm/i915/dp: Factor out compute_max_compressed_bpp_x16()drivers/gpu/drm/i915/display/intel_dp.c+49 -330 replies
11/19drm/i915/dp: Add intel_dp_mode_valid_with_dsc()drivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_dp.h drivers/gpu/drm/i915/display/intel_dp_mst.c+57 -360 replies
12/19drm/i915/dp: Unify detect and compute time DSC mode BW validationdrivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_dp.h+18 -1270 replies
13/19drm/i915/dp: Use helpers to align min/max compressed BPPsdrivers/gpu/drm/i915/display/intel_dp.c+5 -180 replies
14/19drm/i915/dp: Simplify computing DSC BPPs for eDPdrivers/gpu/drm/i915/display/intel_dp.c+3 -130 replies
15/19drm/i915/dp: Simplify computing DSC BPPs for DP-SSTdrivers/gpu/drm/i915/display/intel_dp.c+8 -210 replies
16/19drm/i915/dp: Simplify computing forced DSC BPP for DP-SSTdrivers/gpu/drm/i915/display/intel_dp.c+4 -100 replies
17/19drm/i915/dp: Unify computing compressed BPP for DP-SST and eDPdrivers/gpu/drm/i915/display/intel_dp.c+13 -80 replies
18/19drm/i915/dp: Simplify eDP vs. DP compressed BPP computationdrivers/gpu/drm/i915/display/intel_dp.c+2 -300 replies
19/19drm/i915/dp: Simplify computing the DSC compressed BPP for DP-MSTdrivers/gpu/drm/i915/display/intel_dp_mst.c+6 -420 replies

Reviews trailers per patch

All 19 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchLuca CoelhoVinod GovindapillaiJouni Högander
SeriesR-b
1/19R-b
2/19R-b R-b
3/19R-b R-b
4/19R-b
5/19R-b
6/19R-b
7/19R-b
8/19R-b
9/19R-b
10/19R-b
11/19R-b
12/19R-b
13/19R-b
14/19R-b
15/19R-b
16/19R-b
17/19R-b
18/19R-b
19/19R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 00/19] rm/i915/dp: Clean up link BW/DSC slice config computation (link BW)

This is the second part of patchset [1] containing the refactoring (patches 13-15, 20-35) of the link BW computation to simplify it. The first part of [1] containing fixes is merged now to drm-tip, see [2], the third part of [1] refactoring the DSC slice computation is to be sent as a follow-up to this patchset.

[1] https://lore.kernel.org/all/[email protected]
[2] https://lore.kernel.org/all/[email protected]

Cc Ankit Nautiyal <[email protected]>
Cc Luca Coelho <[email protected]>
Cc Jouni Högander <[email protected]>
Cc Vinod Govindapillai <[email protected]>

Imre Deak (19):
drm/i915/dp: Drop unused timeslots param from
dsc_compute_link_config()
drm/i915/dp: Factor out align_max_sink_dsc_input_bpp() drm/i915/dp: Factor out align_max_vesa_compressed_bpp_x16() drm/i915/dp: Align min/max DSC input BPPs to sink caps drm/i915/dp: Align min/max compressed BPPs when calculating BPP limits drm/i915/dp: Drop intel_dp parameter from
intel_dp_compute_config_link_bpp_limits()
drm/i915/dp: Pass intel_output_format to
intel_dp_dsc_sink_{min_max}_compressed_bpp()
drm/i915/dp: Pass mode clock to dsc_throughput_quirk_max_bpp_x16() drm/i915/dp: Factor out compute_min_compressed_bpp_x16() drm/i915/dp: Factor out compute_max_compressed_bpp_x16() drm/i915/dp: Add intel_dp_mode_valid_with_dsc() drm/i915/dp: Unify detect and compute time DSC mode BW validation drm/i915/dp: Use helpers to align min/max compressed BPPs drm/i915/dp: Simplify computing DSC BPPs for eDP drm/i915/dp: Simplify computing DSC BPPs for DP-SST drm/i915/dp: Simplify computing forced DSC BPP for DP-SST drm/i915/dp: Unify computing compressed BPP for DP-SST and eDP drm/i915/dp: Simplify eDP vs. DP compressed BPP computation drm/i915/dp: Simplify computing the DSC compressed BPP for DP-MST

 drivers/gpu/drm/i915/display/intel_dp.c     | 515 +++++++++-----------
 drivers/gpu/drm/i915/display/intel_dp.h     |  17 +-
 drivers/gpu/drm/i915/display/intel_dp_mst.c |  77 +--
 3 files changed, 263 insertions(+), 346 deletions(-)
Signature · 1 line
2.49.1