platform/x86: asus-wmi: move keyboard control firmware attributes
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest3 patches 7 repliesIn review
- v33 patches 1 replySuperseded
- v23 patches 0 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 3 patches | 11 replies | Superseded |
Changelog from the cover letter
- v1
- Initial submission
- v2
- asus-armoury: drivers should be silent on success
- asus-armoury: make better use of __free annotation
- v3
- asus-wmi: use GENMASK for flags
- asus-armoury: fix error handling in keyboard attribute creation
- asus-armoury: fix logic bug in error path
- asus-armoury: use proper defines for keyboard state flags
- v4
- asus-armoury: reorder variable declarations
- asus-armoury: add bitfields.h include for BIT and FIELD_PREP
- asus-armoury: reorganize armoury_kbd_state() for clarity
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | platform/x86: asus-wmi: explicitly mark more code with CONFIG_ASUS_WMI_DEPRECATED_ATTRSdrivers/ | +10 | 0 replies | |
| 2/3 | platform/x86: asus-wmi: fix sending OOBE at probedrivers/ | +2 | 0 replies | |
| 3/3 | platform/x86: asus-armoury: add keyboard control firmware attributesdrivers/ include/ | +271 | 0 replies |
Reviews trailers per patch
None of the 3 patches has a Reviewed-by or Acked-by.
| Patch | Merthan Karakaş |
|---|---|
| 1/3 | |
| 2/3 | |
| 3/3 | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/3] platform/x86: asus-wmi: move keyboard control firmware attributes
Hi all,
I was recently reading through the asusctl issue tracker and I found out that some users have been having troubles with the keyboard RGB control that was working before since the creation of asus-armoury and subequent deprecation of old sysfs attributes.
This patch series aims to re-introduce those attributes in asus-armoury so that userspace tools can still control keyboard RGB lighting without having to rely on deprecated asus-wmi attributes.
In addition to that, since disabling OOBE is essential for controlling LEDs on some models and it was incorrectly tied to deprecated attributes, this patch series also fixes sending OOBE at probe time.
Regards,
Denis
Changelog:
- v1
- Initial submission
- v2
- asus-armoury: drivers should be silent on success
- asus-armoury: make better use of __free annotation
- v3
- asus-wmi: use GENMASK for flags
- asus-armoury: fix error handling in keyboard attribute creation
- asus-armoury: fix logic bug in error path
- asus-armoury: use proper defines for keyboard state flags
- v4
- asus-armoury: reorder variable declarations
- asus-armoury: add bitfields.h include for BIT and FIELD_PREP
- asus-armoury: reorganize armoury_kbd_state() for clarity
Denis Benato (3):
platform/x86: asus-wmi: explicitly mark more code with
CONFIG_ASUS_WMI_DEPRECATED_ATTRS
platform/x86: asus-wmi: fix sending OOBE at probe platform/x86: asus-armoury: add keyboard control firmware attributes
drivers/platform/x86/asus-armoury.c | 253 +++++++++++++++++++++ drivers/platform/x86/asus-wmi.c | 13 +- include/linux/platform_data/x86/asus-wmi.h | 18 ++ 3 files changed, 283 insertions(+), 1 deletion(-)
Signature · 1 line
2.52.0