Skip to content

Avoid using perror

Stephen Hemminger dpdk-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4checkpatches: warn if perror is useddevtools/checkpatches.sh+1 -10 replies
2/4bus/dpaa: replace perror with logdrivers/bus/dpaa/base/qbman/process.c+4 -40 replies
3/4telemetry: replace perror with loglib/telemetry/telemetry.c+2 -21 reply
4/4common/dpaax: replace use of perror with logdrivers/common/dpaax/dpaa_of.c+1 -10 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchBruce Richardson
1/4
2/4
3/4A-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] Avoid using perror

The DPDK uses its own logging library exclusively and drivers and libraries should not be printing directly. One function that was missed was perror() and some code was using it.

This series adds a checkpatch warning and fixes the places that were using it.

Stephen Hemminger (4):
checkpatches: warn if perror is used
bus/dpaa: replace perror with log
telemetry: replace perror with log
common/dpaax: replace use of perror with log

 devtools/checkpatches.sh              | 2 +-
 drivers/bus/dpaa/base/qbman/process.c | 8 ++++----
 drivers/common/dpaax/dpaa_of.c        | 2 +-
 lib/telemetry/telemetry.c             | 4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)
Signature · 1 line
2.51.0