Sigmastar DT warnings fixing
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest8 patches 2 repliesIn review
- v15 patches 7 repliesSuperseded
Changes in v2 from the cover letter
- Fix the regulator names as suggested by Krzysztof
- Adjust the opp table name
- Add a commit to fix the cpupll binding and clean up the warnings for that
- Add a commit to fix the memory node in the infinity2m dtsi to fix up the warnings about that.
- Add a commit to switch the default led trigger on breadbee from the undocumented activity to cpu to fix up the warnings for the that.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | dt-bindings: clk: mstar msc313 cpupll: Correct clock-cells valueDocumentation/ | +2 | 2 replies | |
| 2/8 | arm: dts: mstar: breadbee: Correct regulator namesarch/ | +3 | 0 replies | |
| 3/8 | arm: dts: mstar: breadbee: Correct LED namesarch/ | +2 | 0 replies | |
| 4/8 | arm: dts: mstar: breadbee: Switch from "activity" led trigger to "cpu"arch/ | +1 | 0 replies | |
| 5/8 | arm: dts: mstar: infinity: Correct opp table namearch/ | +1 | 0 replies | |
| 6/8 | arm: dts: mstar: infinity2m: ssd202d: Correct memory node namearch/ | +1 | 0 replies | |
| 7/8 | arm: dts: mstar: v7: Move the reboot nodearch/ | +7 | 0 replies | |
| 8/8 | arm: dts: mstar: v7: Add sizes and ranges to sramarch/ | +3 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 0/8] Sigmastar DT warnings fixing
v2 heads up: I didn't ignore Krzysztof's request to squash some commits, I wasn't sure what to squash and I thought since I've fixed everything now it was better to send a v2 sooner than later.
I've now fixed all of the warnings except one remaining one that seems to need a change in dt-schema itself to cleanup:
serial@221000 (ns16550a): reg-shift: 3 is not one of [0, 1, 2]
from schema $id: http://devicetree.org/schemas/reg.yaml
The way registers are connected in these chips is weird. I think they took their peripheral block from an 8051 microcontroller and jammed it onto 32bit CPUs so all of the registers have weird spacing and it really does need reg-shift == 3.
v1 blurb:
I saw a slide at LPC that had sigmastar in the "hall of shame" for DT warnings. I finally got some time to look at this so I have fixed the ones that are obvious and quick to fix.
I'll fix the rest but they might take a bit longer i.e. one of them is about the register shift for the UART registers, that'll need the binding to be updated I think?
FWIW this platform isn't dead and I have been rebasing all of the out of tree stuff that make it useful (Audio support, display, hardware video decoding etc) but its basically stuck on rewriting the clock driver so that it is mainline-able.
Some other people have taken the limited support in mainline and my out of tree stuff and made it run on old MStar MIPS machines too..
change log:
v2:
- Fix the regulator names as suggested by Krzysztof
- Adjust the opp table name
- Add a commit to fix the cpupll binding and clean up the warnings for that
- Add a commit to fix the memory node in the infinity2m dtsi to fix up the warnings about that.
- Add a commit to switch the default led trigger on breadbee from the undocumented activity to cpu to fix up the warnings for the that.
Daniel Palmer (8):
dt-bindings: clk: mstar msc313 cpupll: Correct clock-cells value
arm: dts: mstar: breadbee: Correct regulator names
arm: dts: mstar: breadbee: Correct LED names
arm: dts: mstar: breadbee: Switch from "activity" led trigger to "cpu"
arm: dts: mstar: infinity: Correct opp table name
arm: dts: mstar: infinity2m: ssd202d: Correct memory node name
arm: dts: mstar: v7: Move the reboot node
arm: dts: mstar: v7: Add sizes and ranges to sram
.../bindings/clock/mstar,msc313-cpupll.yaml | 5 ++--- .../mstar-infinity-breadbee-common.dtsi | 12 ++++++------ arch/arm/boot/dts/sigmastar/mstar-infinity.dtsi | 2 +- .../dts/sigmastar/mstar-infinity2m-ssd202d.dtsi | 2 +- arch/arm/boot/dts/sigmastar/mstar-v7.dtsi | 17 ++++++++++------- 5 files changed, 20 insertions(+), 18 deletions(-)
Signature · 1 line
2.51.0