Skip to content

staging: fbtft: reduce stack usage by avoiding large write_reg() varargs

Sun Jian dri-devel linux-fbdev linux-staging 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4staging: fbtft: core: avoid large stack usage in DT init parsingdrivers/staging/fbtft/fbtft-core.c+13 -194 replies
2/4staging: fbtft: ssd1351: send gamma table via fbtft_write_buf_dc()drivers/staging/fbtft/fb_ssd1351.c+15 -202 replies
3/4staging: fbtft: ssd1331: send gamma table via fbtft_write_buf_dc()drivers/staging/fbtft/fb_ssd1331.c+15 -140 replies
4/4staging: fbtft: hx8353d: send LUT via buffer to reduce stack usagedrivers/staging/fbtft/fb_hx8353d.c+28 -101 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH v1 0/4] staging: fbtft: reduce stack usage by avoiding large write_reg() varargs

Hi,

This series fixes clang -Wframe-larger-than=1024 warnings in the fbtft staging drivers.

The warnings are triggered by very large write_reg()/write_register() varargs calls, which result in excessive stack usage.

Switch the affected paths to send a u8 command byte followed by the u8 payload using fbtft_write_buf_dc(). The register values and ordering are kept unchanged; only the transfer method is updated.

Patches:
1/4 staging: fbtft: core: avoid large stack usage in DT init parsing 2/4 staging: fbtft: ssd1351: send gamma table via fbtft_write_buf_dc() 3/4 staging: fbtft: ssd1331: send gamma table via fbtft_write_buf_dc() 4/4 staging: fbtft: hx8353d: send LUT via buffer to reduce stack usage

Thanks,
Sun Jian

--
Sun Jian (4):
staging: fbtft: core: avoid large stack usage in DT init parsing
staging: fbtft: ssd1351: send gamma table via fbtft_write_buf_dc()
staging: fbtft: ssd1331: send gamma table via fbtft_write_buf_dc()
staging: fbtft: hx8353d: send LUT via buffer to reduce stack usage

 drivers/staging/fbtft/fb_hx8353d.c | 38 ++++++++++++++++++++++--------
 drivers/staging/fbtft/fb_ssd1331.c | 29 ++++++++++++-----------
 drivers/staging/fbtft/fb_ssd1351.c | 35 ++++++++++++---------------
 drivers/staging/fbtft/fbtft-core.c | 32 ++++++++++---------------
 4 files changed, 71 insertions(+), 63 deletions(-)
Signature · 1 line
2.43.0