tools: ynl: clean up pylint issues
Status from this message: This series was applied to netdev/net-next.git (main)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest13 patches 0 repliesApplied 13/13
- v113 patches 2 repliesSuperseded
Changes in v2 from the cover letter
- Fix f-string compatibility with python 3.9, thanks Jakub
- Fix AI review comments
Patches in v2 All 13 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/13 | tools: ynl: pylint suppressions and docstringstools/ tools/ tools/ +2 more | +45 | 0 replies | Applied |
| 2/13 | tools: ynl: fix pylint redefinition, encoding errorstools/ tools/ tools/ | +58 | 0 replies | Applied |
| 3/13 | tools: ynl: fix pylint exception warningstools/ tools/ tools/ +1 more | +52 | 0 replies | Applied |
| 4/13 | tools: ynl: fix pylint dict, indentation, long lines, uninitialisedtools/ tools/ | +29 | 0 replies | Applied |
| 5/13 | tools: ynl: fix pylint misc warningstools/ tools/ tools/ | +12 | 0 replies | Applied |
| 6/13 | tools: ynl: fix pylint global variable related warningstools/ tools/ | +17 | 0 replies | Applied |
| 7/13 | tools: ynl: fix logic errors reported by pylinttools/ | +2 | 0 replies | Applied |
| 8/13 | tools: ynl: ethtool: fix pylint issuestools/ | +31 | 0 replies | Applied |
| 9/13 | tools: ynl: fix pylint issues in ynl_gen_rsttools/ | +2 | 0 replies | Applied |
| 10/13 | tools: ynl-gen-c: suppress unhelpful pylint messagestools/ | +11 | 0 replies | Applied |
| 11/13 | tools: ynl-gen-c: fix pylint warnings for returns, unused, redefinedtools/ | +52 | 0 replies | Applied |
| 12/13 | tools: ynl-gen-c: fix pylint None, type, dict, generators, inittools/ | +27 | 0 replies | Applied |
| 13/13 | tools: ynl-gen-c: Fix remaining pylint warningstools/ | +10 | 0 replies | Applied |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH net-next v2 00/13] tools: ynl: clean up pylint issues
pylint tools/net/ynl/pyynl reports >850 issues, with a rating of 8.59/10. It's hard to spot new issues or genuine code smells in all that noise.
Fix the easily fixable issues and suppress the noisy warnings.
pylint tools/net/ynl/pyynl ************* Module pyynl.ethtool tools/net/ynl/pyynl/ethtool.py:159:5: W0511: TODO: --show-tunnels tunnel-info-get (fixme) tools/net/ynl/pyynl/ethtool.py:160:5: W0511: TODO: --show-module module-get (fixme) tools/net/ynl/pyynl/ethtool.py:161:5: W0511: TODO: --get-plca-cfg plca-get (fixme) tools/net/ynl/pyynl/ethtool.py:162:5: W0511: TODO: --get-plca-status plca-get-status (fixme) tools/net/ynl/pyynl/ethtool.py:163:5: W0511: TODO: --show-mm mm-get (fixme) tools/net/ynl/pyynl/ethtool.py:164:5: W0511: TODO: --show-fec fec-get (fixme) tools/net/ynl/pyynl/ethtool.py:165:5: W0511: TODO: --dump-module-eerpom module-eeprom-get (fixme) tools/net/ynl/pyynl/ethtool.py:166:5: W0511: TODO: pse-get (fixme) tools/net/ynl/pyynl/ethtool.py:167:5: W0511: TODO: rss-get (fixme) tools/net/ynl/pyynl/ethtool.py:179:9: W0511: TODO: parse the bitmask (fixme) tools/net/ynl/pyynl/ethtool.py:196:9: W0511: TODO: parse the bitmask (fixme) tools/net/ynl/pyynl/ethtool.py:321:9: W0511: TODO: pass id? (fixme) tools/net/ynl/pyynl/ethtool.py:330:17: W0511: TODO: support passing the bitmask (fixme) tools/net/ynl/pyynl/ethtool.py:459:5: W0511: TODO: wol-get (fixme)
------------------------------------------------------------------
Your code has been rated at 9.97/10 (previous run: 8.59/10, +1.38)
v1 -> v2
- Fix f-string compatibility with python 3.9, thanks Jakub
- Fix AI review comments
https://netdev-ai.bots.linux.dev/ai-review.html?id=40420bc1-8119-4977-8062-e2047d90ae91
Donald Hunter (13):
tools: ynl: pylint suppressions and docstrings
tools: ynl: fix pylint redefinition, encoding errors
tools: ynl: fix pylint exception warnings
tools: ynl: fix pylint dict, indentation, long lines, uninitialised
tools: ynl: fix pylint misc warnings
tools: ynl: fix pylint global variable related warnings
tools: ynl: fix logic errors reported by pylint
tools: ynl: ethtool: fix pylint issues
tools: ynl: fix pylint issues in ynl_gen_rst
tools: ynl-gen-c: suppress unhelpful pylint messages
tools: ynl-gen-c: fix pylint warnings for returns, unused, redefined
tools: ynl-gen-c: fix pylint None, type, dict, generators, init
tools: ynl-gen-c: Fix remaining pylint warnings
tools/net/ynl/pyynl/cli.py | 67 +++++--- tools/net/ynl/pyynl/ethtool.py | 47 +++-- tools/net/ynl/pyynl/lib/__init__.py | 10 +- tools/net/ynl/pyynl/lib/doc_generator.py | 3 +- tools/net/ynl/pyynl/lib/nlspec.py | 77 +++++---- tools/net/ynl/pyynl/lib/ynl.py | 208 +++++++++++++---------- tools/net/ynl/pyynl/ynl_gen_c.py | 178 ++++++++++--------- tools/net/ynl/pyynl/ynl_gen_rst.py | 2 + 8 files changed, 343 insertions(+), 249 deletions(-)
Signature · 1 line
2.52.0