Skip to content

RFC experimental struct filename followups

Al Viro audit io-uring linux-fsdevel lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest8 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8non-consuming variant of do_renameat2()Documentation/filesystems/porting.rst fs/internal.h fs/namei.c +1 more+24 -140 replies
2/8non-consuming variant of do_linkat()Documentation/filesystems/porting.rst fs/init.c fs/internal.h +2 more+19 -160 replies
3/8non-consuming variant of do_symlinkat()Documentation/filesystems/porting.rst fs/init.c fs/internal.h +2 more+17 -130 replies
4/8non-consuming variant of do_mkdirat()Documentation/filesystems/porting.rst fs/init.c fs/internal.h +2 more+11 -80 replies
5/8non-consuming variant of do_mknodat()Documentation/filesystems/porting.rst fs/init.c fs/internal.h +1 more+12 -100 replies
6/8non-consuming variants of do_{unlinkat,rmdir}()Documentation/filesystems/porting.rst fs/coredump.c fs/init.c +3 more+23 -180 replies
7/8execve: fold {compat_,}do_execve{,at}() into their sole callersfs/exec.c+19 -610 replies
8/8do_execveat_common(): don't consume filename referencefs/exec.c+9 -60 replies

Reviews trailers per patch

None of the 8 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchChristian Brauner
SeriesR-b
1/8
2/8
3/8
4/8
5/8
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC PATCH 0/8] experimental struct filename followups

This series switches the filename-consuming primitives to variants that leave dropping the reference(s) to caller. These days it's fairly painless, and results look simpler wrt lifetime rules:
* with 3 exceptions, all instances have constructors and destructors
happen in the same scope (via CLASS(filename...), at that)
* CLASS(filename_consume) has no users left, could be dropped.
* exceptions are:
* audit dropping the references it stashed in audit_names
* fsconfig(2) creating and dropping references in two subcommands
* fs_lookup_param() playing silly buggers.
That's it.
If we go that way, this will certainly get reordered back into the main series and have several commits in there ripped apart and folded into these ones. E.g. no sense to convert do_renameat2() et.al. to filename_consume, only to have that followed by the first 6 commits here, etc.

For now I've put those into #experimental.filename, on top of #work.filename. Comments would be very welcome...

Al Viro (8):
non-consuming variant of do_renameat2()
non-consuming variant of do_linkat()
non-consuming variant of do_symlinkat()
non-consuming variant of do_mkdirat()
non-consuming variant of do_mknodat()
non-consuming variants of do_{unlinkat,rmdir}()
execve: fold {compat_,}do_execve{,at}() into their sole callers do_execveat_common(): don't consume filename reference

 Documentation/filesystems/porting.rst |  8 +++
 fs/coredump.c                         |  3 +-
 fs/exec.c                             | 87 ++++++++-------------------
 fs/init.c                             | 22 ++++---
 fs/internal.h                         | 14 ++---
 fs/namei.c                            | 87 +++++++++++++++------------
 io_uring/fs.c                         | 25 +++++---
 7 files changed, 117 insertions(+), 129 deletions(-)