`syn` rewrite of pin-init
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest1 of 13 patches 0 repliesNew
1 of 13 patches is in this archive. The cover letter announces 13.
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 13/13 | MAINTAINERS: add Gary Guo to pin-initMAINTAINERS | +1 | 0 replies |
Reviews trailers per patch
The patch has a Reviewed-by or Acked-by.
| Patch | Janne Grunau | Gary Guo |
|---|---|---|
| Series | Requested-by | |
| 13/13 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 00/13] `syn` rewrite of pin-init
Rewrite the proc-macros of pin-init by using the syn crate for Rust syntax parsing. This series has been a long way coming. At the very start of pin-init, I initially implemented everything using syn, since parsing is so much easier with it. Now after several years it is finally time to remove the dreaded 1600 lines of declarative macros required to parse and expand the initializer syntax.
The move to syn is not only a blessing for the maintenance work, but also improves the implementation of new features. This series includes many such improvements.
* Patch 1, 2 and 3 prepare for the rewrite. The first removes the superfluous try_ variants of the initializer macros from pin-init. Note that the kernel defines its own, so no code changes in the kernel are required. The second patch allows using ::pin_init in the pin-init crate. The third adds the syn dependency and cleans up some old workarounds and new clippy warnings.
* Patch 4, 5, 6, and 8 rewrite the derive macros for Zeroable, #[pinned_drop] attribute macro, #[pin_data] attribute macro, and the initializer macros respectively using syn.
* Patch 7 ensures soundness in the future by fixing generic bounds in generated code by #[pin_data].
* Patch 9 adds the #[default_error(type)] attribute to initializer macros allowing them to specify a default error that is used when no error is manually specified.
* Patch 10 uses #[default_error(type)] in the definition of the kernel's try_ variants of the initializer macros (which defaults to the kernel's Error type).
* Patch 11 allows putting attributes on fields in initializer macros (for example cfg attributes).
* Patch 12 adds #[disable_initialized_field_access] to support packed structs.
* Patch 13 adds Gary as a maintainer.
In addition to the new features, using syn results in much cleaner error messages and more accurate span information. The code is much easier to read as well and hopefully easier to understand as well.
As always, tests that ensure the correctness of the macro output are included and updated in the upstream pin-init repository. Take a look at the pull request on GitHub for the diff in the test output:
https://github.com/Rust-for-Linux/pin-init/pull/89
I would greatly appreciate Tested-by's from people actively using pin-init weather in the kernel or outside.
Cheers,
Benno
Benno Lossin (13):
rust: pin-init: remove try_ versions of the initializer macros
rust: pin-init: allow the crate to refer to itself as pin-init in
doc tests
rust: pin-init: add syn dependency and remove proc-macro[2] and
quote workarounds
rust: pin-init: rewrite derive(Zeroable) and derive(MaybeZeroable)
using syn
rust: pin-init: rewrite the #[pinned_drop] attribute macro using
`syn`
rust: pin-init: rewrite #[pin_data] using syn
rust: pin-init: add ?Sized bounds to traits in #[pin_data] macro
rust: pin-init: rewrite the initializer macros using syn
rust: pin-init: add #[default_error(<type>)] attribute to
initializer macros
rust: init: use #[default_error(err)] for the initializer macros
rust: pin-init: internal: init: add support for attributes on
initializer fields
rust: pin-init: internal: init: add escape hatch for referencing
initialized fields
MAINTAINERS: add Gary Guo to pin-init
MAINTAINERS | 1 + rust/Makefile | 16 +- rust/kernel/init.rs | 40 +- rust/pin-init/README.md | 2 +- rust/pin-init/examples/linked_list.rs | 19 +- rust/pin-init/examples/pthread_mutex.rs | 10 +- rust/pin-init/internal/src/helpers.rs | 152 -- rust/pin-init/internal/src/init.rs | 547 +++++++ rust/pin-init/internal/src/lib.rs | 60 +- rust/pin-init/internal/src/pin_data.rs | 649 ++++++-- rust/pin-init/internal/src/pinned_drop.rs | 89 +- rust/pin-init/internal/src/zeroable.rs | 151 +- rust/pin-init/src/lib.rs | 173 +-- rust/pin-init/src/macros.rs | 1677 --------------------- scripts/generate_rust_analyzer.py | 2 +- 15 files changed, 1286 insertions(+), 2302 deletions(-) delete mode 100644 rust/pin-init/internal/src/helpers.rs create mode 100644 rust/pin-init/internal/src/init.rs delete mode 100644 rust/pin-init/src/macros.rs
base-commit: 9448598b22c50c8a5bb77a9103e2d49f134c9578
Signature · 1 line
2.51.2