dpll: Core improvements and ice E825-C SyncE support
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest12 patches 23 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/12 | dt-bindings: dpll: add common dpll-pin-consumer schemaDocumentation/ MAINTAINERS | +31 | 11 replies | |
| 2/12 | dpll: Allow associating dpll pin with a firmware nodedrivers/ drivers/ include/ | +62 | 1 reply | |
| 3/12 | dpll: Add helpers to find DPLL pin fwnodedrivers/ include/ | +35 | 7 replies | |
| 4/12 | dpll: zl3073x: Associate pin with fwnode handledrivers/ | +1 | 0 replies | |
| 5/12 | dpll: Add notifier chain for dpll eventsdrivers/ drivers/ drivers/ +1 more | +96 | 1 reply | |
| 6/12 | dpll: Support dynamic pin index allocationdrivers/ include/ | +48 | 1 reply | |
| 7/12 | dpll: zl3073x: Add support for mux pin typedrivers/ | +2 | 0 replies | |
| 8/12 | dpll: Enhance and consolidate reference counting logicdrivers/ | +50 | 0 replies | |
| 9/12 | dpll: Prevent duplicate registrationsdrivers/ | +4 | 0 replies | |
| 10/12 | dpll: Add reference count tracking supportdrivers/ drivers/ drivers/ +5 more | +138 | 0 replies | |
| 11/12 | drivers: Add support for DPLL reference count trackingdrivers/ drivers/ drivers/ +3 more | +41 | 0 replies | |
| 12/12 | ice: dpll: Support E825-C SyncE and dynamic pin discoverydrivers/ drivers/ drivers/ +5 more | +925 | 2 replies |
Reviews trailers per patch
3 of 12 patches have a Reviewed-by or Acked-by.
| Patch | Aleksandr Loktionov | Vadim Fedorenko |
|---|---|---|
| 1/12 | ||
| 2/12 | R-b | |
| 3/12 | ||
| 4/12 | ||
| 5/12 | R-b | |
| 6/12 | ||
| 7/12 | ||
| 8/12 | ||
| 9/12 | ||
| 10/12 | ||
| 11/12 | ||
| 12/12 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next 00/12] dpll: Core improvements and ice E825-C SyncE support
This series introduces Synchronous Ethernet (SyncE) support for the Intel E825-C Ethernet controller. Unlike previous generations where DPLL connections were implicitly assumed, the E825-C architecture relies on the platform firmware to describe the physical connections between the network controller and external DPLLs (such as the ZL3073x).
To accommodate this, the series extends the DPLL subsystem to support firmware node (fwnode) associations, asynchronous discovery via notifiers, and dynamic pin management. Additionally, a significant refactor of the DPLL reference counting logic is included to ensure robustness and debuggability.
DPLL Core Extensions:
* Firmware Node Support: Pins can now be registered with an associated struct fwnode_handle. This allows consumer drivers to lookup pins based on device properties (dpll-pins).
* Asynchronous Notifiers: A raw notifier chain is added to the DPLL core. This allows the network driver (ice driver in this series) to subscribe to events and react when the platform DPLL driver registers the parent pins, resolving probe ordering dependencies.
* Dynamic Indexing: Drivers can now request DPLL_PIN_IDX_UNSPEC to have the core automatically allocate a unique pin index, simplifying driver implementation for virtual or non-indexed pins.
Reference Counting & Debugging:
* Refactor: The reference counting logic in the core is consolidated. Internal list management helpers now automatically handle hold/put operations, removing fragile open-coded logic in the registration paths.
* Duplicate Checks: The core now strictly rejects duplicate registration attempts for the same pin/device context.
* Reference Tracking: A new Kconfig option DPLL_REFCNT_TRACKER is added (using the kernel's REF_TRACKER infrastructure). This allows developers to instrument and debug reference leaks by recording stack traces for every get/put operation.
Driver Updates:
* zl3073x: Updated to register pins with their firmware nodes and support the 'mux' pin type.
* ice: Implements the E825-C specific hardware configuration for SyncE (CGU registers). It utilizes the new notifier and fwnode APIs to dynamically discover and attach to the platform DPLLs.
Patch Summary:
* Patch 1-3:
DT pin consumer schema and helper functions for finding DPLL pins via fwnode.
* Patch 4:
Updates zl3073x to register pins with fwnode.
* Patch 5-6:
Adds notifiers and dynamic pin index allocation to DPLL core.
* Patch 7:
Adds 'mux' pin type support to zl3073x.
* Patch 8-9:
Refactors DPLL core refcounting and adds duplicate registration checks.
* Patch 10-11:
Adds REF_TRACKER infrastructure and updates existing drivers to support it.
* Patch 12:
Implements the E825-C SyncE logic in the ice driver using the new infrastructure.
Arkadiusz Kubalewski (1):
ice: dpll: Support E825-C SyncE and dynamic pin discovery
Ivan Vecera (10):
dt-bindings: dpll: add common dpll-pin-consumer schema
dpll: Allow associating dpll pin with a firmware node
dpll: Add helpers to find DPLL pin fwnode
dpll: zl3073x: Associate pin with fwnode handle
dpll: Support dynamic pin index allocation
dpll: zl3073x: Add support for mux pin type
dpll: Enhance and consolidate reference counting logic
dpll: Prevent duplicate registrations
dpll: Add reference count tracking support
drivers: Add support for DPLL reference count tracking
Petr Oros (1):
dpll: Add notifier chain for dpll events
.../bindings/dpll/dpll-pin-consumer.yaml | 30 + drivers/dpll/Kconfig | 15 + drivers/dpll/dpll_core.c | 320 +++++++- drivers/dpll/dpll_core.h | 11 + drivers/dpll/dpll_netlink.c | 6 + drivers/dpll/zl3073x/dpll.c | 15 +- drivers/dpll/zl3073x/dpll.h | 2 + drivers/dpll/zl3073x/prop.c | 2 + drivers/net/ethernet/intel/ice/ice_dpll.c | 728 +++++++++++++++--- drivers/net/ethernet/intel/ice/ice_dpll.h | 29 + drivers/net/ethernet/intel/ice/ice_lib.c | 3 + drivers/net/ethernet/intel/ice/ice_ptp.c | 29 + drivers/net/ethernet/intel/ice/ice_ptp_hw.c | 9 +- drivers/net/ethernet/intel/ice/ice_tspll.c | 217 ++++++ drivers/net/ethernet/intel/ice/ice_tspll.h | 13 +- drivers/net/ethernet/intel/ice/ice_type.h | 6 + .../net/ethernet/mellanox/mlx5/core/dpll.c | 16 +- drivers/ptp/ptp_ocp.c | 18 +- include/linux/dpll.h | 74 +- 19 files changed, 1385 insertions(+), 158 deletions(-) create mode 100644 Documentation/devicetree/bindings/dpll/dpll-pin-consumer.yaml
Signature · 1 line
2.52.0