remoteproc: qcom_q6v5_wcss: add native ipq9574 support
Status from this message: Applied, thanks!
Get series with b4
b4 am [email protected]Versions newest first
Changes in v2 from the cover letter
- Improve bindings following review feedback
- disable clocks on init failures in q6v7_wcss_reset()
- review-suggetsed readability improvements of qcom_q6v5_wcss
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | remoteproc: qcom_q6v5_wcss: drop unused clocks from q6v5 structdrivers/ | +0 | 2 replies | |
| 2/9 | dt-bindings: remoteproc: qcom,ipq8074-wcss-pil: convert to DT schemaDocumentation/ Documentation/ | +157 | 1 reply | |
| 3/9 | dt-bindings: clock: gcc-ipq9574: add wcss remoteproc clocksinclude/ | +22 | 1 reply | |
| 4/9 | dt-bindings: remoteproc: qcom: add IPQ9574 image loaderDocumentation/ | +114 | 1 reply | |
| 5/9 | arm64: dts: qcom: ipq9574: add wcss remoteproc nodesarch/ | +101 | 0 replies | |
| 6/9 | clk: qcom: gcc-ipq9574: add wcss remoteproc clocksdrivers/ | +378 | 0 replies | |
| 7/9 | remoteproc: qcom_q6v5_wcss: support IPQ9574drivers/ | +246 | 0 replies | |
| 8/9 | remoteproc: qcom_q6v5_wcss: support m3 firmwaredrivers/ | +40 | 0 replies | |
| 9/9 | remoteproc: qcom_q6v5_wcss: use bulk clk API for q6 clocks in QCS404drivers/ | +28 | 0 replies |
Reviews trailers per patch
4 of 9 patches have a Reviewed-by or Acked-by.
| Patch | Krzysztof Kozlowski | Konrad Dybcio |
|---|---|---|
| 1/9 | R-b | R-b |
| 2/9 | R-b | |
| 3/9 | A-b | |
| 4/9 | R-b | |
| 5/9 | ||
| 6/9 | ||
| 7/9 | ||
| 8/9 | ||
| 9/9 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/9] remoteproc: qcom_q6v5_wcss: add native ipq9574 support
Support loading remoteproc firmware on IPQ9574 with the qcom_q6v5_wcss driver. This firmware is usually used to run ath11k firmware and enable wifi with chips such as QCN5024.
When submitting v1, I learned that the firmware can also be loaded by the trustzone firmware. Since TZ is not shipped with the kernel, it makes sense to have the option of a native init sequence, as not all devices come with the latest TZ firmware.
Qualcomm tries to assure us that the TZ firmware will always do the right thing (TM), but I am not fully convinced, and believe there is justification for a native remoteproc loader. Besides, this series has improvements to the existing code.
Changes since v1:
- Improve bindings following review feedback
- disable clocks on init failures in q6v7_wcss_reset()
- review-suggetsed readability improvements of qcom_q6v5_wcss
Alexandru Gagniuc (9):
remoteproc: qcom_q6v5_wcss: drop unused clocks from q6v5 struct
dt-bindings: remoteproc: qcom,ipq8074-wcss-pil: convert to DT schema
dt-bindings: clock: gcc-ipq9574: add wcss remoteproc clocks
dt-bindings: remoteproc: qcom: add IPQ9574 image loader
arm64: dts: qcom: ipq9574: add wcss remoteproc nodes
clk: qcom: gcc-ipq9574: add wcss remoteproc clocks
remoteproc: qcom_q6v5_wcss: support IPQ9574
remoteproc: qcom_q6v5_wcss: support m3 firmware
remoteproc: qcom_q6v5_wcss: use bulk clk API for q6 clocks in QCS404
.../remoteproc/qcom,ipq8074-wcss-pil.yaml | 268 ++++++++++++ .../bindings/remoteproc/qcom,q6v5.txt | 102 ----- arch/arm64/boot/dts/qcom/ipq9574.dtsi | 101 +++++ drivers/clk/qcom/gcc-ipq9574.c | 378 +++++++++++++++++ drivers/remoteproc/qcom_q6v5_wcss.c | 398 ++++++++++++++---- include/dt-bindings/clock/qcom,ipq9574-gcc.h | 22 + 6 files changed, 1082 insertions(+), 187 deletions(-) create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,ipq8074-wcss-pil.yaml delete mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
--
2.45.1