Skip to content

remoteproc: qcom_q6v5_wcss: add native ipq9574 support

Alexandru Gagniuc linux-arm-msm linux-clk linux-devicetree linux-remoteproc lkml 1 version Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest9 patches 23 repliesApplied

Changes in v2 from the cover letter

- Improve bindings following review feedback
- disable clocks on init failures in q6v7_wcss_reset()
- review-suggetsed readability improvements of qcom_q6v5_wcss

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/9remoteproc: qcom_q6v5_wcss: drop unused clocks from q6v5 structdrivers/remoteproc/qcom_q6v5_wcss.c+0 -32 replies
2/9dt-bindings: remoteproc: qcom,ipq8074-wcss-pil: convert to DT schemaDocumentation/devicetree/bindings/remoteproc/qcom,ipq8074-wcss-pil.yaml Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt+157 -1021 reply
3/9dt-bindings: clock: gcc-ipq9574: add wcss remoteproc clocksinclude/dt-bindings/clock/qcom,ipq9574-gcc.h+22 -01 reply
4/9dt-bindings: remoteproc: qcom: add IPQ9574 image loaderDocumentation/devicetree/bindings/remoteproc/qcom,ipq8074-wcss-pil.yaml+114 -21 reply
5/9arm64: dts: qcom: ipq9574: add wcss remoteproc nodesarch/arm64/boot/dts/qcom/ipq9574.dtsi+101 -00 replies
6/9clk: qcom: gcc-ipq9574: add wcss remoteproc clocksdrivers/clk/qcom/gcc-ipq9574.c+378 -00 replies
7/9remoteproc: qcom_q6v5_wcss: support IPQ9574drivers/remoteproc/qcom_q6v5_wcss.c+246 -70 replies
8/9remoteproc: qcom_q6v5_wcss: support m3 firmwaredrivers/remoteproc/qcom_q6v5_wcss.c+40 -50 replies
9/9remoteproc: qcom_q6v5_wcss: use bulk clk API for q6 clocks in QCS404drivers/remoteproc/qcom_q6v5_wcss.c+28 -710 replies

Reviews trailers per patch

4 of 9 patches have a Reviewed-by or Acked-by.

PatchKrzysztof KozlowskiKonrad Dybcio
1/9R-b R-b
2/9R-b
3/9A-b
4/9R-b
5/9
6/9
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/9] remoteproc: qcom_q6v5_wcss: add native ipq9574 support

Support loading remoteproc firmware on IPQ9574 with the qcom_q6v5_wcss driver. This firmware is usually used to run ath11k firmware and enable wifi with chips such as QCN5024.

When submitting v1, I learned that the firmware can also be loaded by the trustzone firmware. Since TZ is not shipped with the kernel, it makes sense to have the option of a native init sequence, as not all devices come with the latest TZ firmware.

Qualcomm tries to assure us that the TZ firmware will always do the right thing (TM), but I am not fully convinced, and believe there is justification for a native remoteproc loader. Besides, this series has improvements to the existing code.

Changes since v1:
- Improve bindings following review feedback
- disable clocks on init failures in q6v7_wcss_reset()
- review-suggetsed readability improvements of qcom_q6v5_wcss

Alexandru Gagniuc (9):
remoteproc: qcom_q6v5_wcss: drop unused clocks from q6v5 struct
dt-bindings: remoteproc: qcom,ipq8074-wcss-pil: convert to DT schema
dt-bindings: clock: gcc-ipq9574: add wcss remoteproc clocks
dt-bindings: remoteproc: qcom: add IPQ9574 image loader
arm64: dts: qcom: ipq9574: add wcss remoteproc nodes
clk: qcom: gcc-ipq9574: add wcss remoteproc clocks
remoteproc: qcom_q6v5_wcss: support IPQ9574
remoteproc: qcom_q6v5_wcss: support m3 firmware
remoteproc: qcom_q6v5_wcss: use bulk clk API for q6 clocks in QCS404

 .../remoteproc/qcom,ipq8074-wcss-pil.yaml     | 268 ++++++++++++
 .../bindings/remoteproc/qcom,q6v5.txt         | 102 -----
 arch/arm64/boot/dts/qcom/ipq9574.dtsi         | 101 +++++
 drivers/clk/qcom/gcc-ipq9574.c                | 378 +++++++++++++++++
 drivers/remoteproc/qcom_q6v5_wcss.c           | 398 ++++++++++++++----
 include/dt-bindings/clock/qcom,ipq9574-gcc.h  |  22 +
 6 files changed, 1082 insertions(+), 187 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,ipq8074-wcss-pil.yaml
 delete mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt

--
2.45.1