Skip to content

misc LPM related fixes

Niklas Cassel linux-ide 2 versions – Applied

Status from this message: Applied to for-6.20-fixes. Thanks !

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 6 repliesApplied
  2. v15 patches 0 repliesSuperseded

Changes in v2 from the cover letter

-Fixed typos in commit messages
-Split early return patch into two, so that they only have a single
Fixes-tag each.
-Reordered patches to make it easier to only apply the important ones
for the current v6.19 kernel.

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/6ata: ahci: Do not read the per port area for unimplemented portsdrivers/ata/ahci.c+5 -50 replies
2/6ata: libata: Call ata_dev_config_lpm() for ATAPI devicesdrivers/ata/libata-core.c+2 -00 replies
3/6ata: libata-sata: Improve link_power_management_supported sysfs attributedrivers/ata/libata-sata.c+1 -14 replies
4/6ata: libata: Add cpr_log to ata_dev_print_features() early returndrivers/ata/libata-core.c+1 -10 replies
5/6ata: libata: Add DIPM and HIPM to ata_dev_print_features() early returndrivers/ata/libata-core.c+2 -10 replies
6/6ata: libata: Print features also for ATAPI devicesdrivers/ata/libata-core.c+3 -00 replies

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by.

PatchWolf
SeriesT-b
1/6
2/6
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/6] misc LPM related fixes

Hello there,

we had a recent bug report on the mailing list related to LPM, which made me review the LPM related code.

While doing so, I found some issues. This series fixes those issues.

The most serious issue is that ATA_QUIRK_NOLPM was not getting applied for ATAPI devices and that we read the per port area for unimplemented ports, even though the AHCI specification explicitly forbids this.

Kind regards,
Niklas

Changes since v1:
-Fixed typos in commit messages
-Split early return patch into two, so that they only have a single
Fixes-tag each.
-Reordered patches to make it easier to only apply the important ones
for the current v6.19 kernel.

Niklas Cassel (6):
ata: ahci: Do not read the per port area for unimplemented ports
ata: libata: Call ata_dev_config_lpm() for ATAPI devices
ata: libata-sata: Improve link_power_management_supported sysfs
attribute
ata: libata: Add cpr_log to ata_dev_print_features() early return
ata: libata: Add DIPM and HIPM to ata_dev_print_features() early
return
ata: libata: Print features also for ATAPI devices

 drivers/ata/ahci.c        | 10 +++++-----
 drivers/ata/libata-core.c |  8 +++++++-
 drivers/ata/libata-sata.c |  2 +-
 3 files changed, 13 insertions(+), 7 deletions(-)

base-commit: 97e01439e902b743b8f89497e9c144e3ddda5e59

Signature · 1 line
2.52.0