Skip to content

imu: st_lsm6dsx: Add support for rotation sensor

Francesco Lavra linux-doc linux-iio lkml llvm oe-kbuild-all 9 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest6 patches 5 repliesIn review
  2. v86 patches 12 repliesSuperseded
  3. v76 patches 29 repliesSuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v67 patches17 repliesSuperseded
v54 patches10 repliesSuperseded
v42 of 4 patches0 repliesSuperseded
v33 patches7 repliesSuperseded
v23 patches11 repliesSuperseded
v13 patches15 repliesSuperseded

Patches in v9 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6iio: imu: st_lsm6dsx: Fix check for invalid samples from FIFOdrivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c+22 -92 replies
2/6iio: Replace 'sign' field with union in struct iio_scan_typeDocumentation/driver-api/iio/buffers.rst include/linux/iio/iio.h+23 -40 replies
3/6iio: tools: Add support for floating-point types in buffer scan elementstools/iio/iio_generic_buffer.c tools/iio/iio_utils.c tools/iio/iio_utils.h+70 -160 replies
4/6iio: ABI: Add support for floating-point numbers in buffer scan elementsDocumentation/ABI/testing/sysfs-bus-iio Documentation/driver-api/iio/buffers.rst Documentation/iio/iio_devbuf.rst +1 more+29 -170 replies
5/6iio: ABI: Add quaternion axis modifierDocumentation/ABI/testing/sysfs-bus-iio drivers/iio/industrialio-core.c include/uapi/linux/iio/types.h +1 more+18 -00 replies
6/6iio: imu: st_lsm6dsx: Add support for rotation sensordrivers/iio/imu/st_lsm6dsx/Makefile drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c +2 more+333 -72 replies

Reviews trailers per patch

3 of 6 patches have a Reviewed-by or Acked-by.

PatchLorenzo BianconiDavid Lechner
1/6A-b
2/6
3/6
4/6
5/6R-b
6/6A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v9 thread

Cover letter [PATCH v9 0/6] imu: st_lsm6dsx: Add support for rotation sensor

This series adds support for the rotation sensor functionality present in some chips from the ST LSM6DSX IMU family.
The IIO ABI has been amended to allow the use of floating-point data and a "quaternion axis" channel modifier in IIO buffers.

The use of the new modifier depends on [0] to get the correct sizing of the buffer in userspace.

Tested on LSM6DSV16X.

Changes from v8 [8]:
- changed comments for IIO_SCAN_FORMAT_* macros to use proper kernel doc format with one comment per macro (David)
- in tools/iio, added error print if 1-byte floats are encountered and if 2-byte floats are encountered when unsupported (David)
- in tools/iio, renamed signchar variable to formatchar (David)
- added David's Reviewed-by tag to patch 5
- in st_lsm6dsx_fusion.c, avoided mixing cleanup and gotos by adding a helper function (Jonathan)
- in st_lsm6dsx_fusion.c, removed leading double spaces in comment (Jonathan)
- in ST_LSM6DSX_CHANNEL_ROT macro, replaced literal 'f' with IIO_SCAN_FORMAT_FLOAT

Changes from v7 [7]:
- added Lorenzo's Acked-by tag to patch 1
- in st_lsm6dsx_buffer.c, added st_lsm6dsx_check_data() helper function (Lorenzo)
- added definition of IIO_SCAN_FORMAT_* symbolic constants to restrict flexibility of what can go in .format (Jonathan)
- re-added @sign description in kernel.doc comment for
struct iio_scan_type, mentioning that @format should be used in new code (Jonathan)
- in tools/iio/iio_generic_buffer, replaced legacy __fp16 type with standard-compliant _Float16 (David)
- in tools/iio/iio_generic_buffer, added check for compiler support (David), so that compilation does not fail with compilers that don't support _Float16: tested with gcc for x86-64 (supported), for aarch64 (supported), for riscv-64 (not supported), clang for x86-64 (not supported)
- in tols/iio/iio_utils.h, replaced unsigned with char type for format field in struct iio_channel_info (David)
- renamed "partial quaternion" modifier to "quaternion axis"
- moved new modifier value at the end of enum iio_modifier (David)
- squashed the two words together in the modifier name (Jonathan)
- in ABI doc for new modifier, fixed typo and angle units (David)
- in ABI doc for new modifier, fixed kernel-doc warning (kernel test robot)
- in st_lsm6dsx_fusion.c, added missing header includes (Andy)

Changes from v6 [6]:
- dropped patches 1 and 2 (already picked up by Jonathan)
- added floating-point support to iio-tools (Andy)
- replaced sign field in struct iio_scan_type with union instead of format field (David, Jonathan)
- changed [s|u|f] to [f|s|u] in ABI and driver documentation files (Andy)
- removed IIO_CUSTOM channel type in favor of IIO_MOD_PARTIAL_QUATERNION modifier (David, Andy)
- replaced "sf" with "fusion" in type, variable and function names (David)
- added copyright statement in st_lsm6dsx_fusion.c (David)
- added ret variable in st_lsm6dsx_fusion_probe() for better readability (Andy)
- modified data structure holding the list of available frequencies in order to replace device attribute with .read_avail callback (David)

Changes from v5 [5]:
- cleaned up FIFO data representation in st_lsm6dsx_read_tagged_fifo() to avoid casting (Andy, Jonathan)
- renamed 'sign' field to format in struct iio_scan_type
- added support for IEEE 754 floating-point format in buffer scan elements
- added custom data type in the ABI (IIO_CUSTOM in enum iio_chan_type) (Jonathan)
- added driver document in Documentation/iio/ (Jonathan)

Changes from v4 [4]:
- changed data parameter in st_lsm6dsx_push_tagged_data() to __le16 * (Andy)

Changes from v3 [3]:
- added patch 3 (Andy)
- removed unneeded checks for negative return values in st_lsm6dsx_fusion.c (Andy)
- replaced st_lsm6dsx_sf_set_page function with st_lsm6dsx_sf_page_enable/disable (Andy)
- used reversed xmas tree ordering for local variables (Andy)
- added parentheses to MILLI / MICRO in st_lsm6dsx_sf_write_raw (Andy)
- added check for string truncation in st_lsm6dsx_sf_probe (Andy)

Changes from v2 [2]:
- amended description of patch 2 to point out that there are no supported gyro events (Jonathan)
- removed superfluous parentheses in st_lsm6dsx_fifo_setup (Lorenzo)
- added Lorenzo's acked-by tag to patch 3
- added missing checks of st_lsm6dsx_sf_set_page() return value (Jonathan)
- added comment in st_lsm6dsx_sf_write_raw (Jonathan)

Changes from v1 [1]:
- swapped patches 1 and 2 (Jonathan)
- miscellaneous stylistic changes (Andy)
- fixed usage of MICRO and MILLI constants in st_lsm6dsx_sf_read_raw and st_lsm6dsx_sf_write_raw (Andy)
- replaced scnprintf() with sysfs_emit_at() in st_lsm6dsx_sf_sampling_freq_avail (Andy)
- replaced scnprintf() with snprintf() in st_lsm6dsx_sf_probe (Andy)
- clarified in a comment in st_lsm6dsx_set_fifo_odr() that only internal sensors have a FIFO ODR configuration register (Jonathan)
- modified patch 3 description to explain justification for the extra IIO device (Jonathan)
- moved page lock from st_lsm6dsx_sf_set_page() to the callers (Jonathan)
- s/magnetometer/gyroscope/ in patch 2 description

[0]: https://lore.kernel.org/linux-iio/20260307-iio-fix-timestamp-alignment-v2-4-d1d48fbadbbf@baylibre.com/
[1] https://lore.kernel.org/linux-iio/[email protected]/T/
[2] https://lore.kernel.org/linux-iio/[email protected]/T/
[3] https://lore.kernel.org/linux-iio/[email protected]/T/
[4] https://lore.kernel.org/linux-iio/[email protected]/T/
[5] https://lore.kernel.org/linux-iio/[email protected]/T/
[6] https://lore.kernel.org/linux-iio/[email protected]/T/
[7] https://lore.kernel.org/linux-iio/[email protected]/T/
[8] https://lore.kernel.org/linux-iio/[email protected]/T/

Francesco Lavra (6):
iio: imu: st_lsm6dsx: Fix check for invalid samples from FIFO
iio: Replace 'sign' field with union in struct iio_scan_type
iio: tools: Add support for floating-point types in buffer scan
elements
iio: ABI: Add support for floating-point numbers in buffer scan
elements
iio: ABI: Add quaternion axis modifier
iio: imu: st_lsm6dsx: Add support for rotation sensor

 Documentation/ABI/testing/sysfs-bus-iio       |  48 ++--
 Documentation/driver-api/iio/buffers.rst      |   7 +-
 Documentation/iio/iio_devbuf.rst              |   3 +-
 drivers/iio/imu/st_lsm6dsx/Makefile           |   2 +-
 drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h       |  28 +-
 .../iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c    |  40 ++-
 drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c  |  58 +++++
 .../iio/imu/st_lsm6dsx/st_lsm6dsx_fusion.c    | 243 ++++++++++++++++++
 drivers/iio/industrialio-core.c               |   1 +
 include/linux/iio/iio.h                       |  30 ++-
 include/uapi/linux/iio/types.h                |   1 +
 tools/iio/iio_event_monitor.c                 |   1 +
 tools/iio/iio_generic_buffer.c                |  70 ++++-
 tools/iio/iio_utils.c                         |  12 +-
 tools/iio/iio_utils.h                         |   4 +-
 15 files changed, 495 insertions(+), 53 deletions(-)
 create mode 100644 drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_fusion.c
Signature · 1 line
2.39.5