Skip to content

tools: ynl: cli: improve the help and doc

Jakub Kicinski netdev 2 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 3 repliesApplied 7/7
  2. v17 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- patch 2: remove unnecessary isatty() check
v1: https://lore.kernel.org/[email protected]

Patches in v2 All 7 applied

#Subject and filesSizeRepliesApplied
1/7tools: ynl: cli: introduce formatting for attr names in --list-attrstools/net/ynl/pyynl/cli.py+27 -30 repliesApplied
2/7tools: ynl: cli: wrap the doc text if it's longtools/net/ynl/pyynl/cli.py+6 -10 repliesApplied
3/7tools: ynl: cli: improve --helptools/net/ynl/pyynl/cli.py+69 -380 repliesApplied
4/7tools: ynl: cli: add --doc as alias to --list-attrstools/net/ynl/pyynl/cli.py+1 -10 repliesApplied
5/7tools: ynl: cli: factor out --list-attrs / --doc handlingtools/net/ynl/pyynl/cli.py+20 -150 repliesApplied
6/7tools: ynl: cli: extract the event/notify handling in --list-attrstools/net/ynl/pyynl/cli.py+12 -90 repliesApplied
7/7tools: ynl: cli: print reply in combined format if possibletools/net/ynl/pyynl/cli.py+17 -40 repliesApplied

Reviews trailers per patch

None of the 7 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchGal PressmanStanislav FomichevDonald Hunter
SeriesT-b A-b R-b
1/7
2/7
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH net-next v2 0/7] tools: ynl: cli: improve the help and doc

I had some time on the plane to LPC, so here are improvements to the --help and --list-attrs handling of YNL CLI which seem in order given growing use of YNL as a real CLI tool.

v2:
- patch 2: remove unnecessary isatty() check
v1: https://lore.kernel.org/[email protected]

Jakub Kicinski (7):
tools: ynl: cli: introduce formatting for attr names in --list-attrs
tools: ynl: cli: wrap the doc text if it's long
tools: ynl: cli: improve --help
tools: ynl: cli: add --doc as alias to --list-attrs
tools: ynl: cli: factor out --list-attrs / --doc handling
tools: ynl: cli: extract the event/notify handling in --list-attrs
tools: ynl: cli: print reply in combined format if possible

 tools/net/ynl/pyynl/cli.py | 207 ++++++++++++++++++++++++++-----------
 1 file changed, 144 insertions(+), 63 deletions(-)
Signature · 1 line
2.52.0