Skip to content

t5403: improve post-checkout hook testing

Deveshi Dwivedi git 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 0 repliesNew
  2. v22 patches 1 replySuperseded
  3. v12 patches 3 repliesSuperseded

Changes in v3 from the cover letter

- Update commit message of patch 1/2 to note that the clone test now validates post-checkout hook arguments, not just hook execution.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2t5403:introduce check_post_checkout helper functiont/t5403-post-checkout-hook.sh+28 -210 replies
2/2t5403: use test_cmp for post-checkout argument checkst/t5403-post-checkout-hook.sh+4 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/2] t5403: improve post-checkout hook testing

Following up on the recently merged patch that replaced 'test -f' with test_path_is_file, this series continues the cleanup of the post-checkout hook tests.

Patch 1/2 introduces a check_post_checkout helper function to replace the repeated pattern of reading and validating hook arguments. This refactoring does not change test behavior, but makes the code easier to maintain and prepares it for further improvement.

Patch 2/2 updates the helper and hook output format to use test_cmp instead of individual test commands. This provides clearer error messages on failure, making it easier to see which argument (old ref, new ref, or flag) did not match the expectation

Changes since v2:
- Update commit message of patch 1/2 to note that the clone test now validates post-checkout hook arguments, not just hook execution.

Deveshi Dwivedi (2):
t5403:introduce check_post_checkout helper function
t5403: use test_cmp for post-checkout argument checks

 t/t5403-post-checkout-hook.sh | 53 ++++++++++++++++++++---------------
 1 file changed, 30 insertions(+), 23 deletions(-)
Signature · 1 line
2.52.0.230.gd8af7cadaa