Skip to content

net/mlx5: future HW devargs defaults and fixes

Maayan Kashani dpdk-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drivers: fix flow devarg handling for future HWdoc/guides/nics/mlx5.rst drivers/common/mlx5/mlx5_devx_cmds.c drivers/common/mlx5/mlx5_devx_cmds.h +2 more+111 -92 replies
2/4net/mlx5: fix default memzone requirements in HWSdrivers/net/mlx5/mlx5_flow_hw.c+68 -182 replies
3/4net/mlx5: fix internal HWS pattern template creationdrivers/net/mlx5/mlx5_flow_hw.c+25 -101 reply
4/4net/mlx5: fix redundant control rules in promiscuous modedrivers/net/mlx5/mlx5_trigger.c+10 -62 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchDariusz SosnowskiBing Zhao
1/4A-b
2/4A-b
3/4A-b
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] net/mlx5: future HW devargs defaults and fixes

This patch series contains bug fixes for the mlx5 PMD, primarily addressing issues with Hardware Steering (HWS) and flow devarg handling.

Summary of changes:

1. drivers: fix flow devarg handling for future HW Addresses SWS (Software Steering) deprecation on future hardware generations (e.g., ConnectX-9). Updates default behavior for dv_flow_en and allow_duplicate_pattern devargs based on device capabilities, with proper error handling and user feedback.

2. net/mlx5: fix default memzone requirements in HWS
Fixes memzone exhaustion when probing setups with ~1K SFs. The default HWS sync flow API configuration was allocating unnecessary rings (flow_transfer_pending/completed) that are only used with async flow API. This patch removes the unnecessary allocations to stay within memzone limits.

3. net/mlx5: fix internal HWS pattern template creation Improves PMD initialization time by separating pattern templates into internal and external categories. Internal templates (created by PMD) skip expensive validations, while application-provided templates remain fully validated.

4. net/mlx5: fix redundant control rules in promiscuous mode Removes redundant DMAC and multicast/broadcast control flow rules when promiscuous mode is enabled, as the device already receives all traffic in this mode.

All patches are targeted for stable backport.

Dariusz Sosnowski (1):
net/mlx5: fix default memzone requirements in HWS

Maayan Kashani (3):
drivers: fix flow devarg handling for future HW net/mlx5: fix internal HWS pattern template creation net/mlx5: fix redundant control rules in promiscuous mode

 doc/guides/nics/mlx5.rst             |  11 ++-
 drivers/common/mlx5/mlx5_devx_cmds.c |  18 ++++
 drivers/common/mlx5/mlx5_devx_cmds.h |   6 ++
 drivers/common/mlx5/mlx5_prm.h       |  14 +++-
 drivers/net/mlx5/mlx5.c              |  71 +++++++++++++++-
 drivers/net/mlx5/mlx5_flow_hw.c      | 121 ++++++++++++++++++++-------
 drivers/net/mlx5/mlx5_trigger.c      |  16 ++--
 7 files changed, 214 insertions(+), 43 deletions(-)
Signature · 1 line
2.21.0